rat:check at verify

2021-12-29 Thread Volkan Yazıcı
I suggest hooking apache-rat:check up to the verify stage in Maven. This will make CI run that goal too. Objections?

Re: rat:check at verify

2021-12-29 Thread Gary Gregory
+1 Gary On Wed, Dec 29, 2021 at 4:25 AM Volkan Yazıcı wrote: > I suggest hooking apache-rat:check up to the verify stage in Maven. This > will make CI run that goal too. Objections? >

Re: rat:check at verify

2021-12-29 Thread Matt Sicker
Makes perfect sense to me to try to catch these problems as early as possible! -- Matt Sicker > On Dec 29, 2021, at 06:46, Gary Gregory wrote: > > +1 > > Gary > > On Wed, Dec 29, 2021 at 4:25 AM Volkan Yazıcı wrote: > >> I suggest hooking apache-rat:check up to the verify stage in Maven. Thi

Re: rat:check at verify

2021-12-29 Thread Volkan Yazıcı
Pushed to both `release-2.x` and `master`. On Wed, Dec 29, 2021 at 10:25 AM Volkan Yazıcı wrote: > I suggest hooking apache-rat:check up to the verify stage in Maven. This > will make CI run that goal too. Objections? >

Re: rat:check at verify

2021-12-30 Thread Carter Kozak
Thank you! -ck > On Dec 30, 2021, at 02:27, Volkan Yazıcı wrote: > > Pushed to both `release-2.x` and `master`. > >> On Wed, Dec 29, 2021 at 10:25 AM Volkan Yazıcı wrote: >> >> I suggest hooking apache-rat:check up to the verify stage in Maven. This >> will make CI run that goal too. Object

Re: rat:check at verify

2021-12-30 Thread Gary Gregory
+1 :-) Gary On Thu, Dec 30, 2021, 08:40 Carter Kozak wrote: > Thank you! > > -ck > > > On Dec 30, 2021, at 02:27, Volkan Yazıcı wrote: > > > > Pushed to both `release-2.x` and `master`. > > > >> On Wed, Dec 29, 2021 at 10:25 AM Volkan Yazıcı wrote: > >> > >> I suggest hooking apache-rat:chec