[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735851#comment-13735851 ] Uwe Schindler commented on LUCENE-5161: --- Hi, I will now explain the problems of

[jira] [Comment Edited] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735851#comment-13735851 ] Uwe Schindler edited comment on LUCENE-5161 at 8/10/13 11:42 AM:

[jira] [Comment Edited] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735851#comment-13735851 ] Uwe Schindler edited comment on LUCENE-5161 at 8/10/13 12:09 PM:

Re: Copy-paste typo in org.apache.solr.highlight.DefaultSolrHighlighter#init

Jack, don't get me wrong, but wouldn't it be easier if you'd open an issue and attach a patch, if you already know where what needs to be changed? - Stefan On Saturday, August 10, 2013 at 2:48 AM, Jack Krupansky wrote: A copy paste typo in

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735895#comment-13735895 ] Robert Muir commented on LUCENE-5161: - in addition to the defaults, the javadocs that

Re: Copy-paste typo in org.apache.solr.highlight.DefaultSolrHighlighter#init

Not really. If typos are going to require issues... I’ll refrain from reporting them. (How many typo Jiras have you ever seen? Is there even a category for that?) I’ll certainly file issues for bugs and features, but for typos? No. If a committer sees a typo, are they required to file an issue

[jira] [Updated] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-5161: Attachment: LUCENE-5161.patch Updated patch, setting the default size to 2*MERGE_BUFFER_SIZE. I

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735914#comment-13735914 ] Robert Muir commented on LUCENE-5161: - I finished the 10M wikipedia, here was the

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735915#comment-13735915 ] Robert Muir commented on LUCENE-5161: - By the way I also fixed the TODO in this

[jira] [Assigned] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-5161: --- Assignee: Robert Muir review FSDirectory chunking defaults and test the chunking

[jira] [Updated] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-5161: Attachment: LUCENE-5161.patch final patch: i will move forward to remove this trap.

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735921#comment-13735921 ] Uwe Schindler commented on LUCENE-5161: --- I would use oal.util.Rethrow.rethrow(e)

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735922#comment-13735922 ] Robert Muir commented on LUCENE-5161: - Thanks Uwe, ill do that!

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735923#comment-13735923 ] ASF subversion and git services commented on LUCENE-5161: - Commit

[jira] [Commented] (LUCENE-5160) NIOFSDirectory, SimpleFSDirectory (others?) don't properly handle valid file and FileChannel read conditions

[ https://issues.apache.org/jira/browse/LUCENE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735925#comment-13735925 ] ASF subversion and git services commented on LUCENE-5160: - Commit

[jira] [Commented] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735926#comment-13735926 ] ASF subversion and git services commented on LUCENE-5161: - Commit

[jira] [Resolved] (LUCENE-5161) review FSDirectory chunking defaults and test the chunking

[ https://issues.apache.org/jira/browse/LUCENE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-5161. - Resolution: Fixed Fix Version/s: 4.5 5.0 Thanks for the thorough

[jira] [Created] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

Uwe Schindler created LUCENE-5164: - Summary: Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory Key: LUCENE-5164 URL: https://issues.apache.org/jira/browse/LUCENE-5164 Project: Lucene -

[jira] [Commented] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735930#comment-13735930 ] Robert Muir commented on LUCENE-5164: - +1 to remove the OOM-catching and remove the

[jira] [Commented] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735931#comment-13735931 ] Uwe Schindler commented on LUCENE-5164: --- We should also make SimpleIndexOutput use

[jira] [Commented] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735936#comment-13735936 ] Uwe Schindler commented on LUCENE-5164: --- Here is the code of RandomAccessFile's

[jira] [Comment Edited] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735936#comment-13735936 ] Uwe Schindler edited comment on LUCENE-5164 at 8/10/13 3:21 PM:

[jira] [Commented] (LUCENE-5101) make it easier to plugin different bitset implementations to CachingWrapperFilter

[ https://issues.apache.org/jira/browse/LUCENE-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735972#comment-13735972 ] Adrien Grand commented on LUCENE-5101: -- Patch looks good to me. Since join users are

[jira] [Created] (SOLR-5133) HdfsUpdateLog can fail to close a FileSystem instance if init is called more than once.

Mark Miller created SOLR-5133: - Summary: HdfsUpdateLog can fail to close a FileSystem instance if init is called more than once. Key: SOLR-5133 URL: https://issues.apache.org/jira/browse/SOLR-5133

[jira] [Updated] (SOLR-5133) HdfsUpdateLog can fail to close a FileSystem instance if init is called more than once.

[ https://issues.apache.org/jira/browse/SOLR-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-5133: -- Attachment: SOLR-5133.patch HdfsUpdateLog can fail to close a FileSystem instance if init is

[JENKINS] Lucene-Solr-4.x-Linux (32bit/jdk1.7.0_25) - Build # 6874 - Failure!

Build: http://jenkins.thetaphi.de/job/Lucene-Solr-4.x-Linux/6874/ Java: 32bit/jdk1.7.0_25 -server -XX:+UseG1GC 1 tests failed. REGRESSION: org.apache.lucene.search.postingshighlight.TestPostingsHighlighter.testUserFailedToIndexOffsets Error Message: Stack Trace: java.lang.AssertionError

[jira] [Updated] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: LUCENE-5164.patch Patch: - deprecates the readChunk size - uses the chunck size

[jira] [Assigned] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-5164: - Assignee: Uwe Schindler Remove the OOM cactching in SimpleFSDirectory and

[jira] [Comment Edited] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735979#comment-13735979 ] Uwe Schindler edited comment on LUCENE-5164 at 8/10/13 5:48 PM:

[jira] [Updated] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: LUCENE-5164.patch More cleanups. Remove the OOM cactching in

[jira] [Created] (LUCENE-5165) Add SuggestStopFilter

Michael McCandless created LUCENE-5165: -- Summary: Add SuggestStopFilter Key: LUCENE-5165 URL: https://issues.apache.org/jira/browse/LUCENE-5165 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-5165) Add SuggestStopFilter

[ https://issues.apache.org/jira/browse/LUCENE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5165: --- Attachment: LUCENE-5165.patch Patch, I think it's ready... it [sneakily] calls

[jira] [Updated] (LUCENE-5165) Add SuggestStopFilter

[ https://issues.apache.org/jira/browse/LUCENE-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5165: --- Component/s: modules/spellchecker Add SuggestStopFilter -

[jira] [Updated] (SOLR-3076) Solr(Cloud) should support block joins

[ https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-3076: --- Attachment: SOLR-3076.patch OK, here's a patch that fixes some bugs and removes the need for the user

[jira] [Created] (SOLR-5134) Have HdfsIndexOutput extend BufferedIndexOutput

Mark Miller created SOLR-5134: - Summary: Have HdfsIndexOutput extend BufferedIndexOutput Key: SOLR-5134 URL: https://issues.apache.org/jira/browse/SOLR-5134 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-5134) Have HdfsIndexOutput extend BufferedIndexOutput

[ https://issues.apache.org/jira/browse/SOLR-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-5134: -- Attachment: SOLR-5134.patch Have HdfsIndexOutput extend BufferedIndexOutput

[jira] [Updated] (LUCENE-5164) Remove the OOM cactching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: LUCENE-5164.patch Fix wrong visibility of flushBuffer method in FSIndexOutput

[jira] [Commented] (SOLR-5134) Have HdfsIndexOutput extend BufferedIndexOutput

[ https://issues.apache.org/jira/browse/SOLR-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736014#comment-13736014 ] Uwe Schindler commented on SOLR-5134: - Hi Mark, I think for saefty the close() method

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Summary: Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory (was: Remove the

[jira] [Updated] (LUCENE-5152) Lucene FST is not immutable

[ https://issues.apache.org/jira/browse/LUCENE-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-5152: --- Attachment: LUCENE-5152.patch This is what I have in mind ... just moving the

[jira] [Assigned] (LUCENE-4583) StraightBytesDocValuesField fails if bytes 32k

[ https://issues.apache.org/jira/browse/LUCENE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-4583: -- Assignee: Michael McCandless StraightBytesDocValuesField fails if bytes

[jira] [Updated] (LUCENE-4583) StraightBytesDocValuesField fails if bytes 32k

[ https://issues.apache.org/jira/browse/LUCENE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-4583: --- Attachment: LUCENE-4583.patch New patch. Thanks for the review Shai; I removed

[jira] [Commented] (LUCENE-4906) PostingsHighlighter's PassageFormatter should allow for rendering to arbitrary objects

[ https://issues.apache.org/jira/browse/LUCENE-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736021#comment-13736021 ] Michael McCandless commented on LUCENE-4906: Thanks Luca, that patch is nice.

[jira] [Commented] (SOLR-3076) Solr(Cloud) should support block joins

[ https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736024#comment-13736024 ] Mikhail Khludnev commented on SOLR-3076: [~yo...@apache.org] could you please

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: LUCENE-5164.patch Hide the extra FSIndexOutput constructor again, as it is only

[jira] [Commented] (SOLR-3191) field exclusion from fl

[ https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736056#comment-13736056 ] Bill Bell commented on SOLR-3191: - This is a very useful feature I have 80 fields and

[jira] [Commented] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736178#comment-13736178 ] Uwe Schindler commented on LUCENE-5164: --- This is already a fixed buffer in base

[jira] [Resolved] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-5164. --- Resolution: Won't Fix Fix Version/s: (was: 4.5) (was: 5.0)

[jira] [Reopened] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened LUCENE-5164: --- Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: LUCENE-5164.patch New patch: - Remves the chunking in FSIndexOutput - Lower

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: (was: LUCENE-5164.patch) Remove the OOM catching in SimpleFSDirectory

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: (was: LUCENE-5164.patch) Remove the OOM catching in SimpleFSDirectory

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: (was: LUCENE-5164.patch) Remove the OOM catching in SimpleFSDirectory

[jira] [Updated] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-5164: -- Attachment: (was: LUCENE-5164.patch) Remove the OOM catching in SimpleFSDirectory

[jira] [Commented] (LUCENE-5164) Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736185#comment-13736185 ] Uwe Schindler commented on LUCENE-5164: --- In my opinion, the chunking should be done