[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-09-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922251#comment-16922251 ] ASF subversion and git services commented on LUCENE-8150: - Commi

[GitHub] [lucene-solr] jpountz merged pull request #765: LUCENE-8150: Remove references to `segments.gen`.

2019-09-04 Thread GitBox
jpountz merged pull request #765: LUCENE-8150: Remove references to `segments.gen`. URL: https://github.com/apache/lucene-solr/pull/765 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene-solr] jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments

2019-09-04 Thread GitBox
jpountz commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-527786074 > what is the expected behaviour when start > size? Should we error out, or return a null topdocs (as we do today), or normal

[GitHub] [lucene-solr] jpountz commented on issue #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values

2019-09-04 Thread GitBox
jpountz commented on issue #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values URL: https://github.com/apache/lucene-solr/pull/831#issuecomment-527784806 I can imagine it be useful, but on the other hand this increases the API surface area of comparators while we have b

[GitHub] [lucene-solr] jpountz commented on issue #775: LUCENE-8910: upgrade to icu 62.1 must be completed

2019-09-04 Thread GitBox
jpountz commented on issue #775: LUCENE-8910: upgrade to icu 62.1 must be completed URL: https://github.com/apache/lucene-solr/pull/775#issuecomment-527782071 @rmuir This looks good to me but would you mind having a second look? -

[GitHub] [lucene-solr] jpountz commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates

2019-09-04 Thread GitBox
jpountz commented on a change in pull request #797: LUCENE-8921: IndexSearcher.termStatistics requires docFreq totalTermFreq instead of TermStates URL: https://github.com/apache/lucene-solr/pull/797#discussion_r320612366 ## File path: lucene/core/src/java/org/apache/lucene/search/I

Policies Around Posting On Wiki

2019-09-04 Thread Atri Sharma
Hi Folks, Do we have a policy around sharing design details of a feature on the Wiki? I am working something which I would like design review on, as well document it for future reference. ./Atri - To unsubscribe, e-mail: dev-uns

[GitHub] [lucene-solr] atris commented on issue #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values

2019-09-04 Thread GitBox
atris commented on issue #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values URL: https://github.com/apache/lucene-solr/pull/831#issuecomment-527779942 > I appreciate how you are trying to break a large change into smaller changes, but for this one I'd like to see how y

[GitHub] [lucene-solr] jpountz commented on issue #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values

2019-09-04 Thread GitBox
jpountz commented on issue #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values URL: https://github.com/apache/lucene-solr/pull/831#issuecomment-527779182 I appreciate how you are trying to break a large change into smaller changes, but for this one I'd like to see how y

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

2019-09-04 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-527779102 Removed JavaDoc reference to EmbeddedSolrServer as suggested by @dsmiley This is an automat

<    1   2