Re: Commit / Code Review Policy

2019-11-30 Thread Shawn Heisey
On 11/30/2019 7:39 AM, Robert Muir wrote: -1 ... you even went so far as to discourage lucene committers from attending that meeting, and now its turned around as if its consensus everywhere and should be applied to lucene too? I don't think changing things to review-then-commit will help.

Re: the bugs on solr8.3.0

2019-11-30 Thread Shawn Heisey
On 11/29/2019 11:47 PM, 曾云华 wrote: I found a lot of 404 bug as below: FIX THEM:  1 add "index.html" in webapps/solr/js/angular/controllers/cloud.js at line 961 as below 2 add "index.html" in webapps/solr/partials/cloud.html at line 174 and 220 as below Usually, you can't change things and

Re: Commit / Code Review Policy

2019-11-30 Thread Robert Muir
On Tue, Nov 26, 2019 at 12:34 AM David Smiley wrote: > Last Wednesday at a Solr committers meeting, there was general agreement... > > I'd prefer we have one "Commit Policy" document for Lucene/Solr and only > call out Solr specifics when applicable. This is easier to maintain and is > in line

the bugs on solr8.3.0

2019-11-30 Thread ??????
I found a lot of 404 bug as below: FIX THEM: 1 add "index.html" inwebapps/solr/js/angular/controllers/cloud.js at line 961 as below 2 add "index.html" inwebapps/solr/partials/cloud.htmlat line 174 and 220 as below :) wish you have a nice day! :)