Re: Reminder: Sync PRs with JIRA

2020-02-14 Thread Erick Erickson
Thanks, closed mine... > On Feb 14, 2020, at 6:28 PM, Jan Høydahl wrote: > > I made a report with dev-tools/scripts/githubPRs.py which shows «orphan» PRs > and PRs that have not been closed even if the linked JIRA is closed. > Please help close the gap. > You can typically link a PR with a JIRA

Reminder: Sync PRs with JIRA

2020-02-14 Thread Jan Høydahl
I made a report with dev-tools/scripts/githubPRs.py which shows «orphan» PRs and PRs that have not been closed even if the linked JIRA is closed. Please help close the gap. You can typically link a PR with a JIRA just by editing the PR title and also mentioning the JIRA ID as a comment on the PR.

Re: thread leak control whitelisting

2020-02-14 Thread Robert Muir
if you want to startup crypto threads on my machine, at least name them 'minerd' like the other hackers do. On Fri, Feb 14, 2020 at 11:24 AM Dawid Weiss wrote: > This is very likely just a parallel stream on a default fork/join > executor. Not much you can do here (and not much to fix). > > D. >

Re: 7.7.3 bugfix release

2020-02-14 Thread Jan Høydahl
Falde alarm, I needed to update my branch :) Jan Høydahl > 14. feb. 2020 kl. 19:11 skrev Jan Høydahl : > > What commit hash is the backport of SOLR-13971? I cannot find it and there > is no CHANGES entry…? > >> 14. feb. 2020 kl. 17:52 skrev Ishan Chattopadhyaya >> : >> >> +1, Houston. That'

Re: 7.7.3 bugfix release

2020-02-14 Thread Jan Høydahl
What commit hash is the backport of SOLR-13971? I cannot find it and there is no CHANGES entry…? > 14. feb. 2020 kl. 17:52 skrev Ishan Chattopadhyaya > : > > +1, Houston. That's my understanding as well. Please go ahead with the > backport. > > On Fri, 14 Feb, 2020, 9:02 PM Houston Putman, <

Re: 7.7.3 bugfix release

2020-02-14 Thread Ishan Chattopadhyaya
+1, Houston. That's my understanding as well. Please go ahead with the backport. On Fri, 14 Feb, 2020, 9:02 PM Houston Putman, wrote: > It looks like CVE-2019-17558 / SOLR-13971 has already been taken care of: > https://issues.apache.org/jira/browse/SOLR-13971?focusedCommentId=17014356&page=com.

Re: thread leak control whitelisting

2020-02-14 Thread Dawid Weiss
This is very likely just a parallel stream on a default fork/join executor. Not much you can do here (and not much to fix). D. On Fri, Feb 14, 2020 at 5:17 PM Michael Sokolov wrote: > > > Can you open an issue or PR with the list of thread names so that tests > > work on this JDK out-of-box in

Re: thread leak control whitelisting

2020-02-14 Thread Michael Sokolov
> Can you open an issue or PR with the list of thread names so that tests work > on this JDK out-of-box in the future? It's kind of messy since one of the dangling threads is very general-purpose, namely java.util.concurrent.ForkJoinWorkerThread. I am pursuing w/Corretto here https://github.com/c

Re: thread leak control whitelisting

2020-02-14 Thread Dawid Weiss
FYI; I noticed custom thread filters are used inconsistently throughout the codebase (Solr). It'd be nice to clean it up too. D. On Fri, Feb 14, 2020 at 4:33 PM Michael Sokolov wrote: > > Oh, I found ThreadLeakFilter annotation, and QuickPatchThreadsFilter - > I think I can use this, thanks! > >

Re: thread leak control whitelisting

2020-02-14 Thread Robert Muir
On Fri, Feb 14, 2020 at 10:33 AM Michael Sokolov wrote: > Oh, I found ThreadLeakFilter annotation, and QuickPatchThreadsFilter - > I think I can use this, thanks! > > Can you open an issue or PR with the list of thread names so that tests work on this JDK out-of-box in the future?

Re: thread leak control whitelisting

2020-02-14 Thread Michael Sokolov
Oh, I found ThreadLeakFilter annotation, and QuickPatchThreadsFilter - I think I can use this, thanks! On Fri, Feb 14, 2020 at 10:25 AM Michael Sokolov wrote: > > Hi, I wonder if we have a mechanism to extend the list of system > threads recognized by randomizedtesting (see > https://github.com/r

Re: 7.7.3 bugfix release

2020-02-14 Thread Houston Putman
It looks like CVE-2019-17558 / SOLR-13971 has already been taken care of: https://issues.apache.org/jira/browse/SOLR-13971?focusedCommentId=17014356&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17014356 So now CVE-2019-0193 / SOLR-13669 should be the only blocker

thread leak control whitelisting

2020-02-14 Thread Michael Sokolov
Hi, I wonder if we have a mechanism to extend the list of system threads recognized by randomizedtesting (see https://github.com/randomizedtesting/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/ThreadLeakControl.java#L281), beyond editing the source

Re: Info on document number limitations

2020-02-14 Thread Adrien Grand
Lucene has a limit of 2^31-1-128 documents per index, see IndexWriter.MAX_DOCS. Users don't often run into this limit but I've seen it happen multiple times. I think that it's unlikely that Lucene will ever remove this limit on a per-segment basis, however there have been some discussions about ha