Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

I agree Uwe. The scope of SIP-6 can be to let SolrBootstrap load existing web.xml through WebappContext, and spin off a new JIRA for the ServletContextHandler approach. See the updated SIP-6 text which reflects this. Jan > 25. mar. 2020 kl. 18:50 skrev Uwe Schindler : > > We could use >

RE: [DISCUSS] SIP-6 Solr should own the bootstrap process

We could use to allow to override our config with a custom user-specified web.xml. public void addOverrideDescriptor​(java.lang.String overrideDescripto

RE: [DISCUSS] SIP-6 Solr should own the bootstrap process

Hi, I agree, this should be a change in 9.0 only. In general we can start with web.xml still existing (the bootstrap code would use a Jetty “WebAppContext” initially). At a later stage we can replace the WebappContext by a ServletContextHandler (which is the superclass and offers no weba

RE: [DISCUSS] SIP-6 Solr should own the bootstrap process

Hi, I think Solr should ship with default CORS Filter enabled (it’s part of Jetty). E.g. Elasticsearch also ships with a suitable CORS configuration by default. You can just change some details (e.g. restrict hostnames, default is “*”) or dis/enable it completely. We can also be much more se

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

I think we like to pretend that Jetty and web.xml are implementation details, but I'm not sure how good of a job we do. Whether we need to provide backwards compatibility or not is the wrong question I think, because when we break compatibility we are telling a subset of our users that it will not

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

Would being able to manage CORS settings be part of this? Now that Solr is ramping up it’s default security posture, there are many applications that used to work that don’t. Today, changing Solr’s CORS settings is very cumbersome, requiring changing an embedded web.xml. Making it easier to

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

I agree. I changed the SIP page and now have four bullet points defined as in scope for the SIP: > The most important change in this SIP will be > Create a solr/bootstrap module with a solr.jar to replace start.jar as the > entrypoint (java -jar solr.jar ...) > Hide jetty even more, i.e. renam

Re: [DISCUSS] SIP-6 Solr should own the bootstrap process

I'm in favor of this approach mainly because of the line mentioned in the Test Plan: > If we move servlet initialization into Java code and get rid of web.xml, we may be able to start Solr in the same way both in tests and in real life! I feel that this should be a top level goal, along with taki