Re: [Lucene] Add javadoc for Lucene86PointsFormat class

2020-12-23 Thread LuXugang
Thanks David My userId is luxugang > On Dec 23, 2020, at 21:31, David Smiley wrote: > > Please register at the ASF's Confluence / wiki space. Then tell me your > userId, and I will then grant you permissions to edit our wiki. > ~ David Smiley > Apache Lucene/Solr Search Developer > http://

Re: Code reformatting

2020-12-23 Thread Michael Sokolov
Personally I would ban the non block conditional, but I think it's moot in this context since spotless just does what it does and is not configurable, as I understand it. I suppose we could manually "fix" all the conditionals though? On Wed, Dec 23, 2020, 9:07 AM Erick Erickson wrote: > I took a

Re: javac reports broken HTML on multiline mailto links

2020-12-23 Thread Michael Sokolov
Ugh the mailto: breaks it? Seems like a bug to me. Maybe the javadoc parser tries to validate the content of an href attribute? On Wed, Dec 23, 2020, 5:39 AM Dawid Weiss wrote: > Hello and Merry Christmas, > > I discovered this odd javac behavior with jdk8 up to jdk15 (didn't > check the latest

Re: Question by solr queries optimization

2020-12-23 Thread Adrien Grand
Hi Alex, Indeed Solr would automatically rewrite this query to `id:%key^3` since versions 7.1 / 8.0. This happens via BooleanQuery#rewrite, you can check out the JIRA where this was implemented: https://issues.apache.org/jira/browse/LUCENE-7925. On Wed, Dec 23, 2020 at 3:13 PM Alex Bulygin wrot

Re: Code reformatting

2020-12-23 Thread Dawid Weiss
> The formatter tightens up non-block comments, i.e. > > if (this == obj) > return true; > > becomes > > if (this == obj) return true; Yes, correct. > Which one is clearer is always a matter of debate, but my take is that braces > should be added when the _original_ code was on multiple lines,

Re: Deterministic index construction

2020-12-23 Thread David Smiley
I like Mike McCandless's suggestion of controlling which DWPT (and thus segment) an incoming document goes to. I've thought of this before for a different use case grouping documents into segments by the underlying "type" of the document. This could make sense for a use-case that queries by docum

Re: [DISCUSS] SIP-12: Incremental Backup and Restore

2020-12-23 Thread Jason Gerlowski
> We have a path alias to the old API ... but we don’t have a true v2 API spec > for it, do we? Tbh I'm not yet familiar enough with the v2 APIs to understand the distinction you're making. (Do you have a pointer to something that'd fill me in?) To zoom in on "backup" as an example, the v2 API

Re: [DISCUSS] SIP-12: Incremental Backup and Restore

2020-12-23 Thread Jan Høydahl
Actually, don’t think we do have a v2 Backup/Restore API. We have a path alias to the old API which takes GET ...&action=backup... but we don’t have a true v2 API spec for it, do we? Where is that documented? Jan Høydahl > 22. des. 2020 kl. 18:04 skrev Jason Gerlowski : > > Hey guys, > > Fol

Re: Code reformatting

2020-12-23 Thread Mike Drob
They both look fine to me, I’d likely go with the default so that there is less for us to maintain. On Wed, Dec 23, 2020 at 8:08 AM Erick Erickson wrote: > I took a quick look at lucene/queries just to get my feet wet. Before > working on it seriously. I did a fast scan through about half of the

Question by solr queries optimization

2020-12-23 Thread Alex Bulygin
Good day to all! Perhaps a stupid question, I'm not very experienced in using solr, please, tell me, if I send such a request to solr id: (% key or% key or% key) and the keys are equal, will there be any optimization of such a request ? Or tell me from the code where such an optimization can ta

Re: Code reformatting

2020-12-23 Thread r00t 4dm
I like this one, > if (this == obj) { > return true; > } Regards, r00t4dm Cloud-Penetrating Arrow Lab of Meituan Corp Information Security Department > 2020年12月23日 下午10:07,Erick Erickson 写道: > > I took a quick look at lucene/queries just to get my feet wet. Before working > on it seriously.

Code reformatting

2020-12-23 Thread Erick Erickson
I took a quick look at lucene/queries just to get my feet wet. Before working on it seriously. I did a fast scan through about half of the changes and have only one question. The formatter tightens up non-block comments, i.e. if (this == obj) return true; becomes if (this == obj) return tr

Re: [Lucene] Add javadoc for Lucene86PointsFormat class

2020-12-23 Thread David Smiley
Please register at the ASF's Confluence / wiki space. Then tell me your userId, and I will then grant you permissions to edit our wiki. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Dec 23, 2020 at 2:50 AM LuXugang wrote: > Hi, David > > Her

Re: Code reformatting

2020-12-23 Thread Dawid Weiss
I added some instructions on how to help out here: https://issues.apache.org/jira/browse/LUCENE-9570 spotless.gradle has a long list of projects that need to be reviewed. You can pick a small one and take it from there. Dawid On Wed, Dec 23, 2020 at 8:07 AM Dawid Weiss wrote: > > It is currentl

javac reports broken HTML on multiline mailto links

2020-12-23 Thread Dawid Weiss
Hello and Merry Christmas, I discovered this odd javac behavior with jdk8 up to jdk15 (didn't check the latest head). This source file (note the anchor tag over multiple lines): /** * Lucene internals or asking for help on mailto:java-u...@lucene.apache.org";>java-u...@lucene.apache.org */ pub