Re: Separate git repo(s) for Solr modules

2021-05-04 Thread Dawid Weiss
A submodule is nothing more than a checkout of a different repository (at a given commit). It's not a fork, unless you clone that repository and place it somewhere else. In any case, I agree Solr should stick to official Lucene releases. If there is a need to have a "sticky" intermediate tagged

Re: Separate git repo(s) for Solr modules

2021-05-04 Thread Atri Sharma
I am a bit confused -- if Lucene was to become a sub module of Solr, are we essentially forking Lucene? I am in agreement with Ilan and Houston -- Solr should be depending on Lucene only as a dependency. On Tue, 4 May 2021, 19:52 Noble Paul, wrote: > @Ilan Ginzburg > > I don't think the

Re: Separate git repo(s) for Solr modules

2021-05-04 Thread Noble Paul
@Ilan Ginzburg I don't think the project split is counter productive because we have lucene as a sub module. Solr does not use lucene like a simple library. It's an integral part of Solr On Tue, May 4, 2021 at 10:02 PM Ilan Ginzburg wrote: > As with any dependency on any project, you update

Re: Separate git repo(s) for Solr modules

2021-05-04 Thread Houston Putman
I completely agree with Ilan. Keeping the projects in the same repo was the only long term viable way of having Solr depend on a snapshot version of Lucene. And I'm sorry if I misspoke earlier. You can always "work on both at the same time" even when we rely on a release version of Lucene, but

Re: Separate git repo(s) for Solr modules

2021-05-04 Thread Ilan Ginzburg
As with any dependency on any project, you update the dependency project first then consume the updated dependency in Solr. If the idea is to be able to modify Lucene and Solr in parallel, then the project split is counterproductive. >From the Solr perspective, Lucene and Zookerper are really

Re: Separate git repo(s) for Solr modules

2021-05-04 Thread Noble Paul
@Houston So, Are you suggesting we should not do that ? On Tue, May 4, 2021 at 2:35 PM Houston Putman wrote: > In the future we wont be able to “work on both at the same time”, once > Lucene 9 is cut. Why not pull that bandaid now? > > On Mon, May 3, 2021 at 11:32 PM Noble Paul wrote: > >>