Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Julie Tibshirani
Thank you Uwe, that makes sense. Too bad I can't meet this Jenkins fellow, he seems very hardworking :) Julie On Tue, Mar 15, 2022 at 4:20 PM Uwe Schindler wrote: > Hi Julie, > > > > Thank you for respinning! > > > > About the GPG warnings: This is nothing critical. The warning message is a >

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
Hi Julie, Thank you for respinning! About the GPG warnings: This is nothing critical. The warning message is a bit misleading and comes from the following fact: * The smoke tester only imports the key file and verifies the signatures against that * The smoke tester does not

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Julie Tibshirani
Thank you everyone who tested so far. As we discussed on the other thread, Dawid found that an important follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided it was worth cancelling this vote and respinning an RC2 with this fix. So this vote has failed. I will send out a

Re: [JENKINS] Lucene-9.1-MacOSX (64bit/jdk-11.0.13) - Build # 55 - Unstable!

2022-03-15 Thread Dawid Weiss
Hi Julie. Yeah... I feel the same way. Sorry about the extra work. Dawid On Tue, Mar 15, 2022 at 7:33 PM Julie Tibshirani wrote: > Hi Dawid, I did a little digging and this looks like a bug that could > affect users. I think since we are still early in the vote for RC1, we > should call it off

Re: [JENKINS] Lucene-9.1-MacOSX (64bit/jdk-11.0.13) - Build # 55 - Unstable!

2022-03-15 Thread Julie Tibshirani
Hi Dawid, I did a little digging and this looks like a bug that could affect users. I think since we are still early in the vote for RC1, we should call it off and spin RC2. I will backport your change to branch_9_1. Julie On Mon, Mar 14, 2022 at 11:39 PM Dawid Weiss wrote: > > This failure

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
Hi Julie, Thanks for starting the release process! Many thanks for the work of fixing smoke tester. I was finally also able to run the smoke tester on my private Policeman Jenkins job to test the release (please note "-Ptests.multiplier=1" in command line):

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Nhat Nguyen
+1 SUCCESS! [1:44:48.902867] Thanks Julie for being the release manager. On Tue, Mar 15, 2022 at 10:32 AM Adrien Grand wrote: > +1 [1:15:46.282120] > > On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss wrote: > > > > > Could we change this propertyOrDefault() hack in Gradle to make -D > have higher

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Adrien Grand
+1 [1:15:46.282120] On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss wrote: > > > Could we change this propertyOrDefault() hack in Gradle to make -D have > > higher prio? > > Perhaps this wasn't explicit - yes, if you modify that method (and > propertyOrDefaultOrEnv) then you can control the

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
Hi Dawid, thanks for the feedback. As one step in between we should fix smoketester to pass properties to gradle using -P and not -D. That should be easy to do. Thanks, Uwe - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de From:

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Dawid Weiss
> Could we change this propertyOrDefault() hack in Gradle to make -D have > higher prio? Perhaps this wasn't explicit - yes, if you modify that method (and propertyOrDefaultOrEnv) then you can control the "priority" of these properties. On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss wrote: > > >

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Dawid Weiss
> @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio? Gradle doesn't recognize -D

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
See my other mail: You have to pass -P instead of -D as only this overrides the properties file ☹ Generally smoke tester should pass the extra flags using -P, not -D. - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de From: Jan

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
Hi, Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work to override! -P (project prop) takes precedence over -D (system prop) and the user’s values in gradle.properties are injected into build as project properties. We should also change smoketester.py to

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Robert Muir
On Tue, Mar 15, 2022 at 8:13 AM Uwe Schindler wrote: > > The “tests.multiplier=3” looks like the problem. I have no idea how to stop > this, because the gradle properties are injected through the config file. Is > there a way to pass custom parameters. Maybe we should add >

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Jan Høydahl
Ah, sure, makes sense. I'm trying to get smoketester to run in Jenkins for Solr as well, so struggling with some of the same issues there. Jan > 15. mar. 2022 kl. 13:41 skrev Uwe Schindler : > > That does not help for smoke tester  It has a hardcoded command line. > > I figured out how to

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
That does not help for smoke tester  It has a hardcoded command line. I figured out how to do it. You can passe xtra args at end of smoke tester command line. - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de From: Jan Høydahl

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
Hi, I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps: Now it starts tests like this: https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console run tests w/ Java 11

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Jan Høydahl
Click the "Advanced" button for the "Invoke Gradle script" task, and you get the chance to pass "Project properties" as well as "Switches" and "System properties". Jan > 15. mar. 2022 kl. 13:12 skrev Uwe Schindler : > > Hi, > > I have a problem with running Smoketester (like on every

RE: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Uwe Schindler
Hi, I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash). This worked for 9.0, but with 9.1 it hangs endless and does not finish:

Re: [VOTE] Release Lucene 9.1.0 RC1

2022-03-15 Thread Dawid Weiss
Automated smoke testing passed for me: SUCCESS! [1:32:35.061917] I think this commit should be applied to the release branch too, if there's a decision to respin. https://gitbox.apache.org/repos/asf?p=lucene.git;h=e999056 D. On Tue, Mar 15, 2022 at 1:57 AM Julie Tibshirani wrote: > Please

Re: [JENKINS] Lucene-9.1-MacOSX (64bit/jdk-11.0.13) - Build # 55 - Unstable!

2022-03-15 Thread Dawid Weiss
This failure has been fixed (by me) on main and branch_9x but didn't make it to the release. I can't tell whether this is potentially a problem in real life but perhaps it's not worth taking a chance? Dawid On Tue, Mar 15, 2022 at 1:49 AM Policeman Jenkins Server < jenk...@thetaphi.de> wrote: >