Re: MergeTrigger consistency in MergePolicy "find merges"

2022-06-20 Thread Adrien Grand
Some comments on JIRA suggest that this is expected, because natural merges can have a variety of triggers while forced merges are always called by the app. I guess you could argue that MERGE_FINISHED is a different trigger, but are there use-cases for doing things differently in findForcedMerges

Re: MergeTrigger consistency in MergePolicy "find merges"

2022-06-20 Thread Bruno Roustant
I agree this AlwaysForceMergePolicy is not working correctly. It's just a test I did to easily understand how MergeTrigger.MERGE_FINISHED was working. Anyway my question is only about the MergeTrigger not present in the call to findForcedMerges(), to know if it is expected or inconsistent with

Re: [RESULT] [VOTE] Migration to GitHub issue from Jira

2022-06-20 Thread Tomoko Uchida
Thanks for your suggestions; actually ASF should have information on the account mapping. For now, I'll just prepare scripts to embed the mapped github accounts next to the jira author/assignee name; we could ask infra or create the mapping on our own by inference if we find it's worthwhile to

Re: MergeTrigger consistency in MergePolicy "find merges"

2022-06-20 Thread Adrien Grand
Wouldn't this be a bug in the AlwaysForceMergePolicy, which should return no merges if there is already a single segment with no deletes? On Mon, Jun 20, 2022 at 1:30 PM Bruno Roustant wrote: > If I use a simple "AlwaysForceMergePolicy" in a test, I can see that when > a run

Re: [RESULT] [VOTE] Migration to GitHub issue from Jira

2022-06-20 Thread Michael Sokolov
I think the user mapping must be inferred based on membership in the Apache "organization" https://github.com/settings/organizations On Sun, Jun 19, 2022 at 2:45 AM Dawid Weiss wrote: > > >> User id mapping is an important consideration for me. > > > Some mapping has to be present somewhere

Re: MergeTrigger consistency in MergePolicy "find merges"

2022-06-20 Thread Bruno Roustant
If I use a simple "AlwaysForceMergePolicy" in a test, I can see that when a run IndexWriter.forceMerge(), the first call to AlwaysForceMergePolicy.findForcedMerges() is done for the MergeTrigger.EXPLICIT. But then, at IndexWriter.merge() line 4531, MergePolicy.findForcedMerges() is called with

Re: Plan for GitHub issue metadata management

2022-06-20 Thread Tomoko Uchida
I haven't used the "project" feature either - maybe it could be an option but I can't have an opinion on it. Is there anyone who has experience with it and wants to lead us to use it? Tomoko 2022年6月20日(月) 18:59 Jens Wille : > > Hi, > > I'm just a bystander here. But are you aware that the new

Re: Plan for GitHub issue metadata management

2022-06-20 Thread Jens Wille
Hi, I'm just a bystander here. But are you aware that the new projects (beta) includes support for custom fields? I haven't used them myself yet, but it seems that they might be a

Re: Plan for GitHub issue metadata management

2022-06-20 Thread Tomoko Uchida
Indeed versions are the most important metadata; I'd like to hear the thoughts of others. 1. Fix Version(s) We have only two options: Milestone or Label. One important difference between them is that an issue can have only one milestone but multiple labels. The other difference would be that

Re: Plan for GitHub issue metadata management

2022-06-20 Thread Shai Erera
Can we support "Affects Versions" with a label too? "affectsVersion: 8.x"? Regarding Fix Versions, don't we have multiple of these sometimes? E.g. a bug fix may go into "8.1", "9.x" and "main"? Is it OK if we just drop support for this? On Mon, Jun 20, 2022 at 12:33 PM Tomoko Uchida wrote: >

Plan for GitHub issue metadata management

2022-06-20 Thread Tomoko Uchida
Hello all. Besides whether the migration of existing issues should be done or not (we still do not reach an agreement on it), I started to play around with GitHub issue metadata with a test repository. The current migration plan in my mind: * Issue Type -> Supported with labels (e.g.

Re: MergeTrigger consistency in MergePolicy "find merges"

2022-06-20 Thread Adrien Grand
You seem to imply that `forceMerge` runs a cascaded merge where the first merge creates some new segments that become inputs to a second merge. Have you considered running a single merge? We had a discussion about cascaded forced merges and TieredMergePolicy last year and ended up changing

MergeTrigger consistency in MergePolicy "find merges"

2022-06-20 Thread Bruno Roustant
MergePolicy "find merges" methods take a MergeTrigger as parameter, except findForcedMerges() and findForcedDeletesMerges(). In my use-case, I could leverage a MergeTrigger in findForcedMerges(), which can be EXPLICIT or MERGE_FINISHED, to differentiate the merge selection between the initial