[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844183#comment-16844183 ] Adrien Grand commented on LUCENE-8805: -- The patch looks good in general. In SolrDocumentFetcher

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844029#comment-16844029 ] Adrien Grand commented on LUCENE-8791: -- bq. Yes, We run CPU intensive ML models to rescore hits

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844013#comment-16844013 ] Adrien Grand commented on LUCENE-8757: -- I think we could add an assertion

[jira] [Commented] (LUCENE-8770) BlockMaxConjunctionScorer should support two-phase scorers

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844001#comment-16844001 ] Adrien Grand commented on LUCENE-8770: -- This is great. I wonder how useful computing the score

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843979#comment-16843979 ] Adrien Grand commented on LUCENE-8804: -- This makes sense to me. [~mikemccand] Any objections

[jira] [Commented] (LUCENE-8689) Boolean DocValues Codec Implementation

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843945#comment-16843945 ] Adrien Grand commented on LUCENE-8689: -- [~Dmitry Popov] Since your codec only iterates on ones

[jira] [Commented] (LUCENE-8805) Parameter changes for binaryField() and stringField() in StoredFieldVisitor

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843931#comment-16843931 ] Adrien Grand commented on LUCENE-8805: -- I like how passing a String to stringField makes the API

[jira] [Commented] (LUCENE-4012) Make all query classes serializable, and provide a query parser to consume them

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843910#comment-16843910 ] Adrien Grand commented on LUCENE-4012: -- bq. My thought is that each query parser could potentially

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843876#comment-16843876 ] Adrien Grand commented on LUCENE-8757: -- [~atris] Your last patch sorts in reverse order of docBase

Re: Distinct terms within a document for new Similarity class

2019-05-20 Thread Adrien Grand
Hi Romaric, You are right, computeNorm is the right place to compute and record the number of unique terms of a document. Your computeNorm function would look something like this: @Override public final long computeNorm(FieldInvertState state) { return

[jira] [Commented] (LUCENE-8799) Add Force Commit Method to RandomIndexWriter

2019-05-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840620#comment-16840620 ] Adrien Grand commented on LUCENE-8799: -- [~atris] I don't have a checkout of the code locally so

[jira] [Commented] (LUCENE-8799) Add Force Commit Method to RandomIndexWriter

2019-05-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839913#comment-16839913 ] Adrien Grand commented on LUCENE-8799: -- What does it do differently than RandomIndexWriter#commit

Re: Welcome Michael Sokolov as Lucene/ Solr committer

2019-05-14 Thread Adrien Grand
Welcome Mike! Le lun. 13 mai 2019 à 15:12, Dawid Weiss a écrit : > Hello everyone, > > Please join me in welcoming Michael Sokolov as Lucene/ Solr committer! > > Many of you probably know Mike as he's been around for quite a while > -- answering questions, reviewing patches, providing insight

[jira] [Commented] (LUCENE-7697) IndexSearcher should leverage index sorting

2019-05-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838371#comment-16838371 ] Adrien Grand commented on LUCENE-7697: -- I am not, but [~jtibshirani] recently mentioned to me

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838363#comment-16838363 ] Adrien Grand commented on LUCENE-8757: -- Yes. Top-docs collectors are expected to tie-break by doc

[jira] [Resolved] (LUCENE-7697) IndexSearcher should leverage index sorting

2019-05-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-7697. -- Resolution: Duplicate Oops, actually I've done what I had in mind in LUCENE-8059, I had

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

2019-05-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838136#comment-16838136 ] Adrien Grand commented on LUCENE-8791: -- I like the idea of a collector-based rescorer so that you

[jira] [Commented] (LUCENE-8795) ArrayIndexOutOfBoundsException during System.arraycopy in BKDWriter

2019-05-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838132#comment-16838132 ] Adrien Grand commented on LUCENE-8795: -- TestBKD (https://github.com/apache/lucene-solr/blob/master

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-05-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838131#comment-16838131 ] Adrien Grand commented on LUCENE-8757: -- I think we need to sort by docBase before constructing

Re: [VOTE] Release Lucene/Solr 8.1.0 RC2

2019-05-10 Thread Adrien Grand
+1 SUCCESS! [1:42:06.213620] Javadocs and the changelog look good too. On Fri, May 10, 2019 at 3:56 PM Michael McCandless wrote: > > +1 > > SUCCESS! [0:50:14.775863] > > > Mike McCandless > > http://blog.mikemccandless.com > > > On Thu, May 9, 2019 at 11:37 AM Ishan Chattopadhyaya > wrote: >>

Re: significant lucene benchmark regression: JDK11?

2019-05-10 Thread Adrien Grand
The Russia polygon seems to be something else? It slowed down on April 12th and then a bit more on April 20th while you only switched to OpenJDK11 on April 23th? However some other slowdowns seem to happen at the same time as the switch to OpenJDK 11 and haven't been addressed by the change of

[jira] [Resolved] (LUCENE-8795) ArrayIndexOutOfBoundsException during System.arraycopy in BKDWriter

2019-05-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8795. -- Resolution: Won't Fix Closing since this looks like a JVM bug

[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch

2019-05-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834714#comment-16834714 ] Adrien Grand commented on LUCENE-7840: -- +1 > BooleanQuery.rewriteNoScoring - optimize away

[jira] [Commented] (LUCENE-8795) ArrayIndexOutOfBoundsException during System.arraycopy in BKDWriter

2019-05-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834709#comment-16834709 ] Adrien Grand commented on LUCENE-8795: -- I just did a quick review, here is the code

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2019-04-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827026#comment-16827026 ] Adrien Grand commented on LUCENE-8776: -- I am sorry that this change broke your use-case

[jira] [Created] (LUCENE-8779) MinHashFilter generates invalid terms

2019-04-26 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8779: Summary: MinHashFilter generates invalid terms Key: LUCENE-8779 URL: https://issues.apache.org/jira/browse/LUCENE-8779 Project: Lucene - Core Issue Type

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2019-04-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824974#comment-16824974 ] Adrien Grand commented on LUCENE-8776: -- I'd rather keep this check for the reasons Robert mentioned

[jira] [Commented] (LUCENE-8768) Javadoc search support

2019-04-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821800#comment-16821800 ] Adrien Grand commented on LUCENE-8768: -- [~thetaphi] Any thoughts about this? > Javadoc sea

[jira] [Resolved] (LUCENE-8154) TODO List when upgrading to Java 9 as minimum requirement

2019-04-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8154. -- Resolution: Implemented [~erickerickson] Indeed, this is superseded by LUCENE-8738. > T

Re: [JENKINS] Lucene-Solr-Tests-8.x - Build # 144 - Unstable

2019-04-18 Thread Adrien Grand
I pushed a fix. We were randomly adding term vectors while the test later asserted that term vectors were disabled. On Wed, Apr 17, 2019 at 3:34 AM Apache Jenkins Server wrote: > > Build: https://builds.apache.org/job/Lucene-Solr-Tests-8.x/144/ > > 1 tests failed. > FAILED: >

Re: Lucene/Solr 8.1

2019-04-17 Thread Adrien Grand
+1 to do a 8.1 soon too, thanks Ishan for volunteering! I'm expecting you'd build a RC soon after cutting the branch? On Wed, Apr 17, 2019 at 10:08 AM Ishan Chattopadhyaya wrote: > > +1 for a 8.1 soon. I can volunteer for RM. > Does 30 April (about 2 weeks from now) sound reasonable for a branch

[jira] [Commented] (LUCENE-8765) OneDimensionBKDWriter valueCount validation didn't include leafCount

2019-04-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820188#comment-16820188 ] Adrien Grand commented on LUCENE-8765: -- Good catch! This patch seems to have been created off

[jira] [Commented] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

2019-04-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819305#comment-16819305 ] Adrien Grand commented on LUCENE-8759: -- Maybe the test could explicitly test both normal

[jira] [Commented] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

2019-04-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819154#comment-16819154 ] Adrien Grand commented on LUCENE-8759: -- I gave a try at simplifying this a bit and have

[jira] [Commented] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

2019-04-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818980#comment-16818980 ] Adrien Grand commented on LUCENE-8759: -- I'm wondering whether the logic could be simplified

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818207#comment-16818207 ] Adrien Grand commented on LUCENE-8738: -- +1 on the suggested short-term workaround > Bump mini

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817665#comment-16817665 ] Adrien Grand commented on LUCENE-8738: -- Feel free to send it, +1 for tomorrow CEST. > Bump mini

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817616#comment-16817616 ] Adrien Grand commented on LUCENE-8738: -- Thanks Uwe. Sorry for the late reply, +1 to send an email

Re: Protect old branches that are not getting new releases?

2019-04-15 Thread Adrien Grand
houldn’t modify from writes is a +1. >> >> I’m -1 for removing branches. >> >> Erick >> >> P.S. And I do note that you carefully did _not_ include 6_6 or 7_7 so we can >> still do the point releases. >> >> >> > On Apr 5, 2019, at 7:47 A

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816072#comment-16816072 ] Adrien Grand commented on LUCENE-8738: -- Agreed it would be simpler to just call queueCoreClose

[jira] [Commented] (LUCENE-8725) Make TermsQuery.SeekingTermSetTermsEnum public

2019-04-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815143#comment-16815143 ] Adrien Grand commented on LUCENE-8725: -- +1 to the patch, let's maybe make it internal rather than

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814823#comment-16814823 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] I tested Eclipse indeed. I only had issue

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814577#comment-16814577 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] Do you know what still needs to be done before

[jira] [Created] (LUCENE-8762) Lucene50PostingsReader should specialize reading docs+freqs with impacts

2019-04-10 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8762: Summary: Lucene50PostingsReader should specialize reading docs+freqs with impacts Key: LUCENE-8762 URL: https://issues.apache.org/jira/browse/LUCENE-8762 Project

[jira] [Created] (LUCENE-8760) Reconsider the best way to encode postings now that we can skip non-competitive hits

2019-04-10 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8760: Summary: Reconsider the best way to encode postings now that we can skip non-competitive hits Key: LUCENE-8760 URL: https://issues.apache.org/jira/browse/LUCENE-8760

[jira] [Created] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

2019-04-10 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8759: Summary: BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance Key: LUCENE-8759 URL: https://issues.apache.org/jira/browse/LUCENE-8759

[jira] [Resolved] (LUCENE-8619) Decrease I/O pressure of OfflineSorter

2019-04-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8619. -- Resolution: Not A Problem This isn't a problem anymore now that Ignacio rewrote the merging

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813565#comment-16813565 ] Adrien Grand commented on LUCENE-8738: -- Sorry Uwe, I don't understand what you are suggesting

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813445#comment-16813445 ] Adrien Grand commented on LUCENE-8738: -- Apparently the issue can be worked around by calling

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813346#comment-16813346 ] Adrien Grand commented on LUCENE-8738: -- There seems to be issues with links to the standard API. I

[jira] [Commented] (LUCENE-7386) Flatten nested disjunctions

2019-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813211#comment-16813211 ] Adrien Grand commented on LUCENE-7386: -- For the record I had to disable the verification of scores

[jira] [Commented] (LUCENE-8708) Can we simplify conjunctions of range queries automatically?

2019-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813199#comment-16813199 ] Adrien Grand commented on LUCENE-8708: -- Thanks Atri for giving it a try! This change is a bit too

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

2019-04-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813164#comment-16813164 ] Adrien Grand commented on LUCENE-8753: -- bq. BlockTree and UniformSplit had the same QPS for Term

Re: Welcome Tomoko Uchida as Lucene/Solr committer

2019-04-08 Thread Adrien Grand
Congratulations, Tomoko! Welcome! On Mon, Apr 8, 2019 at 5:20 PM Uwe Schindler wrote: > > Hi all, > > Please join me in welcoming Tomoko Uchida as the latest Lucene/Solr committer! > > She has been working on https://issues.apache.org/jira/browse/LUCENE-2562 for > several years with awesome

[jira] [Commented] (LUCENE-8747) Allow access to Weight and submatches from Matches instances

2019-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811015#comment-16811015 ] Adrien Grand commented on LUCENE-8747: -- Is getWeight really needed or could you pull an iterator

[jira] [Commented] (LUCENE-8749) Proposal: Pluggable Interface for Slice Allocation Algorithm

2019-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810987#comment-16810987 ] Adrien Grand commented on LUCENE-8749: -- I'm wondering whether customizing slices would actually

[jira] [Commented] (LUCENE-8751) Weight#matches should use the scorerSupplier to create scorers

2019-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810980#comment-16810980 ] Adrien Grand commented on LUCENE-8751: -- +1 > Weight#matches should use the scorerSuppl

Re: Protect old branches that are not getting new releases?

2019-04-05 Thread Adrien Grand
Removing branches proved a bit controversial in the past, see https://markmail.org/message/6ah3m6zd6v3ik3ie for instance. On Fri, Apr 5, 2019 at 3:24 PM Shawn Heisey wrote: > > On 4/5/2019 3:19 AM, Adrien Grand wrote: > > Apparently it is possible to ask INFRA to mark branches as >

[jira] [Commented] (LUCENE-8701) Speed up ToParentBlockJoinQuery when total hit count is not needed

2019-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810659#comment-16810659 ] Adrien Grand commented on LUCENE-8701: -- +1 it looks good. Maybe we should call searcher#rewrite

Protect old branches that are not getting new releases?

2019-04-05 Thread Adrien Grand
Hello, Apparently it is possible to ask INFRA to mark branches as protected[1]. Should we do it for branches that are not expecting new releases anymore? I think it would make things less trappy. For instance, backporting to branch_7x is almost for sure a mistake since we are not going to release

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

2019-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810629#comment-16810629 ] Adrien Grand commented on LUCENE-8688: -- I backported to branch_7_7 as well in case we do a new

[jira] [Updated] (LUCENE-8688) Forced merges merge more than necessary

2019-04-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8688: - Fix Version/s: 7.7.2 > Forced merges merge more than necess

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

2019-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808813#comment-16808813 ] Adrien Grand commented on LUCENE-8753: -- I haven't read the pdf or the patch yet. The LowTerm

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808610#comment-16808610 ] Adrien Grand commented on LUCENE-8738: -- +1 The other part that needs reviews is the replacement

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808503#comment-16808503 ] Adrien Grand commented on LUCENE-8738: -- +1 to disable jtidy for now > Bump minimum Java vers

Re: [JENKINS] Lucene-Solr-SmokeRelease-master - Build # 1297 - Still Failing

2019-04-03 Thread Adrien Grand
release > todo guide, and generate them as soon as the artifacts are published? > https://wiki.apache.org/lucene-java/ReleaseTodo#Generate_Backcompat_Indexes > Regards, > Ishan > > > On Wed, Apr 3, 2019 at 12:28 PM Adrien Grand wrote: >> >> Ishan, have you seen

Re: [JENKINS] Lucene-Solr-SmokeRelease-master - Build # 1297 - Still Failing

2019-04-03 Thread Adrien Grand
Ishan, have you seen these build failures? On Wed, Apr 3, 2019 at 7:27 AM Apache Jenkins Server wrote: > > Build: https://builds.apache.org/job/Lucene-Solr-SmokeRelease-master/1297/ > > No tests ran. > > Build Log: > [...truncated 23436 lines...] > [asciidoctor:convert] asciidoctor: ERROR:

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808415#comment-16808415 ] Adrien Grand commented on LUCENE-8738: -- Currently the build prevents tidy from running if the Java

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-04-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807848#comment-16807848 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] I'm curious if you have an idea how to make

Re: Stop testing with Java 9 or 10?

2019-03-28 Thread Adrien Grand
In my opinion, we should test all versions between the minimum required version and the greatest version at the time of a release. So my preference would be to keep testing on Java 8 and 9, possibly less frequently. On Thu, Mar 28, 2019 at 7:51 PM Erick Erickson wrote: > > What do people think

[jira] [Commented] (LUCENE-8732) Allow ConstantScoreQuery to skip counting hits

2019-03-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804163#comment-16804163 ] Adrien Grand commented on LUCENE-8732: -- If someone has time to look, I think we have a similar

Re: We have a cause for high CPU usage on Solr 7.7

2019-03-26 Thread Adrien Grand
+1 to raise a JIRA. There is an easy workaround on the user side by using a recent JVM, but at the same time the change to the code looks safe. Does it affect 6.6? I see there is an ongoing thread about getting 6.6.6 out. On Mon, Mar 25, 2019 at 5:05 PM Erick Erickson wrote: > > From the user’s

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2019-03-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801064#comment-16801064 ] Adrien Grand commented on LUCENE-8739: -- Zstd looks great indeed. We'd need a pure Java impl if we

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-03-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801036#comment-16801036 ] Adrien Grand commented on LUCENE-8738: -- You argued to keep this code around in the vote thread

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-03-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800943#comment-16800943 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] Feel free to heavy commit, I don't plan

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

2019-03-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800921#comment-16800921 ] Adrien Grand commented on LUCENE-8738: -- Hi Uwe, thanks for this checklist. I have started looking

Re: [VOTE] Master/9.0 to require Java 11

2019-03-25 Thread Adrien Grand
release being a ways off; >> this makes the decision pretty easy. >> >> ~ David Smiley >> Apache Lucene/Solr Search Developer >> http://www.linkedin.com/in/davidwsmiley >> >> >> On Tue, Mar 19, 2019 at 2:23 PM Adrien Grand wrote: >>> >>

[jira] [Created] (LUCENE-8738) Bump minimum version requirement to 11

2019-03-25 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8738: Summary: Bump minimum version requirement to 11 Key: LUCENE-8738 URL: https://issues.apache.org/jira/browse/LUCENE-8738 Project: Lucene - Core Issue Type

[jira] [Resolved] (LUCENE-8737) Simon poortman

2019-03-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8737. -- Resolution: Invalid Fix Version/s: (was: Positions Branch) I'm assuming

[jira] [Commented] (LUCENE-8732) Allow ConstantScoreQuery to skip counting hits

2019-03-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798867#comment-16798867 ] Adrien Grand commented on LUCENE-8732: -- +1 to the approach. Should we keep returning the sub scorer

[jira] [Commented] (LUCENE-8733) retrospectively add @since javadocs for 'intervals' classes

2019-03-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798313#comment-16798313 ] Adrien Grand commented on LUCENE-8733: -- I have mixed feelings. I have never found the "@since

[jira] [Commented] (LUCENE-8733) retrospectively add @since javadocs for 'intervals' classes

2019-03-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798295#comment-16798295 ] Adrien Grand commented on LUCENE-8733: -- Most of the classes whose documentation is updated

Re: [VOTE] Master/9.0 to require Java 11

2019-03-20 Thread Adrien Grand
of the release then we should do it. Just because it makes things easier to reason about and to test. And then doing it early gives us time to see how we can use new Java features to make Lucene/Solr better. On Wed, Mar 20, 2019 at 1:49 AM Shawn Heisey wrote: > > On 3/19/2019 12:22 PM, Adrien Grand

[jira] [Commented] (LUCENE-8731) mark MultiTermAwareComponent as deprecated (7.x and 7.7 only)

2019-03-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796413#comment-16796413 ] Adrien Grand commented on LUCENE-8731: -- Let's use the "@Deprecated" annotation on

[VOTE] Master/9.0 to require Java 11

2019-03-19 Thread Adrien Grand
Hello, Now that Lucene/Solr 8.0 has shipped I'd like us to consider requiring Java 11 for 9.0, currently the master branch. We had 18 months between 7.0 and 8.0, so if we assume a similar interval between 8.0 and 9.0 that would mean releasing 9.0 about 2 years after Java 11, which sounds like a

[jira] [Created] (SOLR-13334) Expose FeatureField

2019-03-19 Thread Adrien Grand (JIRA)
Adrien Grand created SOLR-13334: --- Summary: Expose FeatureField Key: SOLR-13334 URL: https://issues.apache.org/jira/browse/SOLR-13334 Project: Solr Issue Type: Improvement Security Level

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2019-03-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796063#comment-16796063 ] Adrien Grand commented on SOLR-13289: - +1 to expose these optimizations. I like option 1 better too

8.0 jobs disabled on ASF Jenkins

2019-03-19 Thread Adrien Grand
FYI I disabled 8.0 jobs on ASF Jenkins except the one about the reference guide. -- Adrien - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7958) Give TermInSetQuery better advancing capabilities

2019-03-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795905#comment-16795905 ] Adrien Grand commented on LUCENE-7958: -- Thanks for sharing [~hermes]. I should resurrect the above

[jira] [Updated] (LUCENE-8150) Remove references to segments.gen.

2019-03-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8150: - Attachment: LUCENE-8150.patch > Remove references to segments.

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795886#comment-16795886 ] Adrien Grand commented on LUCENE-8150: -- Here is a new patch based on the above comments

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793604#comment-16793604 ] Adrien Grand commented on LUCENE-8150: -- I could work around it now that I know of this trap

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2019-03-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793597#comment-16793597 ] Adrien Grand commented on LUCENE-8150: -- Indeed! I think it's due to the fact that I'm always

[jira] [Resolved] (LUCENE-8688) Forced merges merge more than necessary

2019-03-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8688. -- Resolution: Fixed Fix Version/s: master (9.0) 8.1 Merged. Thanks

[jira] [Commented] (LUCENE-8725) Make TermsQuery public

2019-03-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793420#comment-16793420 ] Adrien Grand commented on LUCENE-8725: -- I think it was done this way to make sure that equals

Re: Lucene/Solr 8.0

2019-03-14 Thread Adrien Grand
lr Search Developer > http://www.linkedin.com/in/davidwsmiley > > > On Wed, Mar 13, 2019 at 10:02 AM Adrien Grand wrote: >> >> I organized existing items of the Lucene release notes into sections >> and added a new item about FeatureField, >> LongPoint#newDist

[jira] [Created] (LUCENE-8727) IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor

2019-03-14 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8727: Summary: IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor Key: LUCENE-8727 URL: https://issues.apache.org/jira/browse

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

2019-03-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792497#comment-16792497 ] Adrien Grand commented on LUCENE-8688: -- bq. otherwise the case of merging from a single segments

[jira] [Commented] (LUCENE-8725) Make TermsQuery public

2019-03-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792478#comment-16792478 ] Adrien Grand commented on LUCENE-8725: -- Is my assumption correct that you are interested

Re: Lucene/Solr 8.0

2019-03-13 Thread Adrien Grand
te in 8.1 and remove in 9 without any problems. I > opened the issues to ensure that we didn’t keep carrying deprecated code > through any further releases. > > > On 7 Feb 2019, at 06:43, David Smiley wrote: > > I want to ensure people are aware of two issues "Remove deprec

<    3   4   5   6   7   8   9   10   11   12   >