[jira] [Updated] (LUCENE-8332) New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)

2018-06-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8332: - Attachment: LUCENE-8332.patch > New ConcatenateGraphTokenStream (move/rename

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498266#comment-16498266 ] David Smiley commented on LUCENE-8344: -- The patch fixes the issue and has a couple tests. It's a

[jira] [Updated] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8344: - Attachment: LUCENE-8344.patch > TokenStreamToAutomaton doesn't ignore trailing posInc when >

[jira] [Created] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-01 Thread David Smiley (JIRA)
David Smiley created LUCENE-8344: Summary: TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false Key: LUCENE-8344 URL: https://issues.apache.org/jira/browse/LUCENE-8344

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

2018-06-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498024#comment-16498024 ] David Smiley commented on LUCENE-8306: -- Sounds very promising.  I'm looking forward to seeing

[jira] [Commented] (SOLR-5211) updating parent as childless makes old children orphans

2018-05-31 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496790#comment-16496790 ] David Smiley commented on SOLR-5211: I propose that *if* the schema declares \_root_ then we consider

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496048#comment-16496048 ] David Smiley commented on SOLR-12361: - [~caomanhdat] can you please review the changes to

[jira] [Commented] (SOLR-12374) Add SolrCore.withSearcher(lambda accepting SolrIndexSearcher)

2018-05-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495280#comment-16495280 ] David Smiley commented on SOLR-12374: - woops; thanks! > Add SolrCore.withSearcher(lambda accepting

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494618#comment-16494618 ] David Smiley commented on SOLR-12338: - My intention with changing the loop is to reduce duplication

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494172#comment-16494172 ] David Smiley commented on SOLR-12338: - ah; I think I can see why we acquire the size semaphore after

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494162#comment-16494162 ] David Smiley commented on SOLR-12338: - Please consider this alternative utility class: {code:java}

[jira] [Created] (SOLR-12420) Propose removing schema version; use luceneMatchVersion instead

2018-05-29 Thread David Smiley (JIRA)
David Smiley created SOLR-12420: --- Summary: Propose removing schema version; use luceneMatchVersion instead Key: SOLR-12420 URL: https://issues.apache.org/jira/browse/SOLR-12420 Project: Solr

[jira] [Commented] (SOLR-7242) Schema API: Edit remaining schema elements: Name, Version, Unique Key, and Global Similarity

2018-05-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494072#comment-16494072 ] David Smiley commented on SOLR-7242: Good idea: SOLR-7242 > Schema API: Edit remaining schema

[jira] [Commented] (SOLR-7242) Schema API: Edit remaining schema elements: Name, Version, Unique Key, and Global Similarity

2018-05-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493720#comment-16493720 ] David Smiley commented on SOLR-7242: [~janhoy] what do you think about my proposal to deprecate the

[jira] [Commented] (LUCENE-8331) MergePolicy simulator utility

2018-05-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493480#comment-16493480 ] David Smiley commented on LUCENE-8331: -- bq. can it just be a utility class that I call from a test

[jira] [Commented] (LUCENE-8332) New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)

2018-05-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492904#comment-16492904 ] David Smiley commented on LUCENE-8332: -- Oh I wanted to mention one thing; perhaps just here though

[jira] [Commented] (LUCENE-8331) MergePolicy simulator utility

2018-05-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492919#comment-16492919 ] David Smiley commented on LUCENE-8331: -- Thanks for your input Simon. bq. I am not sure it needs

[jira] [Commented] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492897#comment-16492897 ] David Smiley commented on SOLR-12376: - Updated patch to use the new ConcatenateGraphFilterFactory

[jira] [Updated] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12376: Attachment: SOLR-12376.patch > New TaggerRequestHandler (aka SolrTextTagger) >

[jira] [Commented] (LUCENE-8332) New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)

2018-05-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491501#comment-16491501 ] David Smiley commented on LUCENE-8332: -- I had TestRandomChains go at it and it uncovered a couple

[jira] [Commented] (LUCENE-8332) New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)

2018-05-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491312#comment-16491312 ] David Smiley commented on LUCENE-8332: -- See GitHub PR.  comments welcome! * Made it a TokenFilter.

[jira] [Updated] (SOLR-12398) Make JSON Facet API support Heatmap Facet

2018-05-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12398: Component/s: spatial > Make JSON Facet API support Heatmap Facet >

[jira] [Assigned] (SOLR-12233) QParserPlugin maintains a list of classes recreated every time a Solrcore object is created

2018-05-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-12233: --- Assignee: David Smiley (was: Erick Erickson) > QParserPlugin maintains a list of classes

[jira] [Commented] (LUCENE-8332) New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490210#comment-16490210 ] David Smiley commented on LUCENE-8332: -- {quote}It's a TokenStream because it consumes the entire

[jira] [Created] (LUCENE-8332) New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)

2018-05-24 Thread David Smiley (JIRA)
David Smiley created LUCENE-8332: Summary: New ConcatenateGraphTokenStream (move/rename CompletionTokenStream) Key: LUCENE-8332 URL: https://issues.apache.org/jira/browse/LUCENE-8332 Project: Lucene

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489821#comment-16489821 ] David Smiley commented on SOLR-12386: - Interesting. I'm not sure how this would be an issue for the

[jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489729#comment-16489729 ] David Smiley commented on LUCENE-8330: -- BTW LUCENE-8331 shows how the MergePolicy can be tested or

[jira] [Commented] (LUCENE-8331) MergePolicy simulator utility

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489726#comment-16489726 ] David Smiley commented on LUCENE-8331: -- CC [~mikemccand] [~simonw] [~erickerickson] I used this

[jira] [Updated] (LUCENE-8331) MergePolicy simulator utility

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8331: - Attachment: LUCENE-8331.patch > MergePolicy simulator utility > - >

[jira] [Created] (LUCENE-8331) MergePolicy simulator utility

2018-05-24 Thread David Smiley (JIRA)
David Smiley created LUCENE-8331: Summary: MergePolicy simulator utility Key: LUCENE-8331 URL: https://issues.apache.org/jira/browse/LUCENE-8331 Project: Lucene - Core Issue Type: New

[jira] [Commented] (SOLR-12395) Typo in SignificantTermsQParserPlugin.NAME

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489634#comment-16489634 ] David Smiley commented on SOLR-12395: - +1 to the 7x back-compat old name > Typo in

[jira] [Commented] (LUCENE-8323) New ConcatenateFilter, a TokenFilter to concat/join tokens

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489618#comment-16489618 ] David Smiley commented on LUCENE-8323: -- Thanks for the review Adrien. bq. Did you use those license

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488963#comment-16488963 ] David Smiley commented on SOLR-12361: - BTW another thing I like about the approach of treating child

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488935#comment-16488935 ] David Smiley commented on SOLR-12361: - bq. Do you propose we deprecate _childDocuments for the time

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488401#comment-16488401 ] David Smiley commented on SOLR-12361: - I looked closer at what it would take to remove the direct

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488384#comment-16488384 ] David Smiley commented on SOLR-12361: - I mostly finished reviewing #382 (removal of \_childDocuments)

[jira] [Commented] (SOLR-12393) ExpandComponent only calculates the score of expanded docs when sorted by score

2018-05-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487949#comment-16487949 ] David Smiley commented on SOLR-12393: - This test exposes the problem.  The fix is probably

[jira] [Updated] (SOLR-12393) ExpandComponent only calculates the score of expanded docs when sorted by score

2018-05-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12393: Attachment: SOLR-12393.patch > ExpandComponent only calculates the score of expanded docs when

[jira] [Commented] (SOLR-12375) ScoreMode not always set correctly in Solr queries

2018-05-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487908#comment-16487908 ] David Smiley commented on SOLR-12375: - >From a W.I.P. test for expanded docs they don't return the

[jira] [Created] (SOLR-12393) ExpandComponent only calculates the score of expanded docs when sorted by score

2018-05-23 Thread David Smiley (JIRA)
David Smiley created SOLR-12393: --- Summary: ExpandComponent only calculates the score of expanded docs when sorted by score Key: SOLR-12393 URL: https://issues.apache.org/jira/browse/SOLR-12393 Project:

[jira] [Commented] (SOLR-12378) Support missing versionField on indexed docs in DocBasedVersionConstraintsURP

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484612#comment-16484612 ] David Smiley commented on SOLR-12378: - Did you intentionally mispell an existing comment RE "identiy"

[jira] [Commented] (SOLR-11779) Basic long-term collection of aggregated metrics

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484599#comment-16484599 ] David Smiley commented on SOLR-11779: - Maybe it doesn't make sense in 7x to have enable=true by

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484591#comment-16484591 ] David Smiley commented on SOLR-12386: - Analysis strategy: * Enumerate each test that has failed this

[jira] [Updated] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12386: Description: Some tests, especially ConcurrentCreateRoutedAliasTest, have failed sporadically 

[jira] [Updated] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12386: Environment: (was: Some tests, especially  ConcurrentCreateRoutedAliasTest, have failed

[jira] [Updated] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12386: Attachment: cant find resource, stacktrace.txt > Test fails for "Can't find resource" for files in

[jira] [Updated] (SOLR-12283) Unable To Load ZKPropertiesWriter when dih.jar is added as runtimelib BLOB in .system collection

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12283: Attachment: (was: image.png) > Unable To Load ZKPropertiesWriter when dih.jar is added as

[jira] [Updated] (SOLR-12283) Unable To Load ZKPropertiesWriter when dih.jar is added as runtimelib BLOB in .system collection

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12283: Attachment: image.png > Unable To Load ZKPropertiesWriter when dih.jar is added as runtimelib BLOB

[jira] [Created] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2018-05-22 Thread David Smiley (JIRA)
David Smiley created SOLR-12386: --- Summary: Test fails for "Can't find resource" for files in the _default configset Key: SOLR-12386 URL: https://issues.apache.org/jira/browse/SOLR-12386 Project: Solr

[jira] [Commented] (SOLR-11616) Backup failing on a constantly changing index with NoSuchFileException

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484468#comment-16484468 ] David Smiley commented on SOLR-11616: - I simply found by code inspection/reviewing all callers of

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-22 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483978#comment-16483978 ] David Smiley commented on SOLR-12361: - +1 to that > Change _childDocuments to Map >

[jira] [Commented] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483501#comment-16483501 ] David Smiley commented on SOLR-12366: - Updated the patch: * replaced the implementation of

[jira] [Updated] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12366: Attachment: SOLR-12366.patch > Avoid SlowAtomicReader.getLiveDocs -- it's slow >

[jira] [Commented] (SOLR-12337) Remove QueryWrapperFilter

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483445#comment-16483445 ] David Smiley commented on SOLR-12337: - In this updated patch, I further removed QueryWrapperFilter and

[jira] [Updated] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12366: Attachment: SOLR-12366.patch > Avoid SlowAtomicReader.getLiveDocs -- it's slow >

[jira] [Updated] (SOLR-12337) Remove QueryWrapperFilter

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12337: Attachment: SOLR-12337.patch > Remove QueryWrapperFilter > - > >

[jira] [Commented] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482693#comment-16482693 ] David Smiley commented on SOLR-12376: - Updated patch that passes precommit; there were some little

[jira] [Updated] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12376: Attachment: SOLR-12376.patch > New TaggerRequestHandler (aka SolrTextTagger) >

[jira] [Commented] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482529#comment-16482529 ] David Smiley commented on SOLR-12376: - Patch: * Copied into new package org.apache.solr.handler.tagger

[jira] [Updated] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12376: Attachment: SOLR-12376.patch > New TaggerRequestHandler (aka SolrTextTagger) >

[jira] [Commented] (SOLR-12378) Support missing versionField on indexed docs in DocBasedVersionConstraintsURP

2018-05-20 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482033#comment-16482033 ] David Smiley commented on SOLR-12378: - Agreed; this would be cool.  Patches welcome :) > Support

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

2018-05-20 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482024#comment-16482024 ] David Smiley commented on LUCENE-8306: -- I like TermPostingsEnum.  I wish PostingsEnum simply already

[jira] [Created] (SOLR-12376) New TaggerRequestHandler (aka SolrTextTagger)

2018-05-18 Thread David Smiley (JIRA)
David Smiley created SOLR-12376: --- Summary: New TaggerRequestHandler (aka SolrTextTagger) Key: SOLR-12376 URL: https://issues.apache.org/jira/browse/SOLR-12376 Project: Solr Issue Type: New

[jira] [Created] (LUCENE-8323) New ConcatenateFilter, a TokenFilter to concat/join tokens

2018-05-18 Thread David Smiley (JIRA)
David Smiley created LUCENE-8323: Summary: New ConcatenateFilter, a TokenFilter to concat/join tokens Key: LUCENE-8323 URL: https://issues.apache.org/jira/browse/LUCENE-8323 Project: Lucene - Core

[jira] [Commented] (SOLR-12375) ScoreMode not always set correctly in Solr queries

2018-05-18 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481072#comment-16481072 ] David Smiley commented on SOLR-12375: - My only concern is RE ExpandComponent. I didn't notice a test

[jira] [Commented] (SOLR-12337) Remove QueryWrapperFilter

2018-05-18 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480896#comment-16480896 ] David Smiley commented on SOLR-12337: - That TODO RE getProcessedFilter is a new issue I filed:

[jira] [Created] (SOLR-12375) ScoreMode not always set correctly in Solr queries

2018-05-18 Thread David Smiley (JIRA)
David Smiley created SOLR-12375: --- Summary: ScoreMode not always set correctly in Solr queries Key: SOLR-12375 URL: https://issues.apache.org/jira/browse/SOLR-12375 Project: Solr Issue Type:

[jira] [Commented] (LUCENE-8292) Fix FilterLeafReader.FilterTermsEnum to delegate all seekExact methods

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480093#comment-16480093 ] David Smiley commented on LUCENE-8292: -- Great example!  I was playing around with

[jira] [Created] (SOLR-12374) Add SolrCore.withSearcher(lambda accepting SolrIndexSearcher)

2018-05-17 Thread David Smiley (JIRA)
David Smiley created SOLR-12374: --- Summary: Add SolrCore.withSearcher(lambda accepting SolrIndexSearcher) Key: SOLR-12374 URL: https://issues.apache.org/jira/browse/SOLR-12374 Project: Solr

[jira] [Commented] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480048#comment-16480048 ] David Smiley commented on SOLR-12366: - When I tested locally, I got no reproducing test failures. >

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479764#comment-16479764 ] David Smiley commented on SOLR-11865: - BTW random comment; it seems inconsistent that

[jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479751#comment-16479751 ] David Smiley commented on SOLR-11865: - Bruno, can you please use a GitHub PR (referencing this issue

[jira] [Commented] (SOLR-11358) Support DelimitedTermFrequencyTokenFilter out of the box with dynamic field mapping

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479760#comment-16479760 ] David Smiley commented on SOLR-11358: - (sigh), I guess that ship has sailed > Support

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479317#comment-16479317 ] David Smiley commented on SOLR-9685: I'm +1 to the proposed syntax  But, a disclaimer, I don't

[jira] [Commented] (SOLR-11358) Support DelimitedTermFrequencyTokenFilter-using fields with payload() function

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479250#comment-16479250 ] David Smiley commented on SOLR-11358: - bq. Coming back to this, and double-checking the test cases and

[jira] [Commented] (SOLR-6733) Umbrella issue - Solr as a standalone application

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479242#comment-16479242 ] David Smiley commented on SOLR-6733: I think this comes down to the distinction of what do we want to

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479197#comment-16479197 ] David Smiley commented on SOLR-12338: - Maybe you can propose {{SetBlockingQueue}} (or whatever name we

[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479166#comment-16479166 ] David Smiley commented on SOLR-12361: - Oh yeah; the multi-valued question makes this solution path

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-17 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479083#comment-16479083 ] David Smiley commented on SOLR-12338: - {quote}Upload a patch that makes a change from using an array

[jira] [Commented] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478170#comment-16478170 ] David Smiley commented on SOLR-12366: - * adds new {{SolrIndexSearcher.getLiveDocsBits()}} method that

[jira] [Updated] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12366: Attachment: SOLR-12366.patch > Avoid SlowAtomicReader.getLiveDocs -- it's slow >

[jira] [Updated] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12366: Attachment: SOLR-12366.patch > Avoid SlowAtomicReader.getLiveDocs -- it's slow >

[jira] [Created] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-05-16 Thread David Smiley (JIRA)
David Smiley created SOLR-12366: --- Summary: Avoid SlowAtomicReader.getLiveDocs -- it's slow Key: SOLR-12366 URL: https://issues.apache.org/jira/browse/SOLR-12366 Project: Solr Issue Type:

[jira] [Created] (SOLR-12365) Rename Config.java to XmlConfigFile.java to clarify it's use

2018-05-16 Thread David Smiley (JIRA)
David Smiley created SOLR-12365: --- Summary: Rename Config.java to XmlConfigFile.java to clarify it's use Key: SOLR-12365 URL: https://issues.apache.org/jira/browse/SOLR-12365 Project: Solr

[jira] [Commented] (SOLR-11616) Backup failing on a constantly changing index with NoSuchFileException

2018-05-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477719#comment-16477719 ] David Smiley commented on SOLR-11616: - Looking at the code for SnapShooter.getIndexCommit, I see we

[jira] [Created] (SOLR-12364) edismax "boost" is not tested

2018-05-16 Thread David Smiley (JIRA)
David Smiley created SOLR-12364: --- Summary: edismax "boost" is not tested Key: SOLR-12364 URL: https://issues.apache.org/jira/browse/SOLR-12364 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-6733) Umbrella issue - Solr as a standalone application

2018-05-15 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476607#comment-16476607 ] David Smiley commented on SOLR-6733: What is the point of this issue? (Why) What positive benefit? >

[jira] [Created] (SOLR-12357) TRA: Pre-emptively create next collection

2018-05-15 Thread David Smiley (JIRA)
David Smiley created SOLR-12357: --- Summary: TRA: Pre-emptively create next collection Key: SOLR-12357 URL: https://issues.apache.org/jira/browse/SOLR-12357 Project: Solr Issue Type: Sub-task

[jira] [Commented] (SOLR-12345) indicate correctly spelt words and add to collation for search

2018-05-15 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475855#comment-16475855 ] David Smiley commented on SOLR-12345: - LOL being a highlighter expert doesn't make me a spellchecker

[jira] [Commented] (SOLR-12345) indicate correctly spelt words and add to collation for search

2018-05-15 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475760#comment-16475760 ] David Smiley commented on SOLR-12345: - [~janhoy] I assume you didn't intend to ask me; I assumed you

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-14 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474832#comment-16474832 ] David Smiley commented on SOLR-12338: - I looked at this again (after a few days of vacation) and I

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

2018-05-14 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474278#comment-16474278 ] David Smiley commented on LUCENE-8306: -- {quote}Could we address this need by calling extract terms

[jira] [Commented] (LUCENE-8306) Allow iteration over the term positions of a Match

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470627#comment-16470627 ] David Smiley commented on LUCENE-8306: -- Aha; so this is the solution highlighters need.  A good

[jira] [Commented] (SOLR-10981) Allow update to load gzip files

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470611#comment-16470611 ] David Smiley commented on SOLR-10981: - Sorry nevermind.  After looking at the linked issue I see that

[jira] [Commented] (SOLR-10981) Allow update to load gzip files

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470608#comment-16470608 ] David Smiley commented on SOLR-10981: - Just curious but wouldn't Jetty be able to handle this for us

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470528#comment-16470528 ] David Smiley commented on SOLR-12338: - Also if you submit without an ID, then it should probably

[jira] [Commented] (SOLR-12298) Index Full nested document Hierarchy For Queries (umbrella issue)

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470524#comment-16470524 ] David Smiley commented on SOLR-12298: - Alexandre, this feature is fundamentally about block-join /

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470518#comment-16470518 ] David Smiley commented on SOLR-12338: - This OrderedExecutor thing is nifty. It needs class-level

[jira] [Resolved] (SOLR-9638) SolrCloud restore of backup fails

2018-05-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-9638. Resolution: Invalid Closing as invalid; this feature requires a shared file system with write

[jira] [Resolved] (LUCENE-8305) ComplexPhraseQuery.rewrite can throw exception RE MatchNoDocsQuery if MTQ sub-clause matches no terms

2018-05-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8305. -- Resolution: Fixed > ComplexPhraseQuery.rewrite can throw exception RE MatchNoDocsQuery if MTQ

<    5   6   7   8   9   10   11   12   13   14   >