[jira] [Commented] (SOLR-12297) Create a good SolrClient for SolrCloud paving the way for async requests, HTTP2, multiplexing, and the latest & greatest Jetty features.

2018-05-05 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464718#comment-16464718 ] Mark Miller commented on SOLR-12297: Actually I think it does protocol negotiation too. That remove

[jira] [Commented] (SOLR-12297) Create a good SolrClient for SolrCloud paving the way for async requests, HTTP2, multiplexing, and the latest & greatest Jetty features.

2018-05-05 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464701#comment-16464701 ] Mark Miller commented on SOLR-12297: Oh nice, I was reading outdated Jetty 9 docs, the recent versions

[jira] [Commented] (SOLR-12313) TestInjection#waitForInSyncWithLeader needs improvement.

2018-05-05 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464684#comment-16464684 ] Mark Miller commented on SOLR-12313: Okay, I see, the uncommitted changes check is needed for the tlog

[jira] [Commented] (SOLR-12314) ConcurrentUpdateSolrClient doesn't respect the timeout's defined in the solr.xml file

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464573#comment-16464573 ] Mark Miller commented on SOLR-12314: We can't just remove it though. The CUSC timeout setters still

[jira] [Commented] (SOLR-12297) Create a good SolrClient for SolrCloud paving the way for async requests, HTTP2, multiplexing, and the latest & greatest Jetty features.

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464567#comment-16464567 ] Mark Miller commented on SOLR-12297: bq. Our clients don't support talking to HTTP2 so I'm not sure

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464563#comment-16464563 ] Mark Miller commented on SOLR-11881: bq. if we don't set the timeout on the HttpPost request by

[jira] [Commented] (SOLR-12297) Create a good SolrClient for SolrCloud paving the way for async requests, HTTP2, multiplexing, and the latest & greatest Jetty features.

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464559#comment-16464559 ] Mark Miller commented on SOLR-12297: I've grown even more confident we should move away from Apache's

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464539#comment-16464539 ] Mark Miller commented on SOLR-11881: [~varunthacker], when we update the httpclient we could no longer

[jira] [Commented] (SOLR-12313) TestInjection#waitForInSyncWithLeader needs improvement.

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464535#comment-16464535 ] Mark Miller commented on SOLR-12313: Yeah, I'm seeing BasicDistributedZkTest runs that are like 500s

[jira] [Updated] (SOLR-12297) Create a good SolrClient for SolrCloud paving the way for async requests, HTTP2, multiplexing, and the latest & greatest Jetty features.

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12297: --- Summary: Create a good SolrClient for SolrCloud paving the way for async requests, HTTP2,

[jira] [Commented] (SOLR-12313) TestInjection#waitForInSyncWithLeader needs improvement.

2018-05-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464501#comment-16464501 ] Mark Miller commented on SOLR-12313: I have to dig into this more to understand why this was sometimes

[jira] [Created] (SOLR-12313) TestInjection#waitForInSyncWithLeader needs improvement.

2018-05-04 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12313: -- Summary: TestInjection#waitForInSyncWithLeader needs improvement. Key: SOLR-12313 URL: https://issues.apache.org/jira/browse/SOLR-12313 Project: Solr Issue

[jira] [Created] (SOLR-12310) A commit or rollback caused by a request param using javabin and no updates will happen twice.

2018-05-03 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12310: -- Summary: A commit or rollback caused by a request param using javabin and no updates will happen twice. Key: SOLR-12310 URL: https://issues.apache.org/jira/browse/SOLR-12310

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2018-05-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463102#comment-16463102 ] Mark Miller commented on SOLR-7344: --- Even before, having multiple pools was probably the wrong idea.

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2018-05-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463061#comment-16463061 ] Mark Miller commented on SOLR-7344: --- For this issue, I don't really think we need to deal with this

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2018-05-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463010#comment-16463010 ] Mark Miller commented on SOLR-7344: --- Heh, it's a serious statement and question. We do want to determine

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2018-05-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462967#comment-16462967 ] Mark Miller commented on SOLR-7344: --- I don't know that we care about switching to Netty. Basically it's

[jira] [Commented] (SOLR-12293) Updates need to use their own connection pool to maintain connection reuse and prevent spurious recoveries.

2018-05-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462026#comment-16462026 ] Mark Miller commented on SOLR-12293: Hmm, we probably don't need the new executor as well. > Updates

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2018-05-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461753#comment-16461753 ] Mark Miller commented on SOLR-7344: --- I guess maybe without Http2 multiplexing it would depend on the

[jira] [Commented] (SOLR-7344) Allow Jetty thread pool limits while still avoiding distributed deadlock.

2018-05-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461743#comment-16461743 ] Mark Miller commented on SOLR-7344: --- Is this deadlock even an issue anymore? We are Jetty 9 now and it

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-05-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461686#comment-16461686 ] Mark Miller commented on SOLR-11881: Yeah, now I remember why forward has a retry and why it was so

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-05-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461629#comment-16461629 ] Mark Miller commented on SOLR-11881: Yeah, good catch - we are not versioned yet on forward. >

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-05-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461487#comment-16461487 ] Mark Miller commented on SOLR-11881: bq. But then I was looking at the ChaosMonkey logs and the amount

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-05-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461353#comment-16461353 ] Mark Miller commented on SOLR-11881: Cool, looks like the right approach. bq. ConnectException

[jira] [Comment Edited] (SOLR-12297) Create a good SolrClient for SolrCloud.

2018-05-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460140#comment-16460140 ] Mark Miller edited comment on SOLR-12297 at 5/1/18 9:07 PM: My plan for this

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

2018-05-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460143#comment-16460143 ] Mark Miller commented on SOLR-12290: For a long term strategy to improve all of this yet again (of

[jira] [Commented] (SOLR-12297) Create a good SolrClient for SolrCloud.

2018-05-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460140#comment-16460140 ] Mark Miller commented on SOLR-12297: My plan for this would be done in stages: Stage1: Add this new

[jira] [Updated] (SOLR-12297) Create a good SolrClient for SolrCloud.

2018-05-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12297: --- Description: Blocking or async support as well as HTTP2 compatible with multiplexing. Once it

[jira] [Updated] (SOLR-12297) Create a good SolrClient for SolrCloud.

2018-05-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12297: --- Description: Blocking or async support as well as HTTP2 compatible with multiplexing. Once it

[jira] [Commented] (SOLR-12297) Create a good SolrClient for SolrCloud.

2018-05-01 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459859#comment-16459859 ] Mark Miller commented on SOLR-12297: It's very easy to add an HTTP2 connector to Jetty, just swap in

[jira] [Created] (SOLR-12297) Create a good SolrClient for SolrCloud.

2018-04-30 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12297: -- Summary: Create a good SolrClient for SolrCloud. Key: SOLR-12297 URL: https://issues.apache.org/jira/browse/SOLR-12297 Project: Solr Issue Type: New Feature

[jira] [Commented] (SOLR-12293) Updates need to use their own connection pool to maintain connection reuse and prevent spurious recoveries.

2018-04-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458711#comment-16458711 ] Mark Miller commented on SOLR-12293: Patch attached to fix this. A connection manager and thread pool

[jira] [Updated] (SOLR-12293) Updates need to use their own connection pool to maintain connection reuse and prevent spurious recoveries.

2018-04-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12293: --- Attachment: SOLR-12293.patch > Updates need to use their own connection pool to maintain connection

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

2018-04-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458676#comment-16458676 ] Mark Miller commented on SOLR-12290: As I've been working on this, I realized that we don't ensure

[jira] [Created] (SOLR-12293) Updates need to use their own connection pool to maintain connection reuse and prevent spurious recoveries.

2018-04-30 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12293: -- Summary: Updates need to use their own connection pool to maintain connection reuse and prevent spurious recoveries. Key: SOLR-12293 URL:

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

2018-04-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458594#comment-16458594 ] Mark Miller commented on SOLR-12290: Yeah, it’s not super obvious, but the problem with closing

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-30 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458338#comment-16458338 ] Mark Miller commented on SOLR-11881: Another possibility (beyond some different bug) for the second

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458334#comment-16458334 ] Mark Miller commented on SOLR-11881: For the second exception here is something similiar:

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458322#comment-16458322 ] Mark Miller commented on SOLR-11881: [~varunthacker], look at the exception in the summary, you can

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458319#comment-16458319 ] Mark Miller commented on SOLR-11881: bq. I’m not sure we can know that updates before the failure were

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458316#comment-16458316 ] Mark Miller commented on SOLR-11881: SOLR-12290 may help with the cause of the connection reset. Hard

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458314#comment-16458314 ] Mark Miller commented on SOLR-12290: bq. JavabinLoader: you can now inline parseAndLoadDocs Inlined.

[jira] [Updated] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Summary: Do not close any servlet streams and improve our servlet stream closing prevention code for

[jira] [Updated] (SOLR-12290) Do not close an servlet streams and improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Priority: Major (was: Minor) Fix Version/s: master (8.0) 7.4 Issue

[jira] [Updated] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Description: Original Summary: When you fetch a file for replication we close the request output

[jira] [Updated] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Description: Original Summary: When you fetch a file for replication we close the request output

[jira] [Updated] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Description: Original Summary: When you fetch a file for replication we close the request output

[jira] [Commented] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458299#comment-16458299 ] Mark Miller commented on SOLR-12290: bq. Jetty incorrectly To clarify that, a Jetty servlet does it,

[jira] [Commented] (SOLR-11692) SolrDispatchFilter.closeShield passes the shielded response object back to jetty making the stream unclose able

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458296#comment-16458296 ] Mark Miller commented on SOLR-11692: Sorry, I missed this. The jetty servlet actually should not be

[jira] [Commented] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458295#comment-16458295 ] Mark Miller commented on SOLR-12290: bq. Admittedly there isn't a test for this and I forget precisely

[jira] [Comment Edited] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458290#comment-16458290 ] Mark Miller edited comment on SOLR-12286 at 4/30/18 3:21 AM: - These guys have

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458290#comment-16458290 ] Mark Miller commented on SOLR-12286: These guys have some arguments for using parameterized logging:

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458283#comment-16458283 ] Mark Miller commented on SOLR-12286: Yeah, I think the first step here is to figure out what is going

[jira] [Updated] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Attachment: SOLR-12290.patch > Improve our servlet stream closing prevention code for users and devs.

[jira] [Commented] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458237#comment-16458237 ] Mark Miller commented on SOLR-12290: Last patch, precommit and tests pass. > Improve our servlet

[jira] [Updated] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Summary: Improve our servlet stream closing prevention code for users and devs. (was: Remove

[jira] [Commented] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458205#comment-16458205 ] Mark Miller commented on SOLR-12290: Okay, I think this is final or close to. Gives us much less

[jira] [Updated] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Attachment: SOLR-12290.patch > Remove response output stream closes that have no affect and review

[jira] [Commented] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458192#comment-16458192 ] Mark Miller commented on SOLR-12290: New patch. We only assert no closes on callers from lucene and

[jira] [Updated] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Attachment: SOLR-12290.patch > Remove response output stream closes that have no affect and review

[jira] [Commented] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458112#comment-16458112 ] Mark Miller commented on SOLR-12290: Patch attached that cleans this up to be less error prone and

[jira] [Updated] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Attachment: SOLR-12290.patch > Remove response output stream closes that have no affect and review

[jira] [Updated] (SOLR-12290) Remove response output stream closes that have no affect and review our request/response close protection testing and impl.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Summary: Remove response output stream closes that have no affect and review our request/response

[jira] [Updated] (SOLR-12290) When you fetch a file for replication we close the request output stream after writing the file which ruins the connection for reuse.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Priority: Minor (was: Major) Description: Original Summary: When you fetch a file for

[jira] [Updated] (SOLR-12290) When you fetch a file for replication we close the request output stream after writing the file which ruins the connection for reuse.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: --- Issue Type: Task (was: Bug) > When you fetch a file for replication we close the request output

[jira] [Commented] (SOLR-12290) When you fetch a file for replication we close the request output stream after writing the file which ruins the connection for reuse.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458106#comment-16458106 ] Mark Miller commented on SOLR-12290: Looks like this may actually have been fixed during some

[jira] [Commented] (SOLR-12290) When you fetch a file for replication we close the request output stream after writing the file which ruins the connection for reuse.

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458075#comment-16458075 ] Mark Miller commented on SOLR-12290: This is kind of ugly because it happens during recovery - so if

[jira] [Created] (SOLR-12290) When you fetch a file for replication we close the request output stream after writing the file which ruins the connection for reuse.

2018-04-29 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12290: -- Summary: When you fetch a file for replication we close the request output stream after writing the file which ruins the connection for reuse. Key: SOLR-12290 URL:

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457345#comment-16457345 ] Mark Miller commented on SOLR-11881: I think we may be able to use the RetryNode stuff that update

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457124#comment-16457124 ] Mark Miller commented on SOLR-11881: bq. ConcurrentUpdateSolrClient#sendUpdateStream Sounds right.

[jira] [Commented] (SOLR-11749) regression-test-like functionality for bin/solr*

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456944#comment-16456944 ] Mark Miller commented on SOLR-11749: Just as an example, your Junit tests would end up looking

[jira] [Commented] (SOLR-11749) regression-test-like functionality for bin/solr*

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456923#comment-16456923 ] Mark Miller commented on SOLR-11749: Oh yeah, and then you don't have to implement the test framework

[jira] [Commented] (SOLR-11749) regression-test-like functionality for bin/solr*

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456922#comment-16456922 ] Mark Miller commented on SOLR-11749: This is great that you guys are addressing this! I wonder if

[jira] [Commented] (SOLR-9826) Shutting down leader when it's sending updates makes another active node go into recovery

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456877#comment-16456877 ] Mark Miller commented on SOLR-9826: --- See SOLR-9903 - I reference this JIRA in the description but had

[jira] [Commented] (SOLR-9826) Shutting down leader when it's sending updates makes another active node go into recovery

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456874#comment-16456874 ] Mark Miller commented on SOLR-9826: --- Looks like we no longer interrupt the update executor on shutdown,

[jira] [Commented] (SOLR-11702) Redesign current LIR implementation

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456851#comment-16456851 ] Mark Miller commented on SOLR-11702: This looks like a massive improvement for many long standing

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456848#comment-16456848 ] Mark Miller commented on SOLR-11881: Maybe we need to implement our own retry in distrib update

[jira] [Comment Edited] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456842#comment-16456842 ] Mark Miller edited comment on SOLR-11881 at 4/27/18 6:00 PM: - It's been a

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456842#comment-16456842 ] Mark Miller commented on SOLR-11881: It's been a while since I've thought about this, mind is begin to

[jira] [Assigned] (SOLR-12268) Opening a new NRT Searcher can take a while and block calls to /admin/cores.

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller reassigned SOLR-12268: -- Assignee: Mark Miller > Opening a new NRT Searcher can take a while and block calls to

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456743#comment-16456743 ] Mark Miller commented on SOLR-11881: bq. is there anything that uses the update client where a retry

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456742#comment-16456742 ] Mark Miller commented on SOLR-11881: We should also consider turning retry on for the read side as

[jira] [Commented] (SOLR-11881) Connection Reset Causing LIR

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456702#comment-16456702 ] Mark Miller commented on SOLR-11881: bq. Update requests between the leader and replica should be

[jira] [Commented] (SOLR-12268) Opening a new NRT Searcher can take a while and block calls to /admin/cores.

2018-04-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456692#comment-16456692 ] Mark Miller commented on SOLR-12268: Yeah, the IndexReader.isCurrent call in getIndexInfo. I believe

[jira] [Commented] (SOLR-11229) Add a configuration upgrade tool for Solr

2018-04-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455565#comment-16455565 ] Mark Miller commented on SOLR-11229: bq. I'm curious about the choice of XSLT here. I have never been

[jira] [Commented] (SOLR-12268) Opening a new NRT Searcher can take a while and block calls to /admin/cores.

2018-04-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454860#comment-16454860 ] Mark Miller commented on SOLR-12268: The problem being, an external tool may be polling /admin/cores

[jira] [Commented] (SOLR-12268) Opening a new NRT Searcher can take a while and block calls to /admin/cores.

2018-04-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454848#comment-16454848 ] Mark Miller commented on SOLR-12268: It seems to me we have to consider not adding anything that would

[jira] [Commented] (SOLR-10308) Solr fails to work with Guava 21.0

2018-04-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454311#comment-16454311 ] Mark Miller commented on SOLR-10308: bq. Mark Miller, I think you might qualify as a resident HDFS

[jira] [Commented] (SOLR-12261) Deleting collections should sync aliases before prematurely failing when alias is deleted

2018-04-24 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451272#comment-16451272 ] Mark Miller commented on SOLR-12261: bq. It's debatable if this is an improvement or a bug. Thats

[jira] [Created] (SOLR-12268) Opening a new NRT Searcher can take a while and block calls to /admin/cores.

2018-04-24 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12268: -- Summary: Opening a new NRT Searcher can take a while and block calls to /admin/cores. Key: SOLR-12268 URL: https://issues.apache.org/jira/browse/SOLR-12268 Project: Solr

[jira] [Commented] (LUCENE-8262) NativeFSLockFactory loses the channel when a thread is interrupted and the SolrCore becomes unusable after

2018-04-24 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449956#comment-16449956 ] Mark Miller commented on LUCENE-8262: - I've looked into this in the past. This is not the only

[jira] [Commented] (LUCENE-8264) Allow an option to rewrite all segments

2018-04-24 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449944#comment-16449944 ] Mark Miller commented on LUCENE-8264: - bq. Sorry, i don't the discussion makes much sense. The

[jira] [Commented] (SOLR-6286) TestReplicationHandler.doTestReplicateAfterCoreReload reliably reproducing seed failures comparing master commits before/after reload

2018-04-16 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440171#comment-16440171 ] Mark Miller commented on SOLR-6286: --- bq. I don't see how comparing commits before/after reload is

[jira] [Commented] (SOLR-6286) TestReplicationHandler.doTestReplicateAfterCoreReload reliably reproducing seed failures comparing master commits before/after reload

2018-04-16 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440170#comment-16440170 ] Mark Miller commented on SOLR-6286: --- bq. likely the intent was for the non-nightly doc count to remain at

[jira] [Created] (SOLR-12211) HdfsDirectoryFactoryTest can fail by trying to allocate too much direct memory.

2018-04-10 Thread Mark Miller (JIRA)
Mark Miller created SOLR-12211: -- Summary: HdfsDirectoryFactoryTest can fail by trying to allocate too much direct memory. Key: SOLR-12211 URL: https://issues.apache.org/jira/browse/SOLR-12211 Project:

[jira] [Commented] (SOLR-10783) Using Hadoop Credential Provider as SSL/TLS store password source

2018-04-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430727#comment-16430727 ] Mark Miller commented on SOLR-10783: Thanks Mano. I'll look at this again today. > Using Hadoop

[jira] [Commented] (SOLR-12133) TriggerIntegrationTest fails too easily.

2018-04-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422243#comment-16422243 ] Mark Miller commented on SOLR-12133: Thanks Shalin, this one was failing a lot on my std dev machine

[jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed

2018-03-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416335#comment-16416335 ] Mark Miller commented on SOLR-11882: bq. definitely not for 7.3. Could we introspect the impl and do

[jira] [Commented] (SOLR-10783) Using Hadoop Credential Provider as SSL/TLS store password source

2018-03-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416015#comment-16416015 ] Mark Miller commented on SOLR-10783: Also, are all of the SOLR_JETTY_CONFIG refs in solr.cmd treated

[jira] [Commented] (SOLR-12052) Schedule a BeastIt unit test report to be published every week.

2018-03-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413997#comment-16413997 ] Mark Miller commented on SOLR-12052: 3rd report is out this morning. I think the email may be caught

<    1   2   3   4   5   6   7   8   9   10   >