[jira] [Commented] (LUCENE-7627) Improve TermsEnum automaton filtering APIs

2017-01-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821686#comment-15821686 ] Michael McCandless commented on LUCENE-7627: Thanks [~romseygeek], I think the patch is good,

[jira] [Updated] (LUCENE-7626) IndexWriter shouldn't accept broken offsets

2017-01-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7626: --- Attachment: LUCENE-7626.patch New patch, also fixing {{CheckIndex}} to detect broken

[jira] [Resolved] (LUCENE-6638) Factor graph flattening out of SynonymFilter

2017-01-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-6638. Resolution: Duplicate This was done with LUCENE-6664, as the new

[jira] [Updated] (LUCENE-7619) Add WordDelimiterGraphFilter

2017-01-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7619: --- Attachment: LUCENE-7619.patch Another iteration; I think it's ready. I added an

[jira] [Updated] (LUCENE-7619) Add WordDelimiterGraphFilter

2017-01-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7619: --- Attachment: LUCENE-7619.patch Another iteration ... I think this one is very close,

[jira] [Created] (LUCENE-7626) IndexWriter shouldn't accept broken offsets

2017-01-11 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-7626: -- Summary: IndexWriter shouldn't accept broken offsets Key: LUCENE-7626 URL: https://issues.apache.org/jira/browse/LUCENE-7626 Project: Lucene - Core

[jira] [Updated] (LUCENE-7626) IndexWriter shouldn't accept broken offsets

2017-01-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7626: --- Attachment: LUCENE-7626.patch Patch, just for 7.0.0. I also added a (deprecated)

[jira] [Commented] (LUCENE-7624) Consider moving TermsQuery to core

2017-01-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811889#comment-15811889 ] Michael McCandless commented on LUCENE-7624: +1 for {{TermInSetQuery}}. > Consider moving

[jira] [Commented] (LUCENE-6989) Implement MMapDirectory unmapping for coming Java 9 changes

2017-01-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811491#comment-15811491 ] Michael McCandless commented on LUCENE-6989: Hmm why is the Fix Version here both 6.0 and 6.4

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2017-01-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809221#comment-15809221 ] Michael McCandless commented on LUCENE-7588: Thank you [~ekeller], the patch looks great, and

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2017-01-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808262#comment-15808262 ] Michael McCandless commented on LUCENE-7588: Oh I think I may see the issue! When we call

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2017-01-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808257#comment-15808257 ] Michael McCandless commented on LUCENE-7588: Hmm, but in {{testRandom}} we seem to always

[jira] [Updated] (LUCENE-7622) Should BaseTokenStreamTestCase catch analyzers that create duplicate tokens?

2017-01-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7622: --- Attachment: LUCENE-7622.patch Here's a simple patch ... but I don't plan to pursuing

[jira] [Created] (LUCENE-7622) Should BaseTokenStreamTestCase catch analyzers that create duplicate tokens?

2017-01-07 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-7622: -- Summary: Should BaseTokenStreamTestCase catch analyzers that create duplicate tokens? Key: LUCENE-7622 URL: https://issues.apache.org/jira/browse/LUCENE-7622

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2017-01-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805350#comment-15805350 ] Michael McCandless commented on LUCENE-7588: Thanks [~ekeller]! > A parallel DrillSideways

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2017-01-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804734#comment-15804734 ] Michael McCandless commented on LUCENE-7588: Hmm the ES jenkins caught this failure:

[jira] [Commented] (LUCENE-7614) Allow single prefix "phrase*" in complexphrase queryparser

2017-01-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804457#comment-15804457 ] Michael McCandless commented on LUCENE-7614: +1 > Allow single prefix "phrase*" in

[jira] [Resolved] (LUCENE-3424) Return sequence ids from IW update/delete/add/commit to allow total ordering outside of IW

2017-01-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-3424. Resolution: Duplicate This was done with LUCENE-7302. > Return sequence ids from

[jira] [Commented] (LUCENE-7614) Allow single term "phrase" in complexphrase queryparser

2017-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799548#comment-15799548 ] Michael McCandless commented on LUCENE-7614: Maybe check for {{MultiTermQuery}} instead of

[jira] [Commented] (LUCENE-7055) Better execution path for costly queries

2017-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799488#comment-15799488 ] Michael McCandless commented on LUCENE-7055: Thanks! Looks like a few {{estimateCost}}'s

[jira] [Updated] (LUCENE-7619) Add WordDelimiterGraphFilter

2017-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7619: --- Attachment: LUCENE-7619.patch Initial dirty, work-in-progress, overly verbose patch

[jira] [Updated] (LUCENE-7619) Add WordDelimiterGraphFilter

2017-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7619: --- Attachment: after.png before.png > Add WordDelimiterGraphFilter >

[jira] [Created] (LUCENE-7619) Add WordDelimiterGraphFilter

2017-01-04 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-7619: -- Summary: Add WordDelimiterGraphFilter Key: LUCENE-7619 URL: https://issues.apache.org/jira/browse/LUCENE-7619 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-7055) Better execution path for costly queries

2017-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797937#comment-15797937 ] Michael McCandless commented on LUCENE-7055: I really like this idea and the latest patch: I

[jira] [Commented] (LUCENE-1345) Allow Filter as clause to BooleanQuery

2017-01-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797929#comment-15797929 ] Michael McCandless commented on LUCENE-1345: I don't know the exact issue, but this idea was

[jira] [Commented] (LUCENE-6664) Replace SynonymFilter with SynonymGraphFilter

2017-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794880#comment-15794880 ] Michael McCandless commented on LUCENE-6664: [~steve_rowe], I pushed a fix for one of the

[jira] [Resolved] (LUCENE-7588) A parallel DrillSideways implementation

2017-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7588. Resolution: Fixed Fix Version/s: (was: 6.3.1) 6.4

[jira] [Resolved] (LUCENE-6582) SynonymFilter should generate a correct (or, at least, better) graph

2017-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-6582. Resolution: Duplicate This has been fixed with the addition of

[jira] [Resolved] (LUCENE-1622) Multi-word synonym filter (synonym expansion at indexing time).

2017-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1622. Resolution: Duplicate This is finally fixed with LUCENE-6664 and LUCENE-7603. >

[jira] [Resolved] (LUCENE-4499) Multi-word synonym filter (synonym expansion)

2017-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-4499. Resolution: Duplicate This has finally been fixed by LUCENE-6664 and LUCENE-7603.

[jira] [Resolved] (LUCENE-7603) Support Graph Token Streams in QueryBuilder

2017-01-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7603. Resolution: Fixed Fix Version/s: master (7.0) 6.x Thank

[jira] [Commented] (LUCENE-7612) Remove suggester dependency on misc

2016-12-31 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789322#comment-15789322 ] Michael McCandless commented on LUCENE-7612: +1 to remove the stale dep ... thanks

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2016-12-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787350#comment-15787350 ] Michael McCandless commented on LUCENE-7588: Thanks [~ekeller], I'll have a look likely once

[jira] [Commented] (LUCENE-7603) Support Graph Token Streams in QueryBuilder

2016-12-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787319#comment-15787319 ] Michael McCandless commented on LUCENE-7603: Thanks [~mattweber]; I will have a look,

[jira] [Commented] (LUCENE-7603) Support Graph Token Streams in QueryBuilder

2016-12-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782609#comment-15782609 ] Michael McCandless commented on LUCENE-7603: This change looks great; I think it's ready!

[jira] [Commented] (LUCENE-6664) Replace SynonymFilter with SynonymGraphFilter

2016-12-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782494#comment-15782494 ] Michael McCandless commented on LUCENE-6664: Thanks [~steve_rowe], I'll have a look, but

[jira] [Commented] (LUCENE-7603) Support Graph Token Streams in QueryBuilder

2016-12-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779150#comment-15779150 ] Michael McCandless commented on LUCENE-7603: Whoa, thanks [~mattweber], I'll have a look, but

[jira] [Commented] (LUCENE-6664) Replace SynonymFilter with SynonymGraphFilter

2016-12-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779143#comment-15779143 ] Michael McCandless commented on LUCENE-6664: Thanks [~steve_rowe], I'll look... > Replace

[jira] [Commented] (LUCENE-7530) extend/add -validate-source-patterns checks for .xml/.template files

2016-12-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773087#comment-15773087 ] Michael McCandless commented on LUCENE-7530: Can this be closed now [~cpoerschke]? >

[jira] [Commented] (LUCENE-7401) BKDWriter should ensure all dimensions are indexed

2016-12-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15772565#comment-15772565 ] Michael McCandless commented on LUCENE-7401: +1, I like how simple the implementation is,

[jira] [Resolved] (LUCENE-6664) Replace SynonymFilter with SynonymGraphFilter

2016-12-22 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-6664. Resolution: Fixed Fix Version/s: 6.4 master (7.0) >

[jira] [Commented] (LUCENE-7601) Make DocIdMerger.next() unspecified when exhausted

2016-12-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768506#comment-15768506 ] Michael McCandless commented on LUCENE-7601: +1 > Make DocIdMerger.next() unspecified when

[jira] [Commented] (LUCENE-7600) Simplify DocIdMerger

2016-12-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768037#comment-15768037 ] Michael McCandless commented on LUCENE-7600: +1, thanks [~jpountz]. > Simplify DocIdMerger >

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2016-12-21 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768029#comment-15768029 ] Michael McCandless commented on LUCENE-7588: Thanks [~ekeller], this looks great! Can we

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764963#comment-15764963 ] Michael McCandless commented on LUCENE-7579: Wow this change gave a big jump in indexing

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764013#comment-15764013 ] Michael McCandless commented on LUCENE-7579: Thank you [~jim.ferenczi]! I just pushed your

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-20 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763859#comment-15763859 ] Michael McCandless commented on LUCENE-7579: Patch looks great to me! I think (later,

[jira] [Updated] (LUCENE-6664) Replace SynonymFilter with SynonymGraphFilter

2016-12-19 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-6664: --- Attachment: LUCENE-6664.patch Here's another patch, just modernizing the last one to

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2016-12-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759696#comment-15759696 ] Michael McCandless commented on LUCENE-7588: bq. I am working on providing a benchmark. What

[jira] [Resolved] (LUCENE-7587) New FacetQuery and MultiFacetQuery

2016-12-16 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7587. Resolution: Fixed Fix Version/s: (was: 6.3.1) 6.4

[jira] [Commented] (LUCENE-7587) New FacetQuery and MultiFacetQuery

2016-12-16 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754482#comment-15754482 ] Michael McCandless commented on LUCENE-7587: Thanks [~ekeller], this looks great, I'll push

[jira] [Commented] (LUCENE-7592) EOFException while opening index should be rethrown as CorruptIndexException

2016-12-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753056#comment-15753056 ] Michael McCandless commented on LUCENE-7592: bq. Did you forget to assign to yourself? I

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2016-12-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752528#comment-15752528 ] Michael McCandless commented on LUCENE-7588: Thanks [~ekeller]: this is an impressive change!

[jira] [Commented] (LUCENE-7587) New FacetQuery and MultiFacetQuery

2016-12-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751753#comment-15751753 ] Michael McCandless commented on LUCENE-7587: These helper classes look great, thank you

[jira] [Commented] (LUCENE-7588) A parallel DrillSideways implementation

2016-12-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751726#comment-15751726 ] Michael McCandless commented on LUCENE-7588: Sorry, I have been meaning to have a look at

[jira] [Resolved] (LUCENE-7592) EOFException while opening index should be rethrown as CorruptIndexException

2016-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7592. Resolution: Fixed Fix Version/s: 6.4 master (7.0) >

[jira] [Commented] (LUCENE-7592) EOFException while opening index should be rethrown as CorruptIndexException

2016-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749764#comment-15749764 ] Michael McCandless commented on LUCENE-7592: Thanks [~mdrob], that's looks great; I'll push.

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749534#comment-15749534 ] Michael McCandless commented on LUCENE-7579: Wow, this patch brings the "sparse sorted"

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749502#comment-15749502 ] Michael McCandless commented on LUCENE-7579: bq. We still need to wrap unsorted segments

[jira] [Commented] (LUCENE-7592) EOFException while opening index should be rethrown as CorruptIndexException

2016-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749339#comment-15749339 ] Michael McCandless commented on LUCENE-7592: +1 to report {{CorruptIndexException}} not an

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-13 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745571#comment-15745571 ] Michael McCandless commented on LUCENE-7579: Thanks [~jim.ferenczi], I'll have a look. >

[jira] [Commented] (LUCENE-7590) Add DocValues statistics helpers

2016-12-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741852#comment-15741852 ] Michael McCandless commented on LUCENE-7590: Thanks [~shaie] the patch looks great! > Add

[jira] [Commented] (LUCENE-7589) Prevent outliers from raising the number of bits of everyone with numeric doc values

2016-12-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741566#comment-15741566 ] Michael McCandless commented on LUCENE-7589: bq. However if you add a new field that stores

[jira] [Commented] (LUCENE-7590) Add DocValues statistics helpers

2016-12-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741562#comment-15741562 ] Michael McCandless commented on LUCENE-7590: Thanks [~shaie]. Maybe instead of a new

[jira] [Commented] (LUCENE-7589) Prevent outliers from raising the number of bits of everyone with numeric doc values

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736776#comment-15736776 ] Michael McCandless commented on LUCENE-7589: The patch looks great, just this minor typo: {{

[jira] [Resolved] (LUCENE-7570) Tragic events during merges can lead to deadlock

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7570. Resolution: Fixed Fix Version/s: 6.4 master (7.0) >

[jira] [Resolved] (LUCENE-7581) IndexWriter#updateDocValues can break index sorting

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7581. Resolution: Fixed Fix Version/s: 6.4 master (7.0) Thank

[jira] [Commented] (LUCENE-7575) UnifiedHighlighter: add requireFieldMatch=false support

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736587#comment-15736587 ] Michael McCandless commented on LUCENE-7575: [~dsmiley] Please see [~hossman]'s comment

[jira] [Commented] (LUCENE-7584) Potential leak issue

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736581#comment-15736581 ] Michael McCandless commented on LUCENE-7584: Hmm which version of Lucene is this? It looks

[jira] [Updated] (LUCENE-7584) Potential leak issue

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7584: --- Description: May the following method have a potential leak like LUCENE-3251 when

[jira] [Commented] (LUCENE-7581) IndexWriter#updateDocValues can break index sorting

2016-12-09 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736549#comment-15736549 ] Michael McCandless commented on LUCENE-7581: Thanks [~jim.ferenczi], this looks great; I'll

[jira] [Updated] (LUCENE-7570) Tragic events during merges can lead to deadlock

2016-12-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7570: --- Attachment: LUCENE-7570.patch Here's a patch w/ test case reproducing the deadlock,

[jira] [Resolved] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7583. Resolution: Fixed > Can we improve OutputStreamIndexOutput's byte buffering when

[jira] [Reopened] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reopened LUCENE-7583: > Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD >

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733691#comment-15733691 ] Michael McCandless commented on LUCENE-7583: bq. Note: this breaks my eclipse build (on 6x at

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-08 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731833#comment-15731833 ] Michael McCandless commented on LUCENE-7583: bq. I was just wondering why you added the "if

[jira] [Resolved] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7583. Resolution: Fixed > Can we improve OutputStreamIndexOutput's byte buffering when

[jira] [Resolved] (LUCENE-7563) BKD index should compress unused leading bytes

2016-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7563. Resolution: Fixed > BKD index should compress unused leading bytes >

[jira] [Updated] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-07 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7583: --- Attachment: LUCENE-7583.patch Here's a patch, just moving

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726001#comment-15726001 ] Michael McCandless commented on LUCENE-7583: bq. I think ByteArrayDataOutput is always a good

[jira] [Updated] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7583: --- Attachment: LUCENE-7583.fork-FastOutputStream.patch OK, I forked Solrj's

[jira] [Updated] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7583: --- Attachment: LUCENE-7583.private-IndexOutput.patch OK I made the 2 places where we

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725835#comment-15725835 ] Michael McCandless commented on LUCENE-7583: I also tried with {{ByteArrayDataOutput}} and it

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725830#comment-15725830 ] Michael McCandless commented on LUCENE-7583: bq. Are we sure that we do not open the

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725624#comment-15725624 ] Michael McCandless commented on LUCENE-7583: Hmm, this is interesting: I temporarily forked

[jira] [Commented] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725607#comment-15725607 ] Michael McCandless commented on LUCENE-7583: bq. Do we call flush at some places? I am sure

[jira] [Commented] (LUCENE-7582) NIOFSDirectory sometime doesn't work on windows

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725280#comment-15725280 ] Michael McCandless commented on LUCENE-7582: Note that the exception you are hitting is a

[jira] [Updated] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7583: --- Attachment: LUCENE-7583-hardcode-writeVInt.patch bq. Another try would be to

[jira] [Updated] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7583: --- Attachment: LUCENE-7583.patch Simple patch. > Can we improve

[jira] [Created] (LUCENE-7583) Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block?

2016-12-06 Thread Michael McCandless (JIRA)
Michael McCandless created LUCENE-7583: -- Summary: Can we improve OutputStreamIndexOutput's byte buffering when writing each BKD leaf block? Key: LUCENE-7583 URL:

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722610#comment-15722610 ] Michael McCandless commented on LUCENE-7579: This is a nice approach! Basically, the codec

[jira] [Commented] (LUCENE-7563) BKD index should compress unused leading bytes

2016-12-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722537#comment-15722537 ] Michael McCandless commented on LUCENE-7563: Ahh, OK; I think we should restrict {{TestBKD}}

[jira] [Commented] (LUCENE-7581) IndexWriter#updateDocValues can break index sorting

2016-12-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722337#comment-15722337 ] Michael McCandless commented on LUCENE-7581: Thanks [~jim.ferenczi]; I think we need to fix

[jira] [Commented] (LUCENE-7563) BKD index should compress unused leading bytes

2016-12-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722090#comment-15722090 ] Michael McCandless commented on LUCENE-7563: bq. I think there is just a redundant arraycopy

[jira] [Resolved] (LUCENE-7576) RegExp automaton causes NPE on Terms.intersect

2016-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-7576. Resolution: Fixed Fix Version/s: 6.4 master (7.0) Thank

[jira] [Updated] (LUCENE-7563) BKD index should compress unused leading bytes

2016-12-02 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7563: --- Attachment: LUCENE-7563.patch New patch; I think it's ready. This breaks out a

[jira] [Commented] (LUCENE-7579) Sorting on flushed segment

2016-12-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713678#comment-15713678 ] Michael McCandless commented on LUCENE-7579: Thanks [~jim.ferenczi], I also see comparable

[jira] [Commented] (LUCENE-7570) Tragic events during merges can lead to deadlock

2016-11-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708924#comment-15708924 ] Michael McCandless commented on LUCENE-7570: And thank you [~fwiffo]! > Tragic events during

[jira] [Commented] (LUCENE-7570) Tragic events during merges can lead to deadlock

2016-11-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708923#comment-15708923 ] Michael McCandless commented on LUCENE-7570: Thanks for reporting this [~marumarutan], I'll

[jira] [Updated] (LUCENE-7563) BKD index should compress unused leading bytes

2016-11-28 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-7563: --- Attachment: LUCENE-7563.patch New patch, folding in [~jpountz]'s first idea. I like

<    3   4   5   6   7   8   9   10   11   12   >