[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687665#comment-16687665
]
Peter Somogyi commented on SOLR-12881:
--
Thank you all for the reviews and Erick for committing!
>
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12881:
-
Attachment: SOLR-12881.patch
> Remove unneeded import statements
>
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685159#comment-16685159
]
Peter Somogyi commented on SOLR-12881:
--
Thanks for the inputs! I added the pattern to
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12881:
-
Attachment: SOLR-12881.patch
> Remove unneeded import statements
>
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682914#comment-16682914
]
Peter Somogyi commented on SOLR-12881:
--
{quote}My question is, why remove these if they are not
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682804#comment-16682804
]
Peter Somogyi commented on SOLR-12881:
--
The import of FrenchLightStemFilter is unnecessary since
[
https://issues.apache.org/jira/browse/LUCENE-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682344#comment-16682344
]
Peter Somogyi commented on LUCENE-8537:
---
Thanks [~thetaphi] for committing the change!
> ant test
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682343#comment-16682343
]
Peter Somogyi commented on SOLR-12881:
--
LUCENE-8537 was committed which fixes the build failure in
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12881:
-
Attachment: SOLR-12881.patch
> Remove unneeded import statements
>
[
https://issues.apache.org/jira/browse/LUCENE-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662372#comment-16662372
]
Peter Somogyi commented on LUCENE-8537:
---
Hi [~thetaphi], Could you merge this patch?
> ant test
[
https://issues.apache.org/jira/browse/LUCENE-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657291#comment-16657291
]
Peter Somogyi commented on LUCENE-8537:
---
Thanks for reviewing [~thetaphi]!
> ant test command
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655737#comment-16655737
]
Peter Somogyi commented on SOLR-12881:
--
The test errors are unrelated because none of them has
[
https://issues.apache.org/jira/browse/LUCENE-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated LUCENE-8537:
--
Attachment: LUCENE-8537.patch
> ant test command fails under lucene/tools
>
Peter Somogyi created LUCENE-8537:
-
Summary: ant test command fails under lucene/tools
Key: LUCENE-8537
URL: https://issues.apache.org/jira/browse/LUCENE-8537
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655143#comment-16655143
]
Peter Somogyi commented on SOLR-12881:
--
Most of the imports that I removed were from the same
[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12881:
-
Attachment: SOLR-12881.patch
> Remove unneeded import statements
>
Peter Somogyi created SOLR-12881:
Summary: Remove unneeded import statements
Key: SOLR-12881
URL: https://issues.apache.org/jira/browse/SOLR-12881
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652160#comment-16652160
]
Peter Somogyi commented on SOLR-12870:
--
I tested the 2 failures and they don't look related to this
[
https://issues.apache.org/jira/browse/SOLR-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12870:
-
Attachment: SOLR-12870.master.1.patch
> Use StandardCharsets instead of String values
>
Peter Somogyi created SOLR-12870:
Summary: Use StandardCharsets instead of String values
Key: SOLR-12870
URL: https://issues.apache.org/jira/browse/SOLR-12870
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628057#comment-16628057
]
Peter Somogyi commented on SOLR-12652:
--
The test failure was related to my change. Fixed it in
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12652:
-
Attachment: SOLR-12652.patch
> SolrMetricManager.overridableRegistryName should be removed; it
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626400#comment-16626400
]
Peter Somogyi commented on SOLR-12652:
--
I attached the patch file. I'm not able to change the state
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated SOLR-12652:
-
Attachment: SOLR-12652.patch
> SolrMetricManager.overridableRegistryName should be removed; it
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626253#comment-16626253
]
Peter Somogyi commented on SOLR-12652:
--
[~dsmiley], could you merge the [pull
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609146#comment-16609146
]
Peter Somogyi commented on SOLR-12652:
--
Thanks for reviewing [~dsmiley].
[~ab]: What do you think
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585611#comment-16585611
]
Peter Somogyi commented on SOLR-12652:
--
[~dsmiley], could you review the pull request? Thanks!
>
[
https://issues.apache.org/jira/browse/SOLR-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547567#comment-16547567
]
Peter Somogyi commented on SOLR-11431:
--
[~markrmil...@gmail.com], could you check the pull request I
28 matches
Mail list logo
