[jira] [Commented] (LUCENE-7382) Wrong default attribute factory in use

[ https://issues.apache.org/jira/browse/LUCENE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379453#comment-15379453 ] Terry Smith commented on LUCENE-7382: - Thanks, I didn't realize this would hit 6.2. I have nightly

[jira] [Created] (LUCENE-7382) Wrong default attribute factory in use

Terry Smith created LUCENE-7382: --- Summary: Wrong default attribute factory in use Key: LUCENE-7382 URL: https://issues.apache.org/jira/browse/LUCENE-7382 Project: Lucene - Core Issue Type: Bug

[jira] [Commented] (LUCENE-6922) Improve svn to git workaround script

[ https://issues.apache.org/jira/browse/LUCENE-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060811#comment-15060811 ] Terry Smith commented on LUCENE-6922: - Does LUCENE-6933 affect this ticket? > Improve svn to git

[jira] [Commented] (LUCENE-6922) Improve svn to git workaround script

[ https://issues.apache.org/jira/browse/LUCENE-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060830#comment-15060830 ] Terry Smith commented on LUCENE-6922: - Ah, so I could consider this as a backup plan until

[jira] [Commented] (LUCENE-6922) Improve svn to git workaround script

[ https://issues.apache.org/jira/browse/LUCENE-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045060#comment-15045060 ] Terry Smith commented on LUCENE-6922: - Is the announcement of the EOL to the git-svn mirror available

[jira] [Commented] (LUCENE-6922) Improve svn to git workaround script

[ https://issues.apache.org/jira/browse/LUCENE-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045069#comment-15045069 ] Terry Smith commented on LUCENE-6922: - Oops, I guess I'm behind with the mailing list, just found the

[jira] [Commented] (LUCENE-6889) BooleanQuery.rewrite could easily optimize some simple cases

[ https://issues.apache.org/jira/browse/LUCENE-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998891#comment-14998891 ] Terry Smith commented on LUCENE-6889: - Ah, that makes sense. I didn't realize the first scenario was

[jira] [Commented] (LUCENE-6889) BooleanQuery.rewrite could easily optimize some simple cases

[ https://issues.apache.org/jira/browse/LUCENE-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998808#comment-14998808 ] Terry Smith commented on LUCENE-6889: - I like the last one but believe that the other two aren't

[jira] [Commented] (LUCENE-6679) Filter's Weight.explain returns an explanation with isMatch==true even on documents that don't match

[ https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996583#comment-14996583 ] Terry Smith commented on LUCENE-6679: - Thanks Adrien, I'll give it a shot this morning and reach out

[jira] [Updated] (LUCENE-6679) Filter's Weight.explain returns an explanation with isMatch==true even on documents that don't match

[ https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6679: Attachment: LUCENE-6679.patch Here is an updated patch against trunk that adds hit and miss

[jira] [Commented] (LUCENE-6679) Filter's Weight.explain returns an explanation with isMatch==true even on documents that don't match

[ https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994430#comment-14994430 ] Terry Smith commented on LUCENE-6679: - Darn, sorry I didn't get back to pushing these new tests into

[jira] [Commented] (LUCENE-6834) Remove BoostQuery.toString()'s hack with parenthesis

[ https://issues.apache.org/jira/browse/LUCENE-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948670#comment-14948670 ] Terry Smith commented on LUCENE-6834: - Great idea. It currently puts user-defined queries at a

[jira] [Commented] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947239#comment-14947239 ] Terry Smith commented on LUCENE-6590: - Thanks Adrien. My nightly regressions just picked this up

[jira] [Commented] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933375#comment-14933375 ] Terry Smith commented on LUCENE-6590: - Cheers Adrien. Sorry for the spammy replies before -- I wasn't

[jira] [Comment Edited] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14933375#comment-14933375 ] Terry Smith edited comment on LUCENE-6590 at 9/28/15 2:38 PM: -- Cheers

[jira] [Commented] (LUCENE-6699) Integrate lat/lon BKD and spatial3d

[ https://issues.apache.org/jira/browse/LUCENE-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906465#comment-14906465 ] Terry Smith commented on LUCENE-6699: - Thanks guys. I was hoping to squeeze those x,y,z values into a

[jira] [Commented] (LUCENE-6815) Should DisjunctionScorer advance more lazily?

[ https://issues.apache.org/jira/browse/LUCENE-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906401#comment-14906401 ] Terry Smith commented on LUCENE-6815: - Additionally, I don't see DisiPriorityQueue taking the cost of

[jira] [Commented] (LUCENE-6699) Integrate lat/lon BKD and spatial3d

[ https://issues.apache.org/jira/browse/LUCENE-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904650#comment-14904650 ] Terry Smith commented on LUCENE-6699: - Karl, were you able to find that packing scheme? I'm

[jira] [Commented] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745623#comment-14745623 ] Terry Smith commented on LUCENE-6590: - [~jpountz]: PhraseQuery is missing a call to

[jira] [Commented] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745675#comment-14745675 ] Terry Smith commented on LUCENE-6590: - Also FunctionQuery. > Explore different ways to apply

[jira] [Commented] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745653#comment-14745653 ] Terry Smith commented on LUCENE-6590: - Hmm, so is NumericRangeQuery. > Explore different ways to

[jira] [Created] (LUCENE-6806) FunctionQuery.AllScorer.explain overwrites FunctionWeight.queryNorm in trappy fashion

Terry Smith created LUCENE-6806: --- Summary: FunctionQuery.AllScorer.explain overwrites FunctionWeight.queryNorm in trappy fashion Key: LUCENE-6806 URL: https://issues.apache.org/jira/browse/LUCENE-6806

[jira] [Commented] (LUCENE-6785) Consider merging Query.rewrite() into Query.createWeight()

[ https://issues.apache.org/jira/browse/LUCENE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736932#comment-14736932 ] Terry Smith commented on LUCENE-6785: - The original patch drops a few key settings from the

[jira] [Updated] (LUCENE-6787) BooleanQuery should be able to drop duplicate non-scoring clauses

[ https://issues.apache.org/jira/browse/LUCENE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6787: Attachment: LUCENE-6787.patch Absolutely, updated patch attached. > BooleanQuery should be able

[jira] [Updated] (LUCENE-6787) BooleanQuery should be able to drop duplicate non-scoring clauses

[ https://issues.apache.org/jira/browse/LUCENE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6787: Attachment: LUCENE-6787-on-6785.patch Here is an alternate patch applied after LUCENE-6785. >

[jira] [Created] (LUCENE-6787) BooleanQuery should be able to drop duplicate non-scoring clauses

Terry Smith created LUCENE-6787: --- Summary: BooleanQuery should be able to drop duplicate non-scoring clauses Key: LUCENE-6787 URL: https://issues.apache.org/jira/browse/LUCENE-6787 Project: Lucene -

[jira] [Updated] (LUCENE-6679) Filter's Weight.explain returns an explanation with isMatch==true even on documents that don't match

[ https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6679: Attachment: LUCENE-6679.patch Here is a patch (against trunk) that adds test coverage for

[jira] [Updated] (LUCENE-6787) BooleanQuery should be able to drop duplicate non-scoring clauses

[ https://issues.apache.org/jira/browse/LUCENE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6787: Attachment: LUCENE-6787.patch Here is a patch based on [~jpountz]'s suggestion of putting this

[jira] [Commented] (LUCENE-6758) Adding a SHOULD clause to a BQ over an empty field clears the score when using DefaultSimilarity

[ https://issues.apache.org/jira/browse/LUCENE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734796#comment-14734796 ] Terry Smith commented on LUCENE-6758: - Ah, you've changed DefaultSimilarity.idf() to use (docCount +

[jira] [Updated] (LUCENE-6758) Adding a SHOULD clause to a BQ over an empty field clears the score when using DefaultSimilarity

[ https://issues.apache.org/jira/browse/LUCENE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6758: Attachment: LUCENE-6758.patch Run this unit test a few times and you'll hit a failure when

[jira] [Commented] (LUCENE-6758) Adding a SHOULD clause to a BQ over an empty field clears the score when using DefaultSimilarity

[ https://issues.apache.org/jira/browse/LUCENE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706963#comment-14706963 ] Terry Smith commented on LUCENE-6758: - Explain output for the failing query

[jira] [Created] (LUCENE-6758) Adding a SHOULD clause to a BQ over an empty field clears the score when using DefaultSimilarity

Terry Smith created LUCENE-6758: --- Summary: Adding a SHOULD clause to a BQ over an empty field clears the score when using DefaultSimilarity Key: LUCENE-6758 URL: https://issues.apache.org/jira/browse/LUCENE-6758

[jira] [Commented] (LUCENE-6748) The query cache should not cache trivial queries

[ https://issues.apache.org/jira/browse/LUCENE-6748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705045#comment-14705045 ] Terry Smith commented on LUCENE-6748: - I'd add a case to the patch to include empty

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647690#comment-14647690 ] Terry Smith commented on LUCENE-6531: - [~jpountz] The PhraseQuery.Builder setter

[jira] [Commented] (LUCENE-6531) Make PhraseQuery immutable

[ https://issues.apache.org/jira/browse/LUCENE-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647701#comment-14647701 ] Terry Smith commented on LUCENE-6531: - Awesome, you rock! Make PhraseQuery

[jira] [Commented] (LUCENE-6590) Explore different ways to apply boosts

[ https://issues.apache.org/jira/browse/LUCENE-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639166#comment-14639166 ] Terry Smith commented on LUCENE-6590: - I think this looks great and will certainly

[jira] [Commented] (LUCENE-6679) Filter's Weight.explain returns an explanation with isMatch==true even on documents that don't match

[ https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629956#comment-14629956 ] Terry Smith commented on LUCENE-6679: - Trejkaz confirmed the patch referenced from

[jira] [Commented] (LUCENE-6679) Filter's Weight.explan returns an explanation with isMatch==true even on documents that don't match

[ https://issues.apache.org/jira/browse/LUCENE-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628153#comment-14628153 ] Terry Smith commented on LUCENE-6679: - [~jpountz] Absolutely, I'd love to give it a

[jira] [Commented] (LUCENE-6661) Allow queries to opt out of caching

[ https://issues.apache.org/jira/browse/LUCENE-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622271#comment-14622271 ] Terry Smith commented on LUCENE-6661: - I agree that we shouldn't base API's off of

[jira] [Commented] (LUCENE-6661) Allow queries to opt out of caching

[ https://issues.apache.org/jira/browse/LUCENE-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616723#comment-14616723 ] Terry Smith commented on LUCENE-6661: - I'd completely missed the issue with marker

[jira] [Created] (LUCENE-6661) Allow queries to opt out of caching

Terry Smith created LUCENE-6661: --- Summary: Allow queries to opt out of caching Key: LUCENE-6661 URL: https://issues.apache.org/jira/browse/LUCENE-6661 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-6661) Allow queries to opt out of caching

[ https://issues.apache.org/jira/browse/LUCENE-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6661: Attachment: LUCENE-6661.patch Rather than add a new method to Query/Weight this feature I've added

[jira] [Commented] (LUCENE-6639) LRUQueryCache.CachingWrapperWeight not calling policy.onUse() if the first scorer is skipped

[ https://issues.apache.org/jira/browse/LUCENE-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615087#comment-14615087 ] Terry Smith commented on LUCENE-6639: - Ah, I didn't realize the highlighters were

[jira] [Commented] (LUCENE-6639) LRUQueryCache.CachingWrapperWeight not calling policy.onUse() if the first scorer is skipped

[ https://issues.apache.org/jira/browse/LUCENE-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608281#comment-14608281 ] Terry Smith commented on LUCENE-6639: - This doesn't seem pressing but irked me enough

[jira] [Updated] (LUCENE-6639) LRUQueryCache.CachingWrapperWeight not calling policy.onUse() if the first scorer is skipped

[ https://issues.apache.org/jira/browse/LUCENE-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6639: Attachment: LUCENE-6639.patch Attached unit test will fail if the extra IndexWriter.commit() gets

[jira] [Created] (LUCENE-6639) LRUQueryCache.CachingWrapperWeight not calling policy.onUse() if the first scorer is skipped

Terry Smith created LUCENE-6639: --- Summary: LRUQueryCache.CachingWrapperWeight not calling policy.onUse() if the first scorer is skipped Key: LUCENE-6639 URL: https://issues.apache.org/jira/browse/LUCENE-6639

[jira] [Commented] (LUCENE-6305) BooleanQuery.equals should ignore clause order

[ https://issues.apache.org/jira/browse/LUCENE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593457#comment-14593457 ] Terry Smith commented on LUCENE-6305: - Oops, read the patch too quickly and missed

[jira] [Commented] (LUCENE-6305) BooleanQuery.equals should ignore clause order

[ https://issues.apache.org/jira/browse/LUCENE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593447#comment-14593447 ] Terry Smith commented on LUCENE-6305: - Having BooleanQuery.equals() ignore order is a

[jira] [Commented] (LUCENE-6305) BooleanQuery.equals should ignore clause order

[ https://issues.apache.org/jira/browse/LUCENE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593467#comment-14593467 ] Terry Smith commented on LUCENE-6305: - Slightly off topic to your original goal, but

[jira] [Commented] (LUCENE-6446) Simplify Explanation API

[ https://issues.apache.org/jira/browse/LUCENE-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507111#comment-14507111 ] Terry Smith commented on LUCENE-6446: - bq. I removed it because it was not always in

[jira] [Commented] (LUCENE-6446) Simplify Explanation API

[ https://issues.apache.org/jira/browse/LUCENE-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507038#comment-14507038 ] Terry Smith commented on LUCENE-6446: - The refactored Explanation looks great,

[jira] [Created] (LUCENE-6385) NullPointerException from Highlighter.getBestFragment()

Terry Smith created LUCENE-6385: --- Summary: NullPointerException from Highlighter.getBestFragment() Key: LUCENE-6385 URL: https://issues.apache.org/jira/browse/LUCENE-6385 Project: Lucene - Core

[jira] [Updated] (LUCENE-6385) NullPointerException from Highlighter.getBestFragment()

[ https://issues.apache.org/jira/browse/LUCENE-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-6385: Attachment: LUCENE-6385.patch NullPointerException from Highlighter.getBestFragment()

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335022#comment-14335022 ] Terry Smith commented on LUCENE-6229: - Understood. If you end up keeping

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334937#comment-14334937 ] Terry Smith commented on LUCENE-6229: - [~rcmuir] Sorry for excluding that scenario,

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329069#comment-14329069 ] Terry Smith commented on LUCENE-6229: - I’ll summarize this as two options: # Remove

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324686#comment-14324686 ] Terry Smith commented on LUCENE-6229: - [~rcmuir] Thanks for the backstory. I've been

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318272#comment-14318272 ] Terry Smith commented on LUCENE-6229: - [~jpountz] - I'm going to split the freq() vs

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314219#comment-14314219 ] Terry Smith commented on LUCENE-6229: - Like Stefan, I'm also using this functionality

[jira] [Commented] (LUCENE-6229) Remove Scorer.getChildren?

[ https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314361#comment-14314361 ] Terry Smith commented on LUCENE-6229: - h2. freq() vs score() I think the lazy

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314242#comment-14314242 ] Terry Smith commented on LUCENE-6232: - I have custom code that injects objects into

[jira] [Commented] (LUCENE-6232) Replace ValueSource context Map with a more concrete data type

[ https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314555#comment-14314555 ] Terry Smith commented on LUCENE-6232: - [~mdrob] Thanks, either would work. Replace

[jira] [Commented] (LUCENE-5796) Scorer.getChildren() can throw or hide a subscorer for some boolean queries

[ https://issues.apache.org/jira/browse/LUCENE-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049941#comment-14049941 ] Terry Smith commented on LUCENE-5796: - Thanks for taking the time to review my patch

[jira] [Created] (LUCENE-5796) Scorer.getChildren() can throw or hide a subscorer for some boolean queries

Terry Smith created LUCENE-5796: --- Summary: Scorer.getChildren() can throw or hide a subscorer for some boolean queries Key: LUCENE-5796 URL: https://issues.apache.org/jira/browse/LUCENE-5796 Project:

[jira] [Updated] (LUCENE-5796) Scorer.getChildren() can throw or hide a subscorer for some boolean queries

[ https://issues.apache.org/jira/browse/LUCENE-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Smith updated LUCENE-5796: Attachment: LUCENE-5796.patch Scorer.getChildren() can throw or hide a subscorer for some