[jira] [Commented] (LUCENE-8511) MultiFields.getIndexedFields can be optimized to not use getMergedFieldInfos

2018-09-20 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622786#comment-16622786 ] Yonik Seeley commented on LUCENE-8511: -- Looks good, +1 to avoiding getMergedFieldInfos() here

Re: Solr add doc with overwrite=false and presence of UpdateLog

2018-09-20 Thread Yonik Seeley
On Thu, Sep 20, 2018 at 3:18 PM David Smiley wrote: > Is it even sensible to want overwrite=false and have an UpdateLog? That > is, isn't the weight of the UpdateLog well more than whatever savings are > had with overwrite=false? I suspect that the combinbing these two today > has edge cases

Re: Solr add doc with overwrite=false and presence of UpdateLog

2018-09-20 Thread Yonik Seeley
and adjust the test's > expectations. > +1 -Yonik > > On Thu, Sep 20, 2018 at 1:42 PM Yonik Seeley wrote: > >> Yep, It's only for performance. I know a number of people using >> overwrite=false when doing bulk indexing, and then often later using normal >> adds fo

Re: Solr add doc with overwrite=false and presence of UpdateLog

2018-09-20 Thread Yonik Seeley
Yep, It's only for performance. I know a number of people using overwrite=false when doing bulk indexing, and then often later using normal adds for incremental changes. As far as why "overwrite(Pending|Committed)?" exists at all: it's been there since Solr was open sourced (SOLR-1), so there

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611275#comment-16611275 ] Yonik Seeley commented on SOLR-11836: - limit:-1 should work fine for JSON Facets. bq. Also when I

[jira] [Commented] (SOLR-11598) Export Writer needs to support more than 4 Sort fields - Say 10, ideally it should not be bound at all, but 4 seems to really short sell the StreamRollup capabilities.

2018-07-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546851#comment-16546851 ] Yonik Seeley commented on SOLR-11598: - In general, we shouldn't have limits at all on stuff like

[jira] [Commented] (SOLR-12343) JSON Field Facet refinement can return incorrect counts/stats for sorted buckets

2018-07-09 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537904#comment-16537904 ] Yonik Seeley commented on SOLR-12343: - Looks good, thanks for tracking that down! > JSON Field Fa

[jira] [Commented] (SOLR-12343) JSON Field Facet refinement can return incorrect counts/stats for sorted buckets

2018-07-08 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536095#comment-16536095 ] Yonik Seeley commented on SOLR-12343: - I'm occasionally getting a failure

[jira] [Commented] (SOLR-12343) JSON Field Facet refinement can return incorrect counts/stats for sorted buckets

2018-07-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534377#comment-16534377 ] Yonik Seeley commented on SOLR-12343: - bq. it will stop returning the facet range "other&quo

[jira] [Assigned] (SOLR-12343) JSON Field Facet refinement can return incorrect counts/stats for sorted buckets

2018-07-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12343: --- Assignee: Yonik Seeley > JSON Field Facet refinement can return incorrect counts/st

[jira] [Resolved] (SOLR-12533) Collection creation fails if metrics are called during core creation

2018-07-03 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12533. - Resolution: Fixed Fix Version/s: 7.5 > Collection creation fails if metrics are cal

[jira] [Comment Edited] (LUCENE-8378) Add DocIdSetIterator.range method

2018-07-03 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532010#comment-16532010 ] Yonik Seeley edited comment on LUCENE-8378 at 7/3/18 10:18 PM: --- I assume

[jira] [Commented] (LUCENE-8378) Add DocIdSetIterator.range method

2018-07-03 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532010#comment-16532010 ] Yonik Seeley commented on LUCENE-8378: -- I assume it's a bug that minDoc is always returned? >

[jira] [Commented] (SOLR-12343) JSON Field Facet refinement can return incorrect counts/stats for sorted buckets

2018-07-02 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530657#comment-16530657 ] Yonik Seeley commented on SOLR-12343: - I think some of what I just worked on for SOLR-12326

[jira] [Commented] (SOLR-12533) Collection creation fails if metrics are called during core creation

2018-07-02 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530356#comment-16530356 ] Yonik Seeley commented on SOLR-12533: - These changes look good to me. I plan on committing after

[jira] [Resolved] (SOLR-12326) Unnecessary refinement requests

2018-06-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12326. - Resolution: Fixed Fix Version/s: 7.5 > Unnecessary refinement reque

[jira] [Assigned] (SOLR-12326) Unnecessary refinement requests

2018-06-28 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12326: --- Assignee: Yonik Seeley Attachment: SOLR-12326.patch Draft patch attached

[jira] [Commented] (SOLR-12326) Unnecessary refinement requests

2018-06-21 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519493#comment-16519493 ] Yonik Seeley commented on SOLR-12326: - One part of the solution is for the request merger to know

Re: Welcome Nhat Nguyen as Lucene/Solr committer

2018-06-18 Thread Yonik Seeley
Welcome, Nhat! -Yonik On Mon, Jun 18, 2018 at 4:41 PM, Adrien Grand wrote: > Hi all, > > Please join me in welcoming Nhat Nguyen as the latest Lucene/Solr committer. > Nhat, it's tradition for you to introduce yourself with a brief bio. > > Congratulations and Welcome! > > Adrien

[jira] [Commented] (LUCENE-8359) Extend ToParentBlockJoinQuery with 'minimum matched children' functionality

2018-06-15 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513889#comment-16513889 ] Yonik Seeley commented on LUCENE-8359: -- I haven't had a chance to look at the patch, but +1

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-06-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511238#comment-16511238 ] Yonik Seeley commented on SOLR-9685: bq. I'm confused about what's happening here as this was resolved

[jira] [Resolved] (SOLR-9685) tag a query in JSON syntax

2018-06-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-9685. Resolution: Fixed OK, I also modified a test to test for the {"#tag":{"lucene&quo

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-06-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509660#comment-16509660 ] Yonik Seeley commented on SOLR-9685: Attached draft patch to fix the issue of tagged queries on sub

[jira] [Updated] (SOLR-9685) tag a query in JSON syntax

2018-06-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-9685: --- Attachment: SOLR-9685.patch > tag a query in JSON syn

[jira] [Commented] (SOLR-11779) Basic long-term collection of aggregated metrics

2018-06-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509609#comment-16509609 ] Yonik Seeley commented on SOLR-11779: - I'd consider it a minor bug for our default configs

[jira] [Commented] (SOLR-11779) Basic long-term collection of aggregated metrics

2018-06-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509136#comment-16509136 ] Yonik Seeley commented on SOLR-11779: - I don't know if it's this issue or a related issue, but all

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-06-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509052#comment-16509052 ] Yonik Seeley commented on SOLR-9685: Stepping through with the debugger, it looks like

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-06-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509002#comment-16509002 ] Yonik Seeley commented on SOLR-9685: Here's one of the simplest examples of a query that fails

[jira] [Reopened] (SOLR-9685) tag a query in JSON syntax

2018-06-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reopened SOLR-9685: > tag a query in JSON syntax > -- > > Ke

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-06-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508753#comment-16508753 ] Yonik Seeley commented on SOLR-9685: Looks like escaping bugs when producing the local-params variant

Re: discuss: stop adding 'via' from CHANGES.txt entries (take two)

2018-06-06 Thread Yonik Seeley
I don't have much of an opinion about "via" one way or the other, however I think we should avoid using the mental model of authorship for CHANGES.txt. We've generally been listing people who made meaningful contributions to the patch, including sometimes the person who opened the issue for

[jira] [Commented] (SOLR-5211) updating parent as childless makes old children orphans

2018-06-03 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499542#comment-16499542 ] Yonik Seeley commented on SOLR-5211: If we check for \_root\_ in the index, everything could be back

[jira] [Commented] (SOLR-12366) Avoid SlowAtomicReader.getLiveDocs -- it's slow

2018-06-02 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499147#comment-16499147 ] Yonik Seeley commented on SOLR-12366: - Nice catch, this stuff has been broken forever! Looking back

[jira] [Commented] (SOLR-5211) updating parent as childless makes old children orphans

2018-06-02 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499072#comment-16499072 ] Yonik Seeley commented on SOLR-5211: bq. Or maybe your comment is how do we handle an existing index

[jira] [Commented] (SOLR-5211) updating parent as childless makes old children orphans

2018-06-01 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498627#comment-16498627 ] Yonik Seeley commented on SOLR-5211: It should be relatively trivial to know if the \_root\_ field

[jira] [Commented] (SOLR-12374) Add SolrCore.withSearcher(lambda accepting SolrIndexSearcher)

2018-05-30 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495231#comment-16495231 ] Yonik Seeley commented on SOLR-12374: - The CHANGES for 7.4 has: * SOLR-12374

[jira] [Assigned] (SOLR-12417) velocity response writer v.json should enforce valid function name

2018-05-29 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12417: --- Assignee: Yonik Seeley > velocity response writer v.json should enforce valid function n

[jira] [Updated] (SOLR-12417) velocity response writer v.json should enforce valid function name

2018-05-29 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12417: Attachment: SOLR-12417.patch > velocity response writer v.json should enforce valid function n

[jira] [Created] (SOLR-12417) velocity response writer v.json should enforce valid function name

2018-05-29 Thread Yonik Seeley (JIRA)
Yonik Seeley created SOLR-12417: --- Summary: velocity response writer v.json should enforce valid function name Key: SOLR-12417 URL: https://issues.apache.org/jira/browse/SOLR-12417 Project: Solr

[jira] [Resolved] (SOLR-12328) Adding graph json facet domain change

2018-05-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12328. - Resolution: Fixed Fix Version/s: 7.4 > Adding graph json facet domain cha

[jira] [Commented] (SOLR-12328) Adding graph json facet domain change

2018-05-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492204#comment-16492204 ] Yonik Seeley commented on SOLR-12328: - I fixed up the null traversal filter noted, consolidated

[jira] [Assigned] (SOLR-12328) Adding graph json facet domain change

2018-05-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12328: --- Assignee: Yonik Seeley > Adding graph json facet domain cha

[jira] [Created] (SOLR-12410) enable caching of domain-change queries

2018-05-27 Thread Yonik Seeley (JIRA)
Yonik Seeley created SOLR-12410: --- Summary: enable caching of domain-change queries Key: SOLR-12410 URL: https://issues.apache.org/jira/browse/SOLR-12410 Project: Solr Issue Type: Improvement

[jira] [Assigned] (SOLR-9685) tag a query in JSON syntax

2018-05-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-9685: -- Resolution: Fixed Assignee: Yonik Seeley (was: Mikhail Khludnev) Fix Version/s

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-05-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492028#comment-16492028 ] Yonik Seeley commented on SOLR-9685: Thans Dmitry, I'm reviewing now. > tag a query in JSON syn

Re: BadApple candidates

2018-05-25 Thread Yonik Seeley
I don't know what happened with TestStressRecovery, but IIRC it was not a flakey test and should have a 100% pass rate. This suggests a recent change introducing a bug (and demonstrates why historical pass rate is so important). It feels like rather than sweeping these under the rug, a JIRA

[jira] [Commented] (SOLR-12343) JSON Field Facet refinement can return incorrect counts/stats for sorted buckets

2018-05-18 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481366#comment-16481366 ] Yonik Seeley commented on SOLR-12343: - I think the most important thing here is that individual

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480089#comment-16480089 ] Yonik Seeley commented on SOLR-12338: - {quote}This is a very costly/risky logic to handle reordered

[jira] [Comment Edited] (SOLR-9685) tag a query in JSON syntax

2018-05-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479895#comment-16479895 ] Yonik Seeley edited comment on SOLR-9685 at 5/17/18 11:47 PM: -- Thanks Mikhail

[jira] [Commented] (SOLR-9685) tag a query in JSON syntax

2018-05-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479895#comment-16479895 ] Yonik Seeley commented on SOLR-9685: Thanks Mikhail, I like the syntax! .bq omitting leading

[jira] [Commented] (SOLR-12338) Replay buffering tlog in parallel

2018-05-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479675#comment-16479675 ] Yonik Seeley commented on SOLR-12338: - I haven't been following this issue, but the need to order

[jira] [Commented] (SOLR-11277) Add auto hard commit setting based on tlog size

2018-05-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479071#comment-16479071 ] Yonik Seeley commented on SOLR-11277: - bq. is this what you'd suggested?  Yes, that should handle

[jira] [Commented] (SOLR-11277) Add auto hard commit setting based on tlog size

2018-05-16 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478453#comment-16478453 ] Yonik Seeley commented on SOLR-11277: - Hmmm, and check for tlog == null as well inside

[jira] [Reopened] (SOLR-11277) Add auto hard commit setting based on tlog size

2018-05-16 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reopened SOLR-11277: - Assignee: (was: Anshum Gupta) I recently tried beasting TestStressVersions, and I got

[jira] [Commented] (SOLR-12352) Solr mod function query does not yield correct results

2018-05-14 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475093#comment-16475093 ] Yonik Seeley commented on SOLR-12352: - bq. Solr's functions operate on floats - maybe this problem

[jira] [Commented] (SOLR-12340) Solr 7 does not do a phrase search by default for certain queries.

2018-05-14 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474975#comment-16474975 ] Yonik Seeley commented on SOLR-12340: - Yes, this looks like an unfortunate change of behavior. I

[jira] [Assigned] (SOLR-12170) terms facet on a date field can fail

2018-05-09 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12170: --- Assignee: Yonik Seeley > terms facet on a date field can f

[jira] [Resolved] (SOLR-12170) terms facet on a date field can fail

2018-05-09 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12170. - Resolution: Fixed > terms facet on a date field can f

[jira] [Created] (SOLR-12326) Unnecessary refinement requests

2018-05-07 Thread Yonik Seeley (JIRA)
Yonik Seeley created SOLR-12326: --- Summary: Unnecessary refinement requests Key: SOLR-12326 URL: https://issues.apache.org/jira/browse/SOLR-12326 Project: Solr Issue Type: Bug Security

[jira] [Commented] (SOLR-12170) terms facet on a date field can fail

2018-05-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466162#comment-16466162 ] Yonik Seeley commented on SOLR-12170: - Attached draft patch that seems to fix the issues I've found so

[jira] [Updated] (SOLR-12170) terms facet on a date field can fail

2018-05-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12170: Attachment: SOLR-12170.patch > terms facet on a date field can f

[jira] [Comment Edited] (SOLR-10442) xtendedDismaxQParser (edismax) makes pf* require search term exactly

2018-04-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435619#comment-16435619 ] Yonik Seeley edited comment on SOLR-10442 at 4/12/18 1:59 PM: -- I was able

[jira] [Commented] (SOLR-10442) xtendedDismaxQParser (edismax) makes pf* require search term exactly

2018-04-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435619#comment-16435619 ] Yonik Seeley commented on SOLR-10442: - I was able to replicate the query structure you are seeing

[jira] [Resolved] (SOLR-12190) need to properly escape output in GraphMLResponseWriter

2018-04-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12190. - Resolution: Fixed Fix Version/s: master (8.0) 7.4 > need to prope

[jira] [Commented] (SOLR-12190) need to properly escape output in GraphMLResponseWriter

2018-04-06 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428633#comment-16428633 ] Yonik Seeley commented on SOLR-12190: - Here's a patch. It also fixes what looks like an issue

[jira] [Updated] (SOLR-12190) need to properly escape output in GraphMLResponseWriter

2018-04-06 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12190: Attachment: SOLR-12190.patch > need to properly escape output in GraphMLResponseWri

[jira] [Commented] (SOLR-12155) Solr 7.2.1 deadlock in UnInvertedField.getUnInvertedField()

2018-04-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427252#comment-16427252 ] Yonik Seeley commented on SOLR-12155: - If we wrap in a SolrException, we can specify the exact error

[jira] [Assigned] (SOLR-12190) need to properly escape output in GraphMLResponseWriter

2018-04-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12190: --- Assignee: Yonik Seeley > need to properly escape output in GraphMLResponseWri

[jira] [Created] (SOLR-12190) need to properly escape output in GraphMLResponseWriter

2018-04-05 Thread Yonik Seeley (JIRA)
Yonik Seeley created SOLR-12190: --- Summary: need to properly escape output in GraphMLResponseWriter Key: SOLR-12190 URL: https://issues.apache.org/jira/browse/SOLR-12190 Project: Solr Issue

[jira] [Commented] (SOLR-12155) Solr 7.2.1 deadlock in UnInvertedField.getUnInvertedField()

2018-04-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427026#comment-16427026 ] Yonik Seeley commented on SOLR-12155: - OK, so this will return null on failure instead of retrying

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

2018-04-03 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424851#comment-16424851 ] Yonik Seeley commented on LUCENE-7976: -- bq. I further propose that this be an optional argument

Re: Welcome Cao Mạnh Đạt to the PMC

2018-04-02 Thread Yonik Seeley
Congrats, Đạt! -Yonik On Mon, Apr 2, 2018 at 3:50 PM, Adrien Grand wrote: > Fixing the subject of the email. > > Le lun. 2 avr. 2018 à 21:48, Adrien Grand a écrit : >> >> I am pleased to announce that Cao Mạnh Đạt has accepted the PMC's >> invitation to

Re: [VOTE] Release Lucene/Solr 7.3.0 RC2

2018-04-02 Thread Yonik Seeley
+1 -Yonik On Wed, Mar 28, 2018 at 1:11 PM, Alan Woodward wrote: > Please vote for release candidate 2 for Lucene/Solr 7.3.0 > > The artefacts can be downloaded from: >

[jira] [Created] (SOLR-12170) terms facet on a date field can fail

2018-03-30 Thread Yonik Seeley (JIRA)
Yonik Seeley created SOLR-12170: --- Summary: terms facet on a date field can fail Key: SOLR-12170 URL: https://issues.apache.org/jira/browse/SOLR-12170 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-03-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411638#comment-16411638 ] Yonik Seeley commented on SOLR-12020: - Thanks for the extra info! I haven't been able to reproduce

[jira] [Updated] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-03-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12020: Attachment: SOLR-12020_test.patch > terms faceting on date field fails in distributed refinem

Re: Solr JSON.Facet range over function values

2018-03-22 Thread Yonik Seeley
On Thu, Mar 22, 2018 at 2:47 PM, Mikhail Khludnev wrote: > Hello, > > What do you think about extending JSON.Range facet with "func" parameter? Yep, it's been on my roadmap... not sure if an explicit JIRA has been opened though. It's related to code to lookup by document (using

[jira] [Commented] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-03-19 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405067#comment-16405067 ] Yonik Seeley commented on SOLR-12020: - bq. Maybe JSONWriter.write should know about Date & Instant

[jira] [Resolved] (SOLR-12064) NullPointerException in JSON facet

2018-03-14 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12064. - Resolution: Fixed Fix Version/s: 7.3 > NullPointerException in JSON fa

[jira] [Commented] (SOLR-12064) NullPointerException in JSON facet

2018-03-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390554#comment-16390554 ] Yonik Seeley commented on SOLR-12064: - Yeah, I'll try to get to it tomorrow. > NullPointerExcept

[jira] [Commented] (SOLR-12064) NullPointerException in JSON facet

2018-03-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390466#comment-16390466 ] Yonik Seeley commented on SOLR-12064: - Thanks Karthik, good catch with the test case! I can see other

[jira] [Assigned] (SOLR-12064) NullPointerException in JSON facet

2018-03-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12064: --- Assignee: Yonik Seeley > NullPointerException in JSON fa

[jira] [Updated] (SOLR-12064) NullPointerException in JSON facet

2018-03-07 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12064: Issue Type: Bug (was: Improvement) > NullPointerException in JSON fa

Re: [1/2] lucene-solr:master: SOLR-12020: Remove unused import

2018-03-06 Thread Yonik Seeley
Whoops, thanks Tomas! -Yonik On Mon, Mar 5, 2018 at 8:01 PM, wrote: > Repository: lucene-solr > Updated Branches: > refs/heads/master fc2fd1dc2 -> c1a44251f > > > SOLR-12020: Remove unused import - To

[jira] [Resolved] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-03-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-12020. - Resolution: Fixed Fix Version/s: 7.3 > terms faceting on date field fails in distribu

[jira] [Comment Edited] (SOLR-12037) Reduce noise from flakey tests

2018-03-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377995#comment-16377995 ] Yonik Seeley edited comment on SOLR-12037 at 3/5/18 5:32 PM: - Rolling up

[jira] [Commented] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-03-02 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384313#comment-16384313 ] Yonik Seeley commented on SOLR-12020: - Attached a patch to fix. The issue was that JSON is used

[jira] [Updated] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-03-02 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12020: Attachment: SOLR-12020.patch > terms faceting on date field fails in distributed refinem

[jira] [Commented] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-02-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374740#comment-16374740 ] Yonik Seeley commented on SOLR-12020: - Attached failing test, currently working on a fix. > te

[jira] [Updated] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-02-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12020: Attachment: SOLR-12020.patch > terms faceting on date field fails in distributed refinem

[jira] [Updated] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-02-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12020: Affects Version/s: 6.6 > terms faceting on date field fails in distributed refinem

[jira] [Updated] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-02-23 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley updated SOLR-12020: Description: This appears to be a regression, as the reporter indicates that Solr 6.2 worked

[jira] [Assigned] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-02-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley reassigned SOLR-12020: --- Assignee: Yonik Seeley > terms faceting on date field fails in distributed refinem

[jira] [Created] (SOLR-12020) terms faceting on date field fails in distributed refinement

2018-02-22 Thread Yonik Seeley (JIRA)
Yonik Seeley created SOLR-12020: --- Summary: terms faceting on date field fails in distributed refinement Key: SOLR-12020 URL: https://issues.apache.org/jira/browse/SOLR-12020 Project: Solr

[jira] [Commented] (SOLR-12016) Reduce noise from flakey tests

2018-02-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373292#comment-16373292 ] Yonik Seeley commented on SOLR-12016: - bq. Also, I expect to add the annotation to some more tests

Re: Test failures are out of control......

2018-02-22 Thread Yonik Seeley
On Thu, Feb 22, 2018 at 8:59 AM, Adrien Grand wrote: > I understand your point Yonik, but the practical consequences are worse I think that's what we were debating though. IMO, the overall practical consequences of simply sweeping the problem under the rug by disabling all

Re: Test failures are out of control......

2018-02-21 Thread Yonik Seeley
On Wed, Feb 21, 2018 at 6:13 PM, Uwe Schindler wrote: >> > There are exactly three >> > BadApple annotations in the entire code base at present, is there >> > enough value in introducing another annotation to make it worthwhile? >> >> If we change BadApple tests to be executed

Re: Test failures are out of control......

2018-02-21 Thread Yonik Seeley
On Wed, Feb 21, 2018 at 5:52 PM, Erick Erickson wrote: > There are exactly three > BadApple annotations in the entire code base at present, is there > enough value in introducing another annotation to make it worthwhile? If we change BadApple tests to be executed by

Re: Test failures are out of control......

2018-02-21 Thread Yonik Seeley
On Wed, Feb 21, 2018 at 3:26 PM, Erick Erickson wrote: > Yonik: > > What I'm frustrated by now is that variations on these themes haven't > cured the problem, and it's spun out of control and is getting worse. I understand, but what problem(s) are you trying to solve?

Re: Test failures are out of control......

2018-02-21 Thread Yonik Seeley
We should be careful not to conflate running of unit tests with automated reporting, and the differing roles that flakey tests play in different scenarios. For example, I no longer pay attention to automated failure reports, esp if I haven't committed anything recently. However, when I'm making

<    1   2   3   4   5   6   7   8   9   10   >