Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/313
This looks good. I'm running through all tests now but I don't expect any
issues to come up. Before I merge this in, would you mind rebasing off current
master and collapsing this
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/313
I think following the structure in `LiveNodesListener` makes more sense.
Perhaps a name of `CloudCollectionsSetListener` or `CloudCollectionsListener
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/313
Overall I think this is a good idea.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/313#discussion_r176611998
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/CollectionSetWatcher.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/313#discussion_r176611511
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/CollectionSetWatcher.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/225
It appears that
solr/contrib/analytics/src/java/org/apache/solr/analytics/plugin/AnalyticsStatisticsCollector.java
can just be deleted. Can you clean this conflict up
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/215
This all looks good to me so far
`%> ant precommit` passes
`%> ant test` passes
Houston is working on a new batch of tests that will specifically test the
new ana
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/215
Where are point fields specifically handled, or do they not need to be
specifically handled like other Trie fields?
---
If your project is set up for it, you can reply to this email and
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/171
Sounds good to me. I like the work that was done here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r111227848
--- Diff: solr/core/src/java/org/apache/solr/handler/StreamHandler.java ---
@@ -191,7 +237,20 @@ public void inform(SolrCore core
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r110244491
--- Diff: solr/core/src/java/org/apache/solr/handler/StreamHandler.java ---
@@ -191,7 +237,20 @@ public void inform(SolrCore core
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/171
I noticed that
solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DatePartEvaluator.java
is still part of the PR. Is that intentional?
---
If your project is set up for it, you can
Github user dennisgove commented on the issue:
https://github.com/apache/lucene-solr/pull/171
I think this all looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r110127292
--- Diff: solr/core/src/java/org/apache/solr/handler/StreamHandler.java ---
@@ -199,10 +200,16 @@ public void inform(SolrCore core
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r107802207
--- Diff: solr/core/src/java/org/apache/solr/handler/StreamHandler.java ---
@@ -199,10 +200,16 @@ public void inform(SolrCore core
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r107804393
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DatePartEvaluator.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r107805373
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DatePartEvaluator.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/171#discussion_r107804517
--- Diff:
solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DatePartEvaluator.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the
Github user dennisgove commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/126#discussion_r103494004
--- Diff: solr/core/src/java/org/apache/solr/search/facet/SlotAcc.java ---
@@ -394,7 +394,16 @@ public CountSlotAcc(FacetContext fcontext
19 matches
Mail list logo
