[GitHub] lucene-solr issue #268: Fix some spell check issues

2017-10-30 Thread iorixxx
Github user iorixxx commented on the issue: https://github.com/apache/lucene-solr/pull/268 *TokenizerImpl.java files have corresponding *.jflex files in the source tree. Do you mind fixing typos in *.jflex files? I think the ant target `ant jflex` in `lucene/analysis/common/` is used

[GitHub] lucene-solr pull request:

2016-02-04 Thread iorixxx
Github user iorixxx commented on the pull request: https://github.com/apache/lucene-solr/commit/a48ba5090beafc725ab04e67996e42f0b3f31348#commitcomment-15893108 Thanks @mikemccand , I located the other places you mentioned, I will create an jira issue tomorrow for this. --- If your

[GitHub] lucene-solr pull request:

2016-02-02 Thread iorixxx
Github user iorixxx commented on the pull request: https://github.com/apache/lucene-solr/commit/a48ba5090beafc725ab04e67996e42f0b3f31348#commitcomment-15838444 Wouldn’t it be nice to use `TimeUnit.MILLISECONDS.convert(System.nanoTime() - t0, TimeUnit.NANOSECONDS)` here