[GitHub] lucene-solr pull request: SOLR-7501 fix timing bugs in map-reduce ...

2015-05-05 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/lucene-solr/pull/146#issuecomment-99179940 Can we just use TimeUnit to do all of the conversions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-31 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22387405 --- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java --- @@ -861,23 +877,107 @@ protected void compareResponses

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-31 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22384247 --- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java --- @@ -269,20 +285,20 @@ public Object val() { public

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-31 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22384210 --- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java --- @@ -861,23 +877,107 @@ protected void compareResponses

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362948 --- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java --- @@ -173,16 +179,25 @@ protected

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362862 --- Diff: solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java --- @@ -506,14 +506,14 @@ public boolean checkRetry

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362769 --- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java --- @@ -861,23 +869,107 @@ protected void compareResponses

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362512 --- Diff: solr/core/src/test/org/apache/solr/cloud/TestDistribDocBasedVersion.java --- @@ -350,8 +348,8 @@ void doDBQ(String q, String... reqParams

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362519 --- Diff: solr/core/src/test/org/apache/solr/cloud/TriLevelCompositeIdRoutingTest.java --- @@ -155,8 +153,8 @@ private String getKey(String id

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362487 --- Diff: solr/core/src/test/org/apache/solr/cloud/ShardRoutingTest.java --- @@ -351,8 +334,8 @@ void doDBQ(String q, String... reqParams) throws

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362427 --- Diff: solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java --- @@ -77,7 +75,7 @@ public void tearDown() throws Exception { if

[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...

2014-12-30 Thread madrob
Github user madrob commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/121#discussion_r22362409 --- Diff: solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java --- @@ -71,7 +68,7 @@ public void tearDown() throws Exception { if