[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-17 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512228939 > I ran luceneutil on this patch on my machine too and I'm getting similar results. It's a bit disappointing, I was expecting

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-17 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512220733 luceneutil run: https://gist.github.com/atris/1b2c25021ca11138338aa73efde2aa38 wikimedium2m

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-17 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512198512 @jpountz Updated the PR with lazy loading. Please let me know if it looks fine --

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-17 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-51216 Ah, yes, that makes sense. I did a couple of more runs with 10m docs and saw similar results. Will update the PR -

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-16 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511874550 @jpountz Three Luceneutil runs with wikimedium2m: https://gist.github.com/atris/5057e3372b287873a4e840c5f4e65a0d http

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-16 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511813095 @jpountz I have fixed your comments, please let me know if they look fine. luceneutil is running right now with 10k docu

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-15 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511408229 Any thoughts on this one? I am hoping this will bring gains to our nightly benchmarks :)

[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq

2019-07-11 Thread GitBox
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-510768788 cc: @jpountz This is an automated message from the Apache Gi