[GitHub] [lucene-solr] iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-10 Thread GitBox
iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#issuecomment-529880803 @jpountz thanks! Yes, the random test seems to hit all the possible combinations so I think we are g

[GitHub] [lucene-solr] iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-06 Thread GitBox
iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#issuecomment-528770584 I have run the performance benchmark defined [here](https://github.com/mikemccand/luceneutil/pull/44

[GitHub] [lucene-solr] iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries

2019-09-05 Thread GitBox
iverase commented on issue #857: LUCENE-8968: Improve performance of WITHIN and DISJOINT queries for Shape queries URL: https://github.com/apache/lucene-solr/pull/857#issuecomment-528425823 Thanks @jpountz , I agree we should not be keeping a state in the visitor. I updated the PR going ba