[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names

2019-05-30 Thread GitBox
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496878927 Hi @uschindler, this PR passed all tests & precommit. If the changes in

[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names

2019-05-26 Thread GitBox
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496000812 Just a quick note: A few times I nearly committed the `__pycache__` directory, so I

[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names

2019-05-24 Thread GitBox
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I

[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names

2019-05-24 Thread GitBox
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I

[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names

2019-05-24 Thread GitBox
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I