thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-529799183
@gerlowskija ready to merge?
This is an automated message from the Apache Git Service.
To re
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-527779102
Removed JavaDoc reference to EmbeddedSolrServer as suggested by @dsmiley
This is an automat
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-527455888
> > As i already mentioned on #755, any plans on merging this back to 8.x?
>
> Yep. Generally committers are encouraged to let things "cook" on master
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-526961393
Test is failing also before this commit, in both build environments ant,
eclipse on my development host, so i ignored it locally. Does not seem to be
relate
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-526877311
One test is failing, testUserAndTestDefaultConfigsetsAreSame from
TestConfigSetsAPI, have to investigate if it fails before or not
-
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-526873168
As i already mentioned on #755, any plans on merging this back to 8.x?
This is an automated
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-518040563
So please, i put a lot of work into this, it would be really great if
somebody could help to review and get this into the main line at least!
--
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-516759833
Last interaction is now one month ago, so can anyone takeover the review
please?
This is an
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-515045605
> I was able to clean up some of the failures locally by removing the second
clause in the if-statement below. (This was added in this PR in
EmbeddedSolrSer
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-513734056
Rebased again, @gerlowskija it is two weeks ago since last notice, maybe
someone else could takeover the review if jason is to busy?
---
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-512198034
@gerlowskija Are you still working on this?
This is an automated message from the Apache Git
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-511391449
Still nothing?
This is an automated message from the Apache Git Service.
To respond to the m
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-509148931
Anything new?
This is an automated message from the Apache Git Service.
To respond to the me
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507547948
Rebased against PR #755, resolved conflicts, tests are all running, ready to
merge after #755 is merged
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507443102
> Ok. I was worried we'd miss 8.1.2, so I took your changes to
AbstractEnumField, BinaryField, BoolField, and UUIDField and merged them in a
much smaller co
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507243090
> I was able to clean up some of the failures locally by removing the second
clause in the if-statement below. (This was added in this PR in
EmbeddedSolrSer
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-506257792
Already had time to review?
This is an automated message from the Apache Git Service.
To res
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-504697943
> Hey Thomas, the code compiles and passes `precommit` now, which is a good
step, but it looks like there are some test failures that this PR introduces.
It
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-502588814
Any comments on this?
This is an automated message from the Apache Git Service.
To respond t
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-501590607
Rebased and ready to review
This is an automated message from the Apache Git Service.
To res
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-501586703
> PR looks good to me. Sorry for my tardiness in reviewing it.
>
> I have some qualms about introducing a new test base class entirely as
this PR does
21 matches
Mail list logo
