jpountz commented on a change in pull request #574: LUCENE-8292: Make TermsEnum
fully abstract
URL: https://github.com/apache/lucene-solr/pull/574#discussion_r257244063
##########
File path: lucene/core/src/java/org/apache/lucene/index/TermsEnum.java
##########
@@ -271,4 +246,50 @@ public void seekExact(BytesRef term, TermState state) {
}
};
+
+ /**
+ * A base TermsEnum that adds default implementations for
+ * <ul>
+ * <li>{@link #attributes()}</li>
+ * <li>{@link #termState()}</li>
+ * <li>{@link #seekExact(BytesRef)}</li>
+ * <li>{@link #seekExact(BytesRef, TermState)}</li>
+ * </ul>
+ *
+ * In some cases, the default implementation may be slow and consume huge
memory, so subclass SHOULD have its own
+ * implementation if possible.
+ */
+ public static abstract class BaseTermsEnum extends TermsEnum {
Review comment:
move to its own file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
