[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-25 Thread hgadre
Github user hgadre commented on the issue: https://github.com/apache/lucene-solr/pull/140 @janhoy Now that we have proper support for configuring basic auth credentials, we should also consider deprecating following logic,

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-25 Thread hgadre
Github user hgadre commented on the issue: https://github.com/apache/lucene-solr/pull/140 @janhoy Done! Please take a look and let me know your feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-25 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/140 I like it even better :) Let's add a comment to solr.in.sh that you can **either** specify `SOLR_AUTHENTICATION_CLIENT_BUILDER` or `SOLR_AUTH_TYPE`, and perhaps give a reference to the RefGuide

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-23 Thread hgadre
Github user hgadre commented on the issue: https://github.com/apache/lucene-solr/pull/140 @janhoy I found it difficult to add command-line parameters without extensive refactoring of scripts. Hence as an intermediate solution - I have defined an environment variable SOLR_AUTH_TYPE

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-23 Thread hgadre
Github user hgadre commented on the issue: https://github.com/apache/lucene-solr/pull/140 @janhoy I think adding --use-basic-auth would be future proof as we add newer authentication mechanisms. We can add --use-kerberos as well for completeness. Let me take a look and update the

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-20 Thread janhoy
Github user janhoy commented on the issue: https://github.com/apache/lucene-solr/pull/140 I like the --use-basic-auth convenience, or should we defailt to basic if no builder is specified (like it kind of is today)? --- If your project is set up for it, you can reply to this email

[GitHub] lucene-solr issue #140: [SOLR-9997] Enable configuring SolrHttpClientBuilder...

2017-01-19 Thread hgadre
Github user hgadre commented on the issue: https://github.com/apache/lucene-solr/pull/140 @janhoy Thanks for the review. We will need to update ref guide with instructions for configuring SolrCLI against the secure SOLR cluster. e.g. with the basic auth plugin, following env variable