Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Ant `precommit` task and Lucene test are all green.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thanks @jimczi, I'll rerun all Lucene tests to ensure nothing is broken and
I'll let you know.
---
-
To unsubscribe,
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Lucene tests are all green on my side, I'll launch Solr ones later this day.
I'm not at ease with these two changes
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
I'll default the score mode to `ScoreMode.TOP_SCORES` in all 45 constructor
callers. And then, I'll try to change it to a more sensible value based on the
caller context.
---
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thank you @jimczi.
I've added parametrized tests with phrase and term queries to check the two
constructors of the `ConstantScoreScorer` class.
And I also came back to your
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
I think I've understood my mistake and it should be fixed now.
I've added a random condition in tests to check the second
`ConstantScoreScorer` constructor. Even though tests pass, I'm
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Hi @jimczi, PR is up-to-date and ready for review. All Lucene tests are
green on my side.
As you'll see, I'd like to suggest a slightly different implementation to
keep
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Well you're right, without a static wrapper (see
19e156cedd343b27214538aec58f24e1d66105da) I can't assign approximation to
`DocIdSetIterator.empty()` after setting `minCompetitiveScore`.
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Great! Exactly what I did except declaring a static inner class, Iâll
declare it :+1: thanks!
---
-
To unsubscribe,
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Please ignore my previous comment as some tests are broken when the scorer
has an approximation (see
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thanks a lot @jimczi, I've understood my mistakes :+1: PR is ready for
review.
---
-
To unsubscribe, e-mail:
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
Thanks a lot @jimczi for the very quick and very helpful review, I've made
changes to improve this PR.
---
-
To
Github user cbismuth commented on the issue:
https://github.com/apache/lucene-solr/pull/495
@jpountz PR is ready for review, thank you.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional
13 matches
Mail list logo
