Github user andyetitmoves closed the pull request at:
https://github.com/apache/lucene-solr/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22387405
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -861,23 +877,107 @@ protected void compareResponses(Quer
Github user andyetitmoves commented on the pull request:
https://github.com/apache/lucene-solr/pull/121#issuecomment-68452527
Currently `ShardsFixed` has to be a per-test-method annotation, I would
personally prefer if each test took that decision independently (of how it's
shard setu
Github user andyetitmoves commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22387051
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -269,20 +285,20 @@ public Object val() {
p
Github user andyetitmoves commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22386987
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -861,23 +877,107 @@ protected void compareRespons
Github user andyetitmoves commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22386755
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -861,23 +877,107 @@ protected void compareRespons
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22384247
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -269,20 +285,20 @@ public Object val() {
public S
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22384210
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -861,23 +877,107 @@ protected void compareResponses(Quer
Github user andyetitmoves commented on the pull request:
https://github.com/apache/lucene-solr/pull/121#issuecomment-68439138
Thanks for the comments @madrob, I have updated with some revisions.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362948
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -173,16 +179,25 @@ protected BaseDistributedSearchTestCa
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362862
--- Diff:
solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java ---
@@ -506,14 +506,14 @@ public boolean checkRetry() {
}
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362769
--- Diff:
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
---
@@ -861,23 +869,107 @@ protected void compareResponses(Quer
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362512
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestDistribDocBasedVersion.java ---
@@ -350,8 +348,8 @@ void doDBQ(String q, String... reqParams) throw
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362519
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TriLevelCompositeIdRoutingTest.java ---
@@ -155,8 +153,8 @@ private String getKey(String id) {
}
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362487
--- Diff: solr/core/src/test/org/apache/solr/cloud/ShardRoutingTest.java ---
@@ -351,8 +334,8 @@ void doDBQ(String q, String... reqParams) throws
Exceptio
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362427
--- Diff: solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java
---
@@ -77,7 +75,7 @@ public void tearDown() throws Exception {
if (c
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362409
--- Diff: solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java ---
@@ -71,7 +68,7 @@ public void tearDown() throws Exception {
if (contro
GitHub user andyetitmoves opened a pull request:
https://github.com/apache/lucene-solr/pull/121
Use JUnit rules instead of inheritance with distributed Solr tests to allow
for multiple tests without the same class
Patch for SOLR-6902
You can merge this pull request into a Git repos
18 matches
Mail list logo
