Github user Timothy055 closed the pull request at:
https://github.com/apache/lucene-solr/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85619786
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField() {
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85618489
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed t
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85616894
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7 @@ p
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85616651
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7 @@ p
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85614277
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7 @@ p
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85613814
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField() {
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85613130
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField() {
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85612011
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/AnalysisOffsetStrategy.java
---
@@ -17,174 +17,28 @@
package org.apach
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85611978
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed t
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85611673
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed t
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85606885
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/Passage.java ---
@@ -40,7 +40,7 @@
BytesRef matchTerms[] = new BytesRe
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85607859
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
---
@@ -116,6 +116,8 @@
private boolean d
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85603812
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to t
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85608645
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7 @@ publ
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85607262
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/TokenStreamOffsetStrategy.java
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed t
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85602404
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to t
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85602867
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to t
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85602210
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/AnalysisOffsetStrategy.java
---
@@ -17,174 +17,28 @@
package org.apache.l
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85603003
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to t
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85606333
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField() {
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85604667
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to t
GitHub user Timothy055 opened a pull request:
https://github.com/apache/lucene-solr/pull/105
LUCENE-7526 Improvements to UnifiedHighlighter OffsetStrategies
Pull request for LUCENE-7526
You can merge this pull request into a Git repository by running:
$ git pull https://github.
23 matches
Mail list logo