[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-10 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66629876 --- Diff: solr/contrib/hdfs/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java --- @@ -91,6 +91,9 @@ public static MiniDFSCluster setupClass(String

[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-08 Thread tomjon
Github user tomjon commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66273240 --- Diff: solr/core/src/test/org/apache/solr/cloud/ShardSplitTest.java --- @@ -57,7 +57,6 @@ import static org.apache.solr.common.cloud.ZkStateReader.

[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-08 Thread tomjon
Github user tomjon commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66272908 --- Diff: solr/core/src/java/org/apache/solr/update/UpdateHandler.java --- @@ -200,4 +187,16 @@ public void registerOptimizeCallback( SolrEventListener lis

[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-08 Thread tomjon
Github user tomjon commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66249148 --- Diff: solr/core/ivy.xml --- @@ -61,15 +61,6 @@ - - - - - --- End diff --

[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-08 Thread tomjon
Github user tomjon commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66247316 --- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java --- @@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src, String dest

[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-08 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66244801 --- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java --- @@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src, String

[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

2016-06-08 Thread tomjon
Github user tomjon commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/34#discussion_r66244222 --- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java --- @@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src, String dest