[
https://issues.apache.org/jira/browse/SOLR-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718118#comment-16718118
]
Gus Heck edited comment on SOLR-13051 at 12/11/18 11:02 PM:
------------------------------------------------------------
Beasted this for 8 hours (3000 runs), and found 9 failures. 1 was SOLR-13058,
one was an NPE in the test method that was supposed to be waiting for a
collection to appear in the alias:
{code:java}
[junit4] ERROR 71.9s |
TimeRoutedAliasUpdateProcessorTest.testPreemptiveCreation <<<
[junit4] > Throwable #1: java.lang.NullPointerException
[junit4] > at
__randomizedtesting.SeedInfo.seed([D4AAABF6F467FC62:B9C02E5DCC051156]:0)
[junit4] > at
org.apache.solr.update.processor.TimeRoutedAliasUpdateProcessorTest.waitColAndAlias(TimeRoutedAliasUpdateProcessorTest.java:712)
[junit4] > at
org.apache.solr.update.processor.TimeRoutedAliasUpdateProcessorTest.testPreemptiveCreation(TimeRoutedAliasUpdateProcessorTest.java:439)
[junit4] > at java.lang.Thread.run(Thread.java:748)
{code}
Unfortunately the line for this has several points at which the null pointer
could have occurred, so I'll break that line into individual method calls that
will make tracking this down easier if it shows up again.
The rest (7) were cases where even though we waited for the collection somehow
the next request couldn't find it.
{code:java}
[junit4] ERROR 11.2s | TimeRoutedAliasUpdateProcessorTest.testSliceRouting <<<
[junit4] > Throwable #1:
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteExecutionException:
Error from server at http://127.0.0.1:32891/solr: no core retrieved for
testSliceRouting
[junit4] > at
__randomizedtesting.SeedInfo.seed([D9B32625DD304967:E823AAC97966B64E]:0)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteExecutionException.create(HttpSolrClient.java:829)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:620)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:255)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:244)
[junit4] > at
org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:484)
[junit4] > at
org.apache.solr.client.solrj.impl.LBHttpSolrClient.request(LBHttpSolrClient.java:414)
[junit4] > at
org.apache.solr.client.solrj.impl.CloudSolrClient.sendRequest(CloudSolrClient.java:1110)
{code}
This appeared 4 times for testSliceRouting and 3 times for
testPreemptiveCreation, so it's a general failure not related to the feature
that caused AwaitsFix.
With a 3 per 1000 fail rate I'm going to update the patch to retain the
@BadApple annotation until these can be tracked down in SOLR-13059.
was (Author: gus_heck):
Beasted this for 8 hours (3000 runs), and found 9 failures. 1 was SOLR-13058,
one was an NPE in the test method that was supposed to be waiting for a
collection to appear in the alias:
{code:java}
[junit4] ERROR 71.9s |
TimeRoutedAliasUpdateProcessorTest.testPreemptiveCreation <<<
[junit4] > Throwable #1: java.lang.NullPointerException
[junit4] > at
__randomizedtesting.SeedInfo.seed([D4AAABF6F467FC62:B9C02E5DCC051156]:0)
[junit4] > at
org.apache.solr.update.processor.TimeRoutedAliasUpdateProcessorTest.waitColAndAlias(TimeRoutedAliasUpdateProcessorTest.java:712)
[junit4] > at
org.apache.solr.update.processor.TimeRoutedAliasUpdateProcessorTest.testPreemptiveCreation(TimeRoutedAliasUpdateProcessorTest.java:439)
[junit4] > at java.lang.Thread.run(Thread.java:748)
{code}
Unfortunately the line for this has several points at which the null pointer
could have occurred, so I'll break that line into individual method calls that
will make tracking this down easier if it shows up again.
The rest (7) were cases where even though we waited for the collection somehow
the next request couldn't find it.
{code:java}
[junit4] ERROR 11.2s | TimeRoutedAliasUpdateProcessorTest.testSliceRouting <<<
[junit4] > Throwable #1:
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteExecutionException:
Error from server at http://127.0.0.1:32891/solr: no core retrieved for
testSliceRouting
[junit4] > at
__randomizedtesting.SeedInfo.seed([D9B32625DD304967:E823AAC97966B64E]:0)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteExecutionException.create(HttpSolrClient.java:829)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:620)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:255)
[junit4] > at
org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:244)
[junit4] > at
org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:484)
[junit4] > at
org.apache.solr.client.solrj.impl.LBHttpSolrClient.request(LBHttpSolrClient.java:414)
[junit4] > at
org.apache.solr.client.solrj.impl.CloudSolrClient.sendRequest(CloudSolrClient.java:1110)
{code}
This appeared 4 times for testSliceRouting and 3 times for
testPreemptiveCreation, so it's a general failure not related to the feature
that caused AwaitsFix.
With a 3 per 1000 fail rate I'm going to update the patch to retain the
@BadApple annotation until these can be tracked down.
> Improve TimeRoutedAlias preemptive create to play nice with tests
> -----------------------------------------------------------------
>
> Key: SOLR-13051
> URL: https://issues.apache.org/jira/browse/SOLR-13051
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Affects Versions: master (8.0), 7.7
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Minor
> Attachments: SOLR-13051.patch
>
>
> SOLR-12801 added AwaitsFix to TimeRoutedAliasUpdateProcessorTest. This
> ticket will fix the test to not require a sleep statement and remove the
> AwaitsFix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
