[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-22 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155094#comment-13155094 ] Uwe Schindler commented on LUCENE-3464: --- I will add a comment to the javadocs with

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154468#comment-13154468 ] Robert Muir commented on LUCENE-3464: - And just again: I want to point out this is th

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154463#comment-13154463 ] Robert Muir commented on LUCENE-3464: - {quote} Not in your proof of concept. And this

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154456#comment-13154456 ] Uwe Schindler commented on LUCENE-3464: --- bq. As I said before, this is simple, FIR

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154449#comment-13154449 ] Robert Muir commented on LUCENE-3464: - As I said before, this is simple, FIR's impl o

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154448#comment-13154448 ] Uwe Schindler commented on LUCENE-3464: --- Robert: If you wrap a standard SegmentRead

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154445#comment-13154445 ] Uwe Schindler commented on LUCENE-3464: --- Robert read my comment about the reason wh

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1315#comment-1315 ] Robert Muir commented on LUCENE-3464: - In my patch FIR returns whatever the underlyin

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154441#comment-13154441 ] Robert Muir commented on LUCENE-3464: - Uwe, see my patch, it uses its own sophisticat

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154442#comment-13154442 ] Uwe Schindler commented on LUCENE-3464: --- bq. Thats no problem, it just calls super.

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154440#comment-13154440 ] Uwe Schindler commented on LUCENE-3464: --- This code does not compile (fails by sayin

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154437#comment-13154437 ] Simon Willnauer commented on LUCENE-3464: - bq. I don't understand this statement,

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-11-21 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154434#comment-13154434 ] Robert Muir commented on LUCENE-3464: - {quote} The problem: This cannot be implemente

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-10-04 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120014#comment-13120014 ] Uwe Schindler commented on LUCENE-3464: --- This sophisticated backwards seems fine.

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Ryan McKinley (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115030#comment-13115030 ] Ryan McKinley commented on LUCENE-3464: --- bq. the method implies that the reopen wil

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114795#comment-13114795 ] Michael McCandless commented on LUCENE-3464: Another trappiness I've seen on

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114760#comment-13114760 ] Michael McCandless commented on LUCENE-3464: bq. Can we just make it final wh

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114748#comment-13114748 ] Michael McCandless commented on LUCENE-3464: I like reopenIfChanged too! bq.

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114667#comment-13114667 ] Uwe Schindler commented on LUCENE-3464: --- We can even do the change in 3.x, if we ke

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114662#comment-13114662 ] Ryan McKinley commented on LUCENE-3464: --- maybe: reopenIfChanged() reopenOnChange

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Doron Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114656#comment-13114656 ] Doron Cohen commented on LUCENE-3464: - I liked reopen()... (but also like returning n

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114521#comment-13114521 ] Martijn van Groningen commented on LUCENE-3464: --- +1 reopenOnChange() Names

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-26 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114492#comment-13114492 ] Simon Willnauer commented on LUCENE-3464: - just a couple of variants: tryReopen(

[jira] [Commented] (LUCENE-3464) Rename IndexReader.reopen to make it clear that reopen may not happen

2011-09-25 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114354#comment-13114354 ] Mark Miller commented on LUCENE-3464: - bq. reopenIfNeeded +1 - can't think of anythi