[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-27 Thread Yonik Seeley (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136953#comment-13136953 ] Yonik Seeley commented on LUCENE-3506: -- Thanks Doron, that works! >

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-27 Thread Doron Cohen (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136915#comment-13136915 ] Doron Cohen commented on LUCENE-3506: - For easier perf testing I added a -D flag to t

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Doron Cohen (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136826#comment-13136826 ] Doron Cohen commented on LUCENE-3506: - {quote} bq.Also, we've often done performance

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Doron Cohen (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136823#comment-13136823 ] Doron Cohen commented on LUCENE-3506: - bq. I just committed this change to the Intell

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Steven Rowe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136573#comment-13136573 ] Steven Rowe commented on LUCENE-3506: - bq. IJ has a default setup for "JUnit" executi

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135963#comment-13135963 ] Dawid Weiss commented on LUCENE-3506: - You can also enable assertions just for the cl

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Erik Hatcher (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135932#comment-13135932 ] Erik Hatcher commented on LUCENE-3506: -- IJ has a default setup for "JUnit" execution

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Steven Rowe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135930#comment-13135930 ] Steven Rowe commented on LUCENE-3506: - bq. Tests run from intellij now fail saying th

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-26 Thread Yonik Seeley (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135928#comment-13135928 ] Yonik Seeley commented on LUCENE-3506: -- Tests run from intellij now fail saying that

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135256#comment-13135256 ] Uwe Schindler commented on LUCENE-3506: --- It may no longer apply to Java 6 javac, bu

RE: [jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Uwe Schindler
1 7:21 PM > To: dev@lucene.apache.org > Subject: [jira] [Commented] (LUCENE-3506) tests for verifying that assertions > are enabled do nothing since they ignore AssertionError > > > [ https://issues.apache.org/jira/browse/LUCENE- > 3506?page=com.atlassian.jira.plugin.s

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Dawid Weiss (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135247#comment-13135247 ] Dawid Weiss commented on LUCENE-3506: - Err... how is this different: {code} assert Bo

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135179#comment-13135179 ] Michael McCandless commented on LUCENE-3506: {quote} Actually today when you

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Doron Cohen (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135086#comment-13135086 ] Doron Cohen commented on LUCENE-3506: - bq. (Whereas today if you run that test w/o as

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135004#comment-13135004 ] Robert Muir commented on LUCENE-3506: - maybe make assertionsEnabled() static in Lucen

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135002#comment-13135002 ] Michael McCandless commented on LUCENE-3506: I'm confused here -- the changes

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134997#comment-13134997 ] Uwe Schindler commented on LUCENE-3506: --- +1 to commit! > tests for

[jira] [Commented] (LUCENE-3506) tests for verifying that assertions are enabled do nothing since they ignore AssertionError

2011-10-25 Thread Chris Male (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134987#comment-13134987 ] Chris Male commented on LUCENE-3506: Thanks for catching the Analyzer final assertion