[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201479#comment-13201479
]
Robert Muir commented on LUCENE-3736:
-
{quote}
The builder pattern (sorry Robert), is
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201481#comment-13201481
]
Michael McCandless commented on LUCENE-3736:
bq. But maybe we don't need it t
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201504#comment-13201504
]
Uwe Schindler commented on LUCENE-3736:
---
If you look at the test cases, the code is
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201508#comment-13201508
]
Robert Muir commented on LUCENE-3736:
-
Uwe, its not a big deal to me really... just a
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202446#comment-13202446
]
Michael McCandless commented on LUCENE-3736:
bq. If you look at the test case
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202454#comment-13202454
]
Michael McCandless commented on LUCENE-3736:
Another question: do we even nee
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202459#comment-13202459
]
Uwe Schindler commented on LUCENE-3736:
---
bq. Another question: do we even need a Pa
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202464#comment-13202464
]
Uwe Schindler commented on LUCENE-3736:
---
bq. Patch, removing the chained APIs
I di
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202463#comment-13202463
]
Uwe Schindler commented on LUCENE-3736:
---
Please keep the chained APIs, otherwise pl
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202478#comment-13202478
]
Robert Muir commented on LUCENE-3736:
-
As i stated earlier on the issue, I agree tech
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202489#comment-13202489
]
Michael McCandless commented on LUCENE-3736:
I think the changes here are awe
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202492#comment-13202492
]
Michael McCandless commented on LUCENE-3736:
OK I opened LUCENE-3756 to addre
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202497#comment-13202497
]
Uwe Schindler commented on LUCENE-3736:
---
If somebody wants to commit the changes, d
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202529#comment-13202529
]
Uwe Schindler commented on LUCENE-3736:
---
As a comment came up on IRC:
{quote}
[17:
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203697#comment-13203697
]
Michael McCandless commented on LUCENE-3736:
Thanks Uwe, I'll start from ther
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204997#comment-13204997
]
Uwe Schindler commented on LUCENE-3736:
---
Patch is incomplete? Maybe you forgot to s
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205032#comment-13205032
]
Uwe Schindler commented on LUCENE-3736:
---
Thanks, looks fine. I will look tomorrow i
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205313#comment-13205313
]
Uwe Schindler commented on LUCENE-3736:
---
Hi Mike,
I found a bug in your implementa
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205351#comment-13205351
]
Michael McCandless commented on LUCENE-3736:
Ooh, nice catch on that validati
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205398#comment-13205398
]
Uwe Schindler commented on LUCENE-3736:
---
A previous discussion on IRC with Mike:
W
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205556#comment-13205556
]
Michael McCandless commented on LUCENE-3736:
Looks great Uwe, thanks! +1
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210320#comment-13210320
]
Uwe Schindler commented on LUCENE-3736:
---
Committed trunk revision: 1245605
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210890#comment-13210890
]
Uwe Schindler commented on LUCENE-3736:
---
I committed some minor code cleanups in re
[
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212674#comment-13212674
]
Robert Muir commented on LUCENE-3736:
-
{quote}
(after the heavy commit of Robert, rev
24 matches
Mail list logo