[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626190#comment-13626190
]
Shai Erera commented on LUCENE-3786:
I actually started working on that a long time a
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626519#comment-13626519
]
Michael McCandless commented on LUCENE-3786:
OK I discussed these tricky issu
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626543#comment-13626543
]
Shai Erera commented on LUCENE-3786:
bq. I think it's OK to add IOE to the signature?
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627065#comment-13627065
]
Michael McCandless commented on LUCENE-3786:
{quote}
bq. that decRef could ha
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627435#comment-13627435
]
Shai Erera commented on LUCENE-3786:
Few comments:
* This assert in the test {{asser
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627824#comment-13627824
]
Shai Erera commented on LUCENE-3786:
I reviewed again, and now that you switch to cal
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627833#comment-13627833
]
Michael McCandless commented on LUCENE-3786:
bq. I reviewed again, and now th
[
https://issues.apache.org/jira/browse/LUCENE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627888#comment-13627888
]
Shai Erera commented on LUCENE-3786:
Looks good, +1. Thanks for doing the work Mike!
