[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411638#comment-13411638
]
Michael McCandless commented on LUCENE-3877:
+1, thanks Robert!
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409751#comment-13409751
]
Robert Muir commented on LUCENE-3877:
-
I think if we fix LUCENE-4202, we could just
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237479#comment-13237479
]
Dawid Weiss commented on LUCENE-3877:
-
No worries Greg, really. For 3.x I think
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237117#comment-13237117
]
Dawid Weiss commented on LUCENE-3877:
-
I'd push it to 4.0 (automation in whatever
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237380#comment-13237380
]
Greg Bowyer commented on LUCENE-3877:
-
Yeah sorry I have been busy at work for a
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235422#comment-13235422
]
Dawid Weiss commented on LUCENE-3877:
-
bq. I have seen it not work in the past for
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235424#comment-13235424
]
Dawid Weiss commented on LUCENE-3877:
-
My aspectj experiments from yesterday when
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235428#comment-13235428
]
Dawid Weiss commented on LUCENE-3877:
-
Oh, btw. I think a FindBugs rule for detecting
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234881#comment-13234881
]
Dawid Weiss commented on LUCENE-3877:
-
You can just as well substitute your own
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235065#comment-13235065
]
Greg Bowyer commented on LUCENE-3877:
-
Thats a good point and started bugging me last
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235087#comment-13235087
]
Dawid Weiss commented on LUCENE-3877:
-
fyi. PMD has a rule for this -- SystemPrintln.
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235090#comment-13235090
]
Greg Bowyer commented on LUCENE-3877:
-
Interesting I didnt look at PMD although that
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235112#comment-13235112
]
Dawid Weiss commented on LUCENE-3877:
-
I don't like PMD that much either, I'm just
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235196#comment-13235196
]
Greg Bowyer commented on LUCENE-3877:
-
Well would it sway the argument if I said that
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231053#comment-13231053
]
Dawid Weiss commented on LUCENE-3877:
-
Lots of tests write to std streams currently
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231090#comment-13231090
]
Michael McCandless commented on LUCENE-3877:
I think it's fine if tests write
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231095#comment-13231095
]
Dawid Weiss commented on LUCENE-3877:
-
This is possible by verifying where System.out
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231098#comment-13231098
]
Benson Margulies commented on LUCENE-3877:
--
findbugs? checkstyle?
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231176#comment-13231176
]
Mark Miller commented on LUCENE-3877:
-
Don't we now fail if there is a noncommit in
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231263#comment-13231263
]
Robert Muir commented on LUCENE-3877:
-
Some core code legitimately uses
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231272#comment-13231272
]
Robert Muir commented on LUCENE-3877:
-
IndexUpgrader is another example. I think if
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231286#comment-13231286
]
Luca Cavanna commented on LUCENE-3877:
--
I feel guilty...maybe because I wrote that
[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231307#comment-13231307
]
Michael McCandless commented on LUCENE-3877:
I removed the std prints in
23 matches
Mail list logo
