[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13395846#comment-13395846
]
Uwe Schindler commented on LUCENE-4132:
---
The 4.x commit also breaks the builds,
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13396233#comment-13396233
]
Uwe Schindler commented on LUCENE-4132:
---
bq. The 4.x commit also breaks the builds,
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295598#comment-13295598
]
Michael McCandless commented on LUCENE-4132:
bq. I re-added testReuse, with
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295634#comment-13295634
]
Shai Erera commented on LUCENE-4132:
bq. Shouldn't clone() be protected in
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294867#comment-13294867
]
Uwe Schindler commented on LUCENE-4132:
---
Hi Shai,
ignore all methods with
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294939#comment-13294939
]
Robert Muir commented on LUCENE-4132:
-
Can we override *all* methods so the javadocs
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294989#comment-13294989
]
Michael McCandless commented on LUCENE-4132:
Also can we rename it to
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295220#comment-13295220
]
Robert Muir commented on LUCENE-4132:
-
thanks, +1
IndexWriterConfig
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295269#comment-13295269
]
Shai Erera commented on LUCENE-4132:
Thanks Robert. I'll wait until Sunday and commit
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295394#comment-13295394
]
Michael McCandless commented on LUCENE-4132:
Hmm we are no longer cloning the
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294427#comment-13294427
]
Michael McCandless commented on LUCENE-4132:
I dislike chaining (return this
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294596#comment-13294596
]
Shai Erera commented on LUCENE-4132:
If there are no objections, I'd like to commit
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294626#comment-13294626
]
Robert Muir commented on LUCENE-4132:
-
I still feel the same way as before. I'm sorry
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294632#comment-13294632
]
Michael McCandless commented on LUCENE-4132:
Please don't rush this Shai.
I
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293783#comment-13293783
]
Robert Muir commented on LUCENE-4132:
-
I think the class hierarchy/generics are too
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293784#comment-13293784
]
Uwe Schindler commented on LUCENE-4132:
---
That's certified and suggested by the
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293788#comment-13293788
]
Robert Muir commented on LUCENE-4132:
-
Its not certified by me. Its too confusing for
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293791#comment-13293791
]
Michael McCandless commented on LUCENE-4132:
If we remove IWC's chained
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293792#comment-13293792
]
Uwe Schindler commented on LUCENE-4132:
---
We could, I am against, I love
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293844#comment-13293844
]
Shai Erera commented on LUCENE-4132:
I love it too, and the changes would be too
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293868#comment-13293868
]
Shai Erera commented on LUCENE-4132:
The generics is because I wanted to not
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293885#comment-13293885
]
Simon Willnauer commented on LUCENE-4132:
-
I think the generics here are not very
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292786#comment-13292786
]
Robert Muir commented on LUCENE-4132:
-
I don't think we should add another Config
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292788#comment-13292788
]
Shai Erera commented on LUCENE-4132:
{quote}
I don't think we should add another
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292789#comment-13292789
]
Robert Muir commented on LUCENE-4132:
-
Right, but i suppose changing live settings
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292792#comment-13292792
]
Robert Muir commented on LUCENE-4132:
-
ok actually i was partially wrong, one can no
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292793#comment-13292793
]
Shai Erera commented on LUCENE-4132:
bq. Today someone can take the config off of
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292794#comment-13292794
]
Robert Muir commented on LUCENE-4132:
-
sorry, instead of nuking getConfig make it
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292795#comment-13292795
]
Shai Erera commented on LUCENE-4132:
bq. I guess to be less confusing we should add
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292797#comment-13292797
]
Robert Muir commented on LUCENE-4132:
-
{quote}
True, but I'm not aware of such use,
30 matches
Mail list logo
