[jira] [Commented] (LUCENE-4228) Refactor CharFilter to be a java.io.FilterReader

2012-07-17 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416046#comment-13416046 ] Robert Muir commented on LUCENE-4228: - Ill commit this one in a little bit: we can th

[jira] [Commented] (LUCENE-4228) Refactor CharFilter to be a java.io.FilterReader

2012-07-16 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415651#comment-13415651 ] Robert Muir commented on LUCENE-4228: - Yeah Uwe, thats true. But its also true today

[jira] [Commented] (LUCENE-4228) Refactor CharFilter to be a java.io.FilterReader

2012-07-16 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415645#comment-13415645 ] Uwe Schindler commented on LUCENE-4228: --- +1, great!The only problem I see is: - If

[jira] [Commented] (LUCENE-4228) Refactor CharFilter to be a java.io.FilterReader

2012-07-16 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415626#comment-13415626 ] Michael McCandless commented on LUCENE-4228: +1, great simplification. Nice