[ 
https://issues.apache.org/jira/browse/LUCENE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431925#comment-13431925
 ] 

Robert Muir commented on LUCENE-4298:
-------------------------------------

Thanks Alberto: I see the problem, that the method is completely untested!

https://builds.apache.org/job/Lucene-trunk/2016/clover-report/org/apache/lucene/index/MultiFields.html

Nothing really uses this: e.g. SlowCompositeReaderWrapper just pulls from the 
MultiTermsEnum.

So we should add a test for this sugar method.
                
> Infinite recursion in MultiFields.getTermDocsEnum(IndexReader r, Bits 
> liveDocs, String field, BytesRef term)
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4298
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4298
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 4.0-BETA
>            Reporter: Alberto Paro
>         Attachments: LUCENE-4298.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The function calls itself:
> public static DocsEnum getTermDocsEnum(IndexReader r, Bits liveDocs, String 
> field, BytesRef term) throws IOException {
>     return getTermDocsEnum(r, liveDocs, field, term);
>   }
> The more conservative approach is to pass DocsEnum.FLAG_FREQS as last 
> parameter so we can call the getTermDocsEnum(IndexReader r, Bits liveDocs, 
> String field, BytesRef term, int flags).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to