[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610650#comment-13610650
]
Commit Tag Bot commented on LUCENE-4498:
[branch_4x commit] Robert Muir
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482307#comment-13482307
]
Robert Muir commented on LUCENE-4498:
-
Committed to trunk. will give that flonkings
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481480#comment-13481480
]
Robert Muir commented on LUCENE-4498:
-
I will work on a patch after LUCENE-4497 has
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481514#comment-13481514
]
Michael McCandless commented on LUCENE-4498:
+1
pulse
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481553#comment-13481553
]
Robert Muir commented on LUCENE-4498:
-
Actually I think for the other cases (not just
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481768#comment-13481768
]
Michael McCandless commented on LUCENE-4498:
Looks good:
{noformat}
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481769#comment-13481769
]
Robert Muir commented on LUCENE-4498:
-
This code can be simplified and generalized a
[
https://issues.apache.org/jira/browse/LUCENE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481824#comment-13481824
]
Michael McCandless commented on LUCENE-4498:
+1
Very nice to fold pulsing
