[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508195#comment-13508195 ] Gilad Barkai commented on LUCENE-4580: -- {{DrillDown}} is a useful class with a

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508199#comment-13508199 ] Uwe Schindler commented on LUCENE-4580: --- In my opinion, for Lucene 4.x we should

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508200#comment-13508200 ] Shai Erera commented on LUCENE-4580: Not that I'm against adding dependencies between

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508201#comment-13508201 ] Shai Erera commented on LUCENE-4580: bq. In my opinion, for Lucene 4.x we should move

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508202#comment-13508202 ] Gilad Barkai commented on LUCENE-4580: -- bq. it should be a combination of

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508211#comment-13508211 ] Uwe Schindler commented on LUCENE-4580: --- bq. Or better, move TermsFilter and

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508215#comment-13508215 ] Uwe Schindler commented on LUCENE-4580: --- bq. This is exactly what I proposed. I'm

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508239#comment-13508239 ] Shai Erera commented on LUCENE-4580: Uwe, the thinking that I had about Filter is

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508240#comment-13508240 ] Uwe Schindler commented on LUCENE-4580: --- Hi, In general I would prefer another

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508241#comment-13508241 ] Uwe Schindler commented on LUCENE-4580: --- bq. If a Filter is not cached, how

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508242#comment-13508242 ] Shai Erera commented on LUCENE-4580: It seems then that the only thing that needs to

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508243#comment-13508243 ] Uwe Schindler commented on LUCENE-4580: --- OK. I would add a test that verifies that

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507960#comment-13507960 ] Michael McCandless commented on LUCENE-4580: +1 Facet

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507982#comment-13507982 ] Gilad Barkai commented on LUCENE-4580: -- +1 Facet DrillDown should

[jira] [Commented] (LUCENE-4580) Facet DrillDown should return a Filter not Query

[ https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508181#comment-13508181 ] Shai Erera commented on LUCENE-4580: I took a look at TermsFilter (under the queries