[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960055#comment-13960055
]
ASF subversion and git services commented on LUCENE-5527:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959340#comment-13959340
]
Hoss Man commented on LUCENE-5527:
--
bq. I dont think we have to "give up" on the close()
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959326#comment-13959326
]
Robert Muir commented on LUCENE-5527:
-
I dont think we have to "give up" on the close
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959324#comment-13959324
]
Hoss Man commented on LUCENE-5527:
--
bq. Its controversial. ...
Fair enough, i retract t
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959300#comment-13959300
]
Robert Muir commented on LUCENE-5527:
-
{quote}
Even if parallelization is controvers
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959280#comment-13959280
]
Adrien Grand commented on LUCENE-5527:
--
I think there are things to discuss regardin
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959254#comment-13959254
]
Hoss Man commented on LUCENE-5527:
--
bq. The patch only moves 3 methods of the Collector
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959252#comment-13959252
]
Adrien Grand commented on LUCENE-5527:
--
Uwe, are you talking about the {{LeafReader}
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959246#comment-13959246
]
Uwe Schindler commented on LUCENE-5527:
---
bq. That surprised me that it was marked a
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959225#comment-13959225
]
Yonik Seeley commented on LUCENE-5527:
--
bq. I had initially thought about doing this
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959218#comment-13959218
]
Adrien Grand commented on LUCENE-5527:
--
The patch only moves 3 methods of the {{Coll
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959116#comment-13959116
]
Hoss Man commented on LUCENE-5527:
--
bq. Indeed there is! I think it would be nice to hav
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959109#comment-13959109
]
Adrien Grand commented on LUCENE-5527:
--
bq. Thanks for picking this up Adrien! I alw
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959101#comment-13959101
]
Shikhar Bhushan commented on LUCENE-5527:
-
Thanks for picking this up Adrien! I a
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959092#comment-13959092
]
Adrien Grand commented on LUCENE-5527:
--
bq. is setNextReader really an appropriate n
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959080#comment-13959080
]
Hoss Man commented on LUCENE-5527:
--
This isn't an area of Lucene i tend to think much ab
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959078#comment-13959078
]
Michael McCandless commented on LUCENE-5527:
+1 for LeafCollector and the pat
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959075#comment-13959075
]
Adrien Grand commented on LUCENE-5527:
--
I opened LUCENE-5569 to discuss the renaming
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959036#comment-13959036
]
Ryan Ernst commented on LUCENE-5527:
+1
> Make the Collector API work per-segment
>
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959030#comment-13959030
]
Adrien Grand commented on LUCENE-5527:
--
I like {{LeafCollector}} better too. So let'
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958984#comment-13958984
]
Ryan Ernst commented on LUCENE-5527:
{quote}
I guess I wish AtomicReader were named L
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958894#comment-13958894
]
Robert Muir commented on LUCENE-5527:
-
That makes sense. Honestly I think my issue is
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958891#comment-13958891
]
Adrien Grand commented on LUCENE-5527:
--
I chose these names to make it clear what th
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958871#comment-13958871
]
Robert Muir commented on LUCENE-5527:
-
In my opinion we should rethink the naming her
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936430#comment-13936430
]
Shai Erera commented on LUCENE-5527:
Maybe we can get rid of setScorer, passing Score
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936426#comment-13936426
]
David Smiley commented on LUCENE-5527:
--
+1 I like it!
> Make the Collector API work
26 matches
Mail list logo
