[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964623#comment-13964623
]
Uwe Schindler commented on LUCENE-5570:
---
Hi, because [~simonw] asked me: The
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964757#comment-13964757
]
ASF subversion and git services commented on LUCENE-5570:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964759#comment-13964759
]
Michael McCandless commented on LUCENE-5570:
OK I committed Rob's last patch
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964794#comment-13964794
]
Uwe Schindler commented on LUCENE-5570:
---
I reopened that issue to correctly close
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959949#comment-13959949
]
Simon Willnauer commented on LUCENE-5570:
-
seems like we prepare for 4.7.2 I
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1395#comment-1395
]
Robert Muir commented on LUCENE-5570:
-
Upon researching, I think we should address
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960206#comment-13960206
]
Uwe Schindler commented on LUCENE-5570:
---
Patch looks fine, only the APPEND is not
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960215#comment-13960215
]
Michael McCandless commented on LUCENE-5570:
Patch looks good.
bq. Another
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960218#comment-13960218
]
Uwe Schindler commented on LUCENE-5570:
---
One more addition: I am not sure if the
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960231#comment-13960231
]
Michael McCandless commented on LUCENE-5570:
bq. In my opinion, the sync()
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960228#comment-13960228
]
ASF subversion and git services commented on LUCENE-5570:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960236#comment-13960236
]
Robert Muir commented on LUCENE-5570:
-
{quote}
I think the non-atomicness is fine
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960238#comment-13960238
]
ASF subversion and git services commented on LUCENE-5570:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960260#comment-13960260
]
Michael McCandless commented on LUCENE-5570:
+1 for java6 version.
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960448#comment-13960448
]
Simon Willnauer commented on LUCENE-5570:
-
+1 LGTM
FSDirectory's fsync() is
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960486#comment-13960486
]
Uwe Schindler commented on LUCENE-5570:
---
bq. The whole method isnt atomic anyway,
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960523#comment-13960523
]
Robert Muir commented on LUCENE-5570:
-
Ok, I am fine with waiting for 4.8 . But this
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960542#comment-13960542
]
Michael McCandless commented on LUCENE-5570:
I think this is worth fixing for
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959108#comment-13959108
]
Robert Muir commented on LUCENE-5570:
-
As far as this staleFiles, we can keep it if
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959110#comment-13959110
]
Michael McCandless commented on LUCENE-5570:
bq. if something bad happens
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959112#comment-13959112
]
Robert Muir commented on LUCENE-5570:
-
{quote}
This is because IW passes all files
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959115#comment-13959115
]
Robert Muir commented on LUCENE-5570:
-
By the way i think we can go back to RAF
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959217#comment-13959217
]
Simon Willnauer commented on LUCENE-5570:
-
after looking on the bug that lead to
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959258#comment-13959258
]
Michael McCandless commented on LUCENE-5570:
+1, new patch looks great; I
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959263#comment-13959263
]
Uwe Schindler commented on LUCENE-5570:
---
bq. after looking on the bug that lead to
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959262#comment-13959262
]
Robert Muir commented on LUCENE-5570:
-
I'll make a followup issue for the stale files
[
https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959268#comment-13959268
]
Robert Muir commented on LUCENE-5570:
-
{quote}
I am just a little bit sceptical if a
27 matches
Mail list logo
