[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497814#comment-14497814
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497809#comment-14497809
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491753#comment-14491753
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491466#comment-14491466
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490288#comment-14490288
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486988#comment-14486988
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486986#comment-14486986
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484968#comment-14484968
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484979#comment-14484979
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482886#comment-14482886
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482887#comment-14482887
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481095#comment-14481095
]
Michael McCandless commented on LUCENE-5879:
I'll backport this to 5.2 soon
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396157#comment-14396157
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396152#comment-14396152
]
Michael McCandless commented on LUCENE-5879:
Woops ... the term range
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392802#comment-14392802
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392803#comment-14392803
]
Michael McCandless commented on LUCENE-5879:
I committed to trunk ... I'll
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392701#comment-14392701
]
Robert Muir commented on LUCENE-5879:
-
+1
I thought those tests were gonna be
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392815#comment-14392815
]
ASF subversion and git services commented on LUCENE-5879:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388339#comment-14388339
]
Adrien Grand commented on LUCENE-5879:
--
+1 to the patch
bq. I don't think we should
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388500#comment-14388500
]
Robert Muir commented on LUCENE-5879:
-
We should be able to add a trivial test to
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388560#comment-14388560
]
Robert Muir commented on LUCENE-5879:
-
+1 to the patch. I can add the tests later if
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371401#comment-14371401
]
Michael McCandless commented on LUCENE-5879:
bq. I don't understand why these
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371671#comment-14371671
]
Robert Muir commented on LUCENE-5879:
-
{quote}
I.e., with the patch as it is now, PFs
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372077#comment-14372077
]
Michael McCandless commented on LUCENE-5879:
{quote}
We cannot continue
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372159#comment-14372159
]
Robert Muir commented on LUCENE-5879:
-
Yes, everything you propose makes sense
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369723#comment-14369723
]
Michael McCandless commented on LUCENE-5879:
Thanks Rob.
bq. If you use
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367397#comment-14367397
]
Robert Muir commented on LUCENE-5879:
-
{quote}
The added auto-prefix terms are not
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367385#comment-14367385
]
Robert Muir commented on LUCENE-5879:
-
{quote}
There are maybe some problems with the
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367407#comment-14367407
]
Robert Muir commented on LUCENE-5879:
-
Can you fill in more detail about
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159483#comment-14159483
]
Michael McCandless commented on LUCENE-5879:
I think we can salvage parts of
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157857#comment-14157857
]
Robert Muir commented on LUCENE-5879:
-
{quote}
but the nasty downside of
all this
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156212#comment-14156212
]
Michael McCandless commented on LUCENE-5879:
Thanks for reviewing Rob.
bq.
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156222#comment-14156222
]
Michael McCandless commented on LUCENE-5879:
bq. Patch looks good except for
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156389#comment-14156389
]
Robert Muir commented on LUCENE-5879:
-
{quote}
We need this stub class because of the
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156547#comment-14156547
]
Michael McCandless commented on LUCENE-5879:
Maybe we can somehow change the
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156560#comment-14156560
]
Robert Muir commented on LUCENE-5879:
-
I think its enough to just add a comment to
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156579#comment-14156579
]
Michael McCandless commented on LUCENE-5879:
OK I'll add a comment explaining
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155245#comment-14155245
]
Michael McCandless commented on LUCENE-5879:
bq. But the problem is, at
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155699#comment-14155699
]
Robert Muir commented on LUCENE-5879:
-
{quote}
One approach we might be able to take
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155732#comment-14155732
]
Robert Muir commented on LUCENE-5879:
-
Patch looks good except for
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143219#comment-14143219
]
Michael McCandless commented on LUCENE-5879:
bq. So for the whole segment,
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142590#comment-14142590
]
David Smiley commented on LUCENE-5879:
--
Some more questions:
bq. It's per-segment,
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142766#comment-14142766
]
Robert Muir commented on LUCENE-5879:
-
{quote}
Although there is some elegance to
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140477#comment-14140477
]
Michael McCandless commented on LUCENE-5879:
I plan to commit this soon to
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140858#comment-14140858
]
Uwe Schindler commented on LUCENE-5879:
---
And how about NRQ? The same? Currently its
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140916#comment-14140916
]
Robert Muir commented on LUCENE-5879:
-
We should think about a migration plan for
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140925#comment-14140925
]
David Smiley commented on LUCENE-5879:
--
Wow, awesome work Mike! And fantastic idea
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140942#comment-14140942
]
David Smiley commented on LUCENE-5879:
--
bq. Is the auto-prefixing done on a
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141048#comment-14141048
]
Michael McCandless commented on LUCENE-5879:
I like that plan Rob, except the
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141061#comment-14141061
]
Michael McCandless commented on LUCENE-5879:
OK I created LUCENE-5966 for the
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141096#comment-14141096
]
Michael McCandless commented on LUCENE-5879:
bq. Wow, awesome work Mike! And
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141101#comment-14141101
]
Michael McCandless commented on LUCENE-5879:
OK I opened LUCENE-5967 to allow
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141108#comment-14141108
]
David Smiley commented on LUCENE-5879:
--
bq. Is this applicable to variable-length
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141114#comment-14141114
]
Michael McCandless commented on LUCENE-5879:
bq. I simply mean is this useful
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135289#comment-14135289
]
Robert Muir commented on LUCENE-5879:
-
Can experimental please be added to
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135389#comment-14135389
]
Michael McCandless commented on LUCENE-5879:
bq. Can experimental please be
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131593#comment-14131593
]
Michael McCandless commented on LUCENE-5879:
Hmm, one problem here is ...
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112128#comment-14112128
]
Adrien Grand commented on LUCENE-5879:
--
The numbers look great, it's quite
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093891#comment-14093891
]
Adrien Grand commented on LUCENE-5879:
--
Thanks Mike for working on this, this is a
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093924#comment-14093924
]
Michael McCandless commented on LUCENE-5879:
{quote}
bq. Maybe we need a new
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093926#comment-14093926
]
Robert Muir commented on LUCENE-5879:
-
If the existing API is confusing, making it
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093929#comment-14093929
]
Uwe Schindler commented on LUCENE-5879:
---
In fact, as far as I see:
[
https://issues.apache.org/jira/browse/LUCENE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094076#comment-14094076
]
Michael McCandless commented on LUCENE-5879:
bq. In fact, as far as I see:
63 matches
Mail list logo
