[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614668#comment-14614668
]
Markus Heiden commented on LUCENE-6365:
---
I have executed the tests in lucene/core
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614706#comment-14614706
]
Dawid Weiss commented on LUCENE-6365:
-
I don't think so. The test in question (and
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614770#comment-14614770
]
Markus Heiden commented on LUCENE-6365:
---
The de-duplication has prior been
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614919#comment-14614919
]
Dawid Weiss commented on LUCENE-6365:
-
I think it even makes more sense to leave the
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615041#comment-14615041
]
Michael McCandless commented on LUCENE-6365:
Ahh thanks for digging
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615048#comment-14615048
]
Michael McCandless commented on LUCENE-6365:
I'll fix the test to de-dup
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615053#comment-14615053
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615051#comment-14615051
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615453#comment-14615453
]
Dawid Weiss commented on LUCENE-6365:
-
Thanks Mike.
Optimized iteration of finite
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614263#comment-14614263
]
Michael McCandless commented on LUCENE-6365:
Hmm this failure just appeared
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614029#comment-14614029
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614034#comment-14614034
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614036#comment-14614036
]
Michael McCandless commented on LUCENE-6365:
[~markus_heiden] maybe try the
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613789#comment-14613789
]
Markus Heiden commented on LUCENE-6365:
---
@Michael: The removal of
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613686#comment-14613686
]
Uwe Schindler commented on LUCENE-6365:
---
bq. I agree that reuse is no good design,
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613341#comment-14613341
]
Markus Heiden commented on LUCENE-6365:
---
I see, I am not able to convince you ;-)
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613274#comment-14613274
]
Michael McCandless commented on LUCENE-6365:
bq. I adapted my patch to the
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613295#comment-14613295
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613296#comment-14613296
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613433#comment-14613433
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613432#comment-14613432
]
ASF subversion and git services commented on LUCENE-6365:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612534#comment-14612534
]
Markus Heiden commented on LUCENE-6365:
---
I adapted my patch to the latest changes
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552643#comment-14552643
]
Michael McCandless commented on LUCENE-6365:
bq. The Iterator interface is
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547895#comment-14547895
]
Markus Heiden commented on LUCENE-6365:
---
The Iterator interface is not possible
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543443#comment-14543443
]
Michael McCandless commented on LUCENE-6365:
I would really prefer not make
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537160#comment-14537160
]
Markus Heiden commented on LUCENE-6365:
---
For the normal use case I agree. But I had
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536310#comment-14536310
]
Dawid Weiss commented on LUCENE-6365:
-
mainly to optimize the performance of the
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534633#comment-14534633
]
Michael McCandless commented on LUCENE-6365:
Thanks [~markus_heiden], new
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535302#comment-14535302
]
Areek Zillur commented on LUCENE-6365:
--
+1 to removing PositionIncrementAttr from
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535585#comment-14535585
]
Markus Heiden commented on LUCENE-6365:
---
Removing init(): One my design goals was
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491672#comment-14491672
]
Dawid Weiss commented on LUCENE-6365:
-
{code}
for (IntsRef finiteString;
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491743#comment-14491743
]
Michael McCandless commented on LUCENE-6365:
Can you add in the javadocs of
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490888#comment-14490888
]
Markus Heiden commented on LUCENE-6365:
---
Are you talking about for (IntsRef
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482753#comment-14482753
]
Dawid Weiss commented on LUCENE-6365:
-
Oops, apologies Markus, this slipped my agenda
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482044#comment-14482044
]
Michael McCandless commented on LUCENE-6365:
I like this change overall ...
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14374820#comment-14374820
]
Markus Heiden commented on LUCENE-6365:
---
I talked about the stack like structure
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14373083#comment-14373083
]
Markus Heiden commented on LUCENE-6365:
---
I prefer a standard Iterator too. But by
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14373092#comment-14373092
]
Robert Muir commented on LUCENE-6365:
-
{quote}
BTW: May we choose a bigger initial
[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369645#comment-14369645
]
Dawid Weiss commented on LUCENE-6365:
-
I looked at the patch (briefly, without
39 matches
Mail list logo
