[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612526#comment-14612526 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612489#comment-14612489 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612477#comment-14612477 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612440#comment-14612440 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612437#comment-14612437 ] Uwe Schindler commented on LUCENE-6651: --- I added a test for the old reflector code,

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612435#comment-14612435 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612183#comment-14612183 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612169#comment-14612169 ] Uwe Schindler commented on LUCENE-6651: --- The only special case is CharTermAttribute

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612168#comment-14612168 ] Uwe Schindler commented on LUCENE-6651: --- toString() should not be implemented, beca

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612149#comment-14612149 ] Mike Drob commented on LUCENE-6651: --- Nit: {{ComputedRangesAttributeImpl c = (ComputedRa

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612148#comment-14612148 ] ASF subversion and git services commented on LUCENE-6651: - Commit

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612111#comment-14612111 ] Robert Muir commented on LUCENE-6651: - +1 > Remove private field reflection (setAcce

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-02 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612059#comment-14612059 ] Uwe Schindler commented on LUCENE-6651: --- So coming back to this one. After cleanup

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-01 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610823#comment-14610823 ] Robert Muir commented on LUCENE-6651: - I like the idea of the simple solution! I agre

[jira] [Commented] (LUCENE-6651) Remove private field reflection (setAccessible) in AttributeImpl#reflectWith

2015-07-01 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610444#comment-14610444 ] Uwe Schindler commented on LUCENE-6651: --- I opened LUCENE-6652 to remove a lot of du