[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-11-30 Thread Sachin Rajendra (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033065#comment-15033065 ] Sachin Rajendra commented on LUCENE-6744: - Hi [~erickerickson], Thanks for the detailed

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-11-28 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030614#comment-15030614 ] Erick Erickson commented on LUCENE-6744: Well, a few things: > I didn't offer to shepherd it

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-11-27 Thread Sachin Rajendra (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030393#comment-15030393 ] Sachin Rajendra commented on LUCENE-6744: - [~erickerickson] A gentle reminder to kindly take a

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-11-22 Thread Sachin Rajendra (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021497#comment-15021497 ] Sachin Rajendra commented on LUCENE-6744: - I have attached the patch. From the above

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-11-21 Thread Sachin Rajendra (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020631#comment-15020631 ] Sachin Rajendra commented on LUCENE-6744: - Newdev here. Wanted to know if I can do this. Kindly

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-11-21 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020656#comment-15020656 ] Erick Erickson commented on LUCENE-6744: Sure, just make a patch and add it to the JIRA ;).

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-10-08 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948993#comment-14948993 ] Paul Elschot commented on LUCENE-6744: -- There is also LUCENE-6467, perhaps that can be merged here.

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-10-07 Thread Scott Stults (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947564#comment-14947564 ] Scott Stults commented on LUCENE-6744: -- Java 7 is the documented minimum language level for Solr, so

[jira] [Commented] (LUCENE-6744) equals methods should compare classes directly, not use instanceof

2015-08-18 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701688#comment-14701688 ] Edward Ribeiro commented on LUCENE-6744: My two cents: I have always preferred to