[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465152#comment-16465152 ] Robert Muir commented on LUCENE-7960: - Again I want to re-emphasize that anything more complex than a

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463930#comment-16463930 ] Shawn Heisey commented on LUCENE-7960: -- On first blush, an enum seems even more of a mess than one

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461976#comment-16461976 ] Ingomar Wesp commented on LUCENE-7960: -- I understand your concern. As far as I can tell, there are

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461792#comment-16461792 ] Shawn Heisey commented on LUCENE-7960: -- That idea had nothing to do with the number of booleans.

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461782#comment-16461782 ] Robert Muir commented on LUCENE-7960: - Sorry, varargs are completely uncalled for here. Arguing for

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461777#comment-16461777 ] Shawn Heisey commented on LUCENE-7960: -- The one thing that I do not know is whether an added

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461767#comment-16461767 ] Shawn Heisey commented on LUCENE-7960: -- An example of where I used the ellipsis notation in my own

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461757#comment-16461757 ] Shawn Heisey commented on LUCENE-7960: -- I just thought of a particularly ugly idea that would

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461700#comment-16461700 ] Shawn Heisey commented on LUCENE-7960: -- The "obvious" workaround to either situation is to decrease

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461695#comment-16461695 ] Shawn Heisey commented on LUCENE-7960: -- My original idea would have been handled by one boolean --

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461683#comment-16461683 ] Robert Muir commented on LUCENE-7960: - my biggest concern is that these filters would then have two

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461673#comment-16461673 ] Shawn Heisey commented on LUCENE-7960: -- Updated patch. Does not deprecate constructors, does not

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461660#comment-16461660 ] Shawn Heisey commented on LUCENE-7960: -- [~rcmuir] so you would keep the current constructor around

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461514#comment-16461514 ] Robert Muir commented on LUCENE-7960: - The patch doesn't add up to me. The description of this issue

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461325#comment-16461325 ] Ingomar Wesp commented on LUCENE-7960: -- Thanks a lot for your support. I don't quite understand your

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460312#comment-16460312 ] Shawn Heisey commented on LUCENE-7960: -- Updated patch added. Deprecates the existing 3-arg

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460304#comment-16460304 ] Shawn Heisey commented on LUCENE-7960: -- Applying the PR as-is does seem to work. All the tests are

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460226#comment-16460226 ] Shawn Heisey commented on LUCENE-7960: -- I have basically come to the conclusion that I have

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459873#comment-16459873 ] Shawn Heisey commented on LUCENE-7960: -- I've gotten a look at the PR. Changing the signature on an

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453005#comment-16453005 ] Ingomar Wesp commented on LUCENE-7960: -- I've just updated the patch in PR #362. I now also have a

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426221#comment-16426221 ] Ingomar Wesp commented on LUCENE-7960: -- Ok, I just added the same paramteters to the

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421621#comment-16421621 ] Ingomar Wesp commented on LUCENE-7960: -- Thanks for your feedback! Yes, this is exactly the behavior

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421479#comment-16421479 ] Shawn Heisey commented on LUCENE-7960: -- When I created this issue, I didn't think about long terms.

[jira] [Commented] (LUCENE-7960) NGram filters -- add option to keep short terms

[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421475#comment-16421475 ] Ingomar Wesp commented on LUCENE-7960: -- I'd like to propose a patch (see attached pull request #349)