[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502061#comment-16502061
]
ASF subversion and git services commented on LUCENE-7960:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502057#comment-16502057
]
ASF subversion and git services commented on LUCENE-7960:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501211#comment-16501211
]
ASF subversion and git services commented on LUCENE-7960:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501163#comment-16501163
]
ASF subversion and git services commented on LUCENE-7960:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501130#comment-16501130
]
ASF subversion and git services commented on LUCENE-7960:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500742#comment-16500742
]
Ingomar Wesp commented on LUCENE-7960:
--
So ... anyone willing to merge this into master?
> NGram
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483721#comment-16483721
]
Robert Muir commented on LUCENE-7960:
-
looks good. thank you for making the updates.
> NGram filters
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482180#comment-16482180
]
Ingomar Wesp commented on LUCENE-7960:
--
Just updated the patch. In the end, I decided against
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477950#comment-16477950
]
Ingomar Wesp commented on LUCENE-7960:
--
Thanks for looking into this. No, I didn't get anything,
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476817#comment-16476817
]
Robert Muir commented on LUCENE-7960:
-
{quote}
*) Even though I'm watching this issue, I'm not
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476383#comment-16476383
]
Ingomar Wesp commented on LUCENE-7960:
--
Sorry for not responding earlier*. Looks good to me;
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468292#comment-16468292
]
Robert Muir commented on LUCENE-7960:
-
{quote}
I made the min/max parameters required on the factory
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468227#comment-16468227
]
Shawn Heisey commented on LUCENE-7960:
--
All good points.
I made the min/max parameters required on
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468161#comment-16468161
]
Robert Muir commented on LUCENE-7960:
-
Also for the full ctor that allows a range, i really still
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468156#comment-16468156
]
Robert Muir commented on LUCENE-7960:
-
The patch has a little confusion about back compat (e.g.
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468129#comment-16468129
]
Shawn Heisey commented on LUCENE-7960:
--
Uploading new patch. [~iwesp], please make sure I haven't
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467968#comment-16467968
]
Robert Muir commented on LUCENE-7960:
-
then it would behave like you expect an n-gram filter to
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467964#comment-16467964
]
Shawn Heisey commented on LUCENE-7960:
--
What would happen when there's only one int in the
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467894#comment-16467894
]
Robert Muir commented on LUCENE-7960:
-
Yes, I think we should deprecate. It helps ppl upgrade and
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467599#comment-16467599
]
David Smiley commented on LUCENE-7960:
--
A new preserveOriginal will be nice, and also consistent
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465233#comment-16465233
]
Shawn Heisey commented on LUCENE-7960:
--
Thanks for the clarification. Should the no-arg constructor
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465221#comment-16465221
]
Robert Muir commented on LUCENE-7960:
-
There is no need to have only one constructor: two many
[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465199#comment-16465199
]
Shawn Heisey commented on LUCENE-7960:
--
OK, so we re-engineer to only add a preserveOriginal
23 matches
Mail list logo
