[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771013#comment-16771013
]
Simon Willnauer commented on LUCENE-8292:
-
[~dsmiley] I coordinated this with [~romseygeek]
I spoke to Alan about this before pushing and we have an unresolved solr
blocker too
> On 15. Feb 2019, at 22:56, David Smiley (JIRA) wrote:
>
>
>[
>
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769780#comment-16769780
]
David Smiley commented on LUCENE-8292:
--
Thanks Simon. I didn't think this could get in to 8.x at
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769485#comment-16769485
]
ASF subversion and git services commented on LUCENE-8292:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769486#comment-16769486
]
ASF subversion and git services commented on LUCENE-8292:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769479#comment-16769479
]
ASF subversion and git services commented on LUCENE-8292:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769324#comment-16769324
]
Simon Willnauer commented on LUCENE-8292:
-
I opened a PR here
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769236#comment-16769236
]
Robert Muir commented on LUCENE-8292:
-
the solution is, don't use delegators except over interfaces
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769148#comment-16769148
]
Dawid Weiss commented on LUCENE-8292:
-
I don't think I ever saw a "nice" solution to the problem of
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769128#comment-16769128
]
Adrien Grand commented on LUCENE-8292:
--
I don't think there is a perfect fix here, the current
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768299#comment-16768299
]
David Smiley commented on LUCENE-8292:
--
+1 to your proposal Simon. Such a proposal could even
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767061#comment-16767061
]
Simon Willnauer commented on LUCENE-8292:
-
I do see both points here. [~dsmiley] I hate how
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763797#comment-16763797
]
David Smiley commented on LUCENE-8292:
--
Adrien last said:
{quote}In general, we do not delegate
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480093#comment-16480093
]
David Smiley commented on LUCENE-8292:
--
Great example! I was playing around with
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475579#comment-16475579
]
Bruno Roustant commented on LUCENE-8292:
Actually there is also another related issue with this
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465914#comment-16465914
]
David Smiley commented on LUCENE-8292:
--
Yes, you'd need to modify the other classes to override to
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465887#comment-16465887
]
Bruno Roustant commented on LUCENE-8292:
[~dsmiley], if I create a subclass of FilterTermsEnum to
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465875#comment-16465875
]
David Smiley commented on LUCENE-8292:
--
Maybe it would be helpful if we simply add a _commented_ to
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465767#comment-16465767
]
Bruno Roustant commented on LUCENE-8292:
I just realized that the current no-default-override
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462501#comment-16462501
]
David Smiley commented on LUCENE-8292:
--
_Any_ use of a delegating wrapper is arguably "trappy" in
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462409#comment-16462409
]
Bruno Roustant commented on LUCENE-8292:
Another option would be to modify the
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462394#comment-16462394
]
Bruno Roustant commented on LUCENE-8292:
When looking at TermsEnum API, what I understand is that
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462378#comment-16462378
]
Adrien Grand commented on LUCENE-8292:
--
Indeed these methods need to be overridden explicitly if you
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462368#comment-16462368
]
Bruno Roustant commented on LUCENE-8292:
1- "Not possible to override": I was not clear. It is
[
https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462356#comment-16462356
]
Adrien Grand commented on LUCENE-8292:
--
This may be a bit trappy: if someone writes a
25 matches
Mail list logo
